Commit d3d92148 authored by Michael de Hoog's avatar Michael de Hoog

Remove minRatio assertion

parent 5a8db2b9
...@@ -27,7 +27,6 @@ func TestShadowCompressor(t *testing.T) { ...@@ -27,7 +27,6 @@ func TestShadowCompressor(t *testing.T) {
data [][]byte data [][]byte
errs []error errs []error
fullErr error fullErr error
minRatio float64
} }
tests := []test{{ tests := []test{{
...@@ -44,7 +43,6 @@ func TestShadowCompressor(t *testing.T) { ...@@ -44,7 +43,6 @@ func TestShadowCompressor(t *testing.T) {
data: [][]byte{bytes.Repeat([]byte{0}, 1024)}, data: [][]byte{bytes.Repeat([]byte{0}, 1024)},
errs: []error{nil}, errs: []error{nil},
fullErr: derive.CompressorFullErr, fullErr: derive.CompressorFullErr,
minRatio: 0.02,
}, { }, {
name: "large second block", name: "large second block",
targetFrameSize: 1, targetFrameSize: 1,
...@@ -52,7 +50,6 @@ func TestShadowCompressor(t *testing.T) { ...@@ -52,7 +50,6 @@ func TestShadowCompressor(t *testing.T) {
data: [][]byte{bytes.Repeat([]byte{0}, 512), bytes.Repeat([]byte{0}, 1024)}, data: [][]byte{bytes.Repeat([]byte{0}, 512), bytes.Repeat([]byte{0}, 1024)},
errs: []error{nil, derive.CompressorFullErr}, errs: []error{nil, derive.CompressorFullErr},
fullErr: derive.CompressorFullErr, fullErr: derive.CompressorFullErr,
minRatio: 0.02,
}, { }, {
name: "random data", name: "random data",
targetFrameSize: 1200, targetFrameSize: 1200,
...@@ -60,7 +57,6 @@ func TestShadowCompressor(t *testing.T) { ...@@ -60,7 +57,6 @@ func TestShadowCompressor(t *testing.T) {
data: [][]byte{randomBytes(t, 512), randomBytes(t, 512), randomBytes(t, 512)}, data: [][]byte{randomBytes(t, 512), randomBytes(t, 512), randomBytes(t, 512)},
errs: []error{nil, nil, derive.CompressorFullErr}, errs: []error{nil, nil, derive.CompressorFullErr},
fullErr: derive.CompressorFullErr, fullErr: derive.CompressorFullErr,
minRatio: 0.8,
}} }}
for _, test := range tests { for _, test := range tests {
test := test test := test
...@@ -71,10 +67,8 @@ func TestShadowCompressor(t *testing.T) { ...@@ -71,10 +67,8 @@ func TestShadowCompressor(t *testing.T) {
sc, err := batcher.NewShadowCompressor(test.targetFrameSize, test.targetNumFrames) sc, err := batcher.NewShadowCompressor(test.targetFrameSize, test.targetNumFrames)
require.NoError(t, err) require.NoError(t, err)
inputSize := 0
for i, d := range test.data { for i, d := range test.data {
_, err = sc.Write(d) _, err = sc.Write(d)
inputSize += len(d)
if test.errs[i] != nil { if test.errs[i] != nil {
require.ErrorIs(t, err, test.errs[i]) require.ErrorIs(t, err, test.errs[i])
require.Equal(t, i, len(test.data)-1) require.Equal(t, i, len(test.data)-1)
...@@ -95,10 +89,6 @@ func TestShadowCompressor(t *testing.T) { ...@@ -95,10 +89,6 @@ func TestShadowCompressor(t *testing.T) {
buf, err := io.ReadAll(sc) buf, err := io.ReadAll(sc)
require.NoError(t, err) require.NoError(t, err)
if inputSize > 0 {
require.LessOrEqual(t, float64(len(buf))/float64(inputSize), test.minRatio)
}
r, err := zlib.NewReader(bytes.NewBuffer(buf)) r, err := zlib.NewReader(bytes.NewBuffer(buf))
require.NoError(t, err) require.NoError(t, err)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment