Commit db0dbfb2 authored by smartcontracts's avatar smartcontracts Committed by Kelvin Fichter

feat[contracts]: temporarily disable EOA upgrades (#857)

* feat[contracts]: disable eoa upgrades temporarily

* chore: add changeset

* Update OVM_ProxyEOA.sol

* fix: turn upgrade into a noop

* lint: fix
parent f87a2d00
---
'@eth-optimism/contracts': minor
---
Disables EOA contract upgrades until further notice
...@@ -19,7 +19,7 @@ contract OVM_ProxyEOA { ...@@ -19,7 +19,7 @@ contract OVM_ProxyEOA {
/********** /**********
* Events * * Events *
**********/ **********/
event Upgraded( event Upgraded(
address indexed implementation address indexed implementation
); );
...@@ -71,13 +71,17 @@ contract OVM_ProxyEOA { ...@@ -71,13 +71,17 @@ contract OVM_ProxyEOA {
) )
external external
{ {
require( // NOTE: Upgrades are temporarily disabled because users can, in theory, modify their EOA
msg.sender == Lib_ExecutionManagerWrapper.ovmADDRESS(), // so that they don't have to pay any fees to the sequencer. Function will remain disabled
"EOAs can only upgrade their own EOA implementation" // until a robust solution is in place.
);
// require(
// msg.sender == Lib_ExecutionManagerWrapper.ovmADDRESS(),
// "EOAs can only upgrade their own EOA implementation"
// );
_setImplementation(_implementation); // _setImplementation(_implementation);
emit Upgraded(_implementation); // emit Upgraded(_implementation);
} }
/** /**
......
...@@ -44,7 +44,9 @@ describe('OVM_ProxyEOA', () => { ...@@ -44,7 +44,9 @@ describe('OVM_ProxyEOA', () => {
}) })
}) })
describe('upgrade()', () => { // NOTE: Upgrades are disabled for now but will be re-enabled at a later point in time. See
// comment in OVM_ProxyEOA.sol for additional information.
describe.skip('upgrade()', () => {
it(`should upgrade the proxy implementation`, async () => { it(`should upgrade the proxy implementation`, async () => {
const newImpl = `0x${'81'.repeat(20)}` const newImpl = `0x${'81'.repeat(20)}`
Mock__OVM_ExecutionManager.smocked.ovmADDRESS.will.return.with( Mock__OVM_ExecutionManager.smocked.ovmADDRESS.will.return.with(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment