Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
dbf4f28c
Commit
dbf4f28c
authored
Dec 11, 2020
by
Kelvin Fichter
Committed by
GitHub
Dec 11, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Temporarily disable gas checks (#135)
parent
007e4fa3
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
6 deletions
+8
-6
OVM_ECDSAContractAccount.sol
...mistic-ethereum/OVM/accounts/OVM_ECDSAContractAccount.sol
+6
-5
OVM_ECDSAContractAccount.spec.ts
...t/contracts/OVM/accounts/OVM_ECDSAContractAccount.spec.ts
+2
-1
No files found.
packages/contracts/contracts/optimistic-ethereum/OVM/accounts/OVM_ECDSAContractAccount.sol
View file @
dbf4f28c
...
...
@@ -78,11 +78,12 @@ contract OVM_ECDSAContractAccount is iOVM_ECDSAContractAccount {
"Transaction nonce does not match the expected nonce."
);
// Need to make sure that the gas is sufficient to execute the transaction.
Lib_SafeExecutionManagerWrapper.safeREQUIRE(
gasleft() >= Lib_SafeMathWrapper.add(decodedTx.gasLimit, EXECUTION_VALIDATION_GAS_OVERHEAD),
"Gas is not sufficient to execute the transaction."
);
// TEMPORARY: Disable gas checks for minnet.
// // Need to make sure that the gas is sufficient to execute the transaction.
// Lib_SafeExecutionManagerWrapper.safeREQUIRE(
// gasleft() >= Lib_SafeMathWrapper.add(decodedTx.gasLimit, EXECUTION_VALIDATION_GAS_OVERHEAD),
// "Gas is not sufficient to execute the transaction."
// );
// Transfer fee to relayer.
address relayer = Lib_SafeExecutionManagerWrapper.safeCALLER();
...
...
packages/contracts/test/contracts/OVM/accounts/OVM_ECDSAContractAccount.spec.ts
View file @
dbf4f28c
...
...
@@ -241,7 +241,8 @@ describe('OVM_ECDSAContractAccount', () => {
)
})
it
(
`should revert on insufficient gas`
,
async
()
=>
{
// TEMPORARY: Skip gas checks for minnet.
it
.
skip
(
`should revert on insufficient gas`
,
async
()
=>
{
const
alteredInsufficientGasTx
=
{
...
DEFAULT_EIP155_TX
,
gasLimit
:
200000000
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment