Skip to content

N
nebula
Commit dc8a87b4 authored by OptimismBot's avatar OptimismBot Committed by GitHub
Browse files
Options

Merge pull request #7120 from ethereum-optimism/jm/getter-test-style 

feat(style): Document style for testing solidity getters
parents 7ec04381 39743813
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 0 deletions
packages/contracts-bedrock/STYLE_GUIDE.md
View file @ dc8a87b4
...@@ -138,6 +138,9 @@ Test contracts should be named one of the following according to their use: ...@@ -138,6 +138,9 @@ Test contracts should be named one of the following according to their use:
- `TargetContract_Function_Test` for contracts containing happy path tests for a given function. - `TargetContract_Function_Test` for contracts containing happy path tests for a given function.
- `TargetContract_Function_TestFail` for contracts containing sad path tests for a given function. - `TargetContract_Function_TestFail` for contracts containing sad path tests for a given function.
To minimize clutter, getter functions can be grouped together into a single test contract,
ie. `TargetContract_Getters_Test`.
## Withdrawaing From Fee Vaults ## Withdrawaing From Fee Vaults
See the file `scripts/FeeVaultWithdrawal.s.sol` to withdraw from the L2 fee vaults. It includes See the file `scripts/FeeVaultWithdrawal.s.sol` to withdraw from the L2 fee vaults. It includes
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment