Merge pull request #4941 from ethereum-optimism/fix/revert-bug

Revert "fix(ctb): initialize L2OO in dictator step 1"

packages/contracts-bedrock/contracts/deployment/SystemDictator.sol

@@ -212,19 +212,6 @@ contract SystemDictator is OwnableUpgradeable {
                 )
             )
         );
-
-        // Upgrade and initialize the L2OutputOracle so the Proposer can start up.
-        config.globalConfig.proxyAdmin.upgradeAndCall(
-            payable(config.proxyAddressConfig.l2OutputOracleProxy),
-            address(config.implementationAddressConfig.l2OutputOracleImpl),
-            abi.encodeCall(
-                L2OutputOracle.initialize,
-                (
-                    l2OutputOracleDynamicConfig.l2OutputOracleStartingBlockNumber,
-                    l2OutputOracleDynamicConfig.l2OutputOracleStartingTimestamp
-                )
-            )
-        );
     }
 
     /**
@@ -310,6 +297,19 @@ contract SystemDictator is OwnableUpgradeable {
         // Dynamic config must be set before we can initialize the L2OutputOracle.
         require(dynamicConfigSet, "SystemDictator: dynamic oracle config is not yet initialized");
 
+        // Upgrade and initialize the L2OutputOracle.
+        config.globalConfig.proxyAdmin.upgradeAndCall(
+            payable(config.proxyAddressConfig.l2OutputOracleProxy),
+            address(config.implementationAddressConfig.l2OutputOracleImpl),
+            abi.encodeCall(
+                L2OutputOracle.initialize,
+                (
+                    l2OutputOracleDynamicConfig.l2OutputOracleStartingBlockNumber,
+                    l2OutputOracleDynamicConfig.l2OutputOracleStartingTimestamp
+                )
+            )
+        );
+
         // Upgrade and initialize the OptimismPortal.
         config.globalConfig.proxyAdmin.upgradeAndCall(
             payable(config.proxyAddressConfig.optimismPortalProxy),

packages/contracts-bedrock/deploy/020-SystemDictatorSteps-1.ts

@@ -29,7 +29,6 @@ const deployFn: DeployFunction = async (hre) => {
     L1ERC721BridgeProxy,
     L1ERC721BridgeProxyWithSigner,
     SystemConfigProxy,
-    L2OutputOracleProxy,
   ] = await getContractsFromArtifacts(hre, [
     {
       name: 'SystemDictatorProxy',
@@ -68,11 +67,6 @@ const deployFn: DeployFunction = async (hre) => {
       iface: 'SystemConfig',
       signerOrProvider: deployer,
     },
-    {
-      name: 'L2OutputOracleProxy',
-      iface: 'L2OutputOracle',
-      signerOrProvider: deployer,
-    },
   ])
 
   // If we have the key for the controller then we don't need to wait for external txns.
@@ -293,13 +287,6 @@ const deployFn: DeployFunction = async (hre) => {
         'gasLimit',
         hre.deployConfig.l2GenesisBlockGasLimit
       )
-
-      // Check L2OutputOracle was initialized properly.
-      await assertContractVariable(
-        L2OutputOracleProxy,
-        'latestBlockNumber',
-        hre.deployConfig.l2OutputOracleStartingBlockNumber
-      )
     },
   })
 

packages/contracts-bedrock/deploy/021-SystemDictatorSteps-2.ts

@@ -26,6 +26,7 @@ const deployFn: DeployFunction = async (hre) => {
     L1CrossDomainMessenger,
     L1StandardBridgeProxy,
     L1StandardBridge,
+    L2OutputOracle,
     OptimismPortal,
     OptimismMintableERC20Factory,
     L1ERC721Bridge,
@@ -56,6 +57,11 @@ const deployFn: DeployFunction = async (hre) => {
       iface: 'L1StandardBridge',
       signerOrProvider: deployer,
     },
+    {
+      name: 'L2OutputOracleProxy',
+      iface: 'L2OutputOracle',
+      signerOrProvider: deployer,
+    },
     {
       name: 'OptimismPortalProxy',
       iface: 'OptimismPortal',
@@ -207,6 +213,13 @@ const deployFn: DeployFunction = async (hre) => {
       submit L2 outputs to the L2OutputOracle.
     `,
     checks: async () => {
+      // Check L2OutputOracle was initialized properly.
+      await assertContractVariable(
+        L2OutputOracle,
+        'latestBlockNumber',
+        hre.deployConfig.l2OutputOracleStartingBlockNumber
+      )
+
       // Check OptimismPortal was initialized properly.
       await assertContractVariable(
         OptimismPortal,