Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
ddc37daa
Unverified
Commit
ddc37daa
authored
Jul 17, 2024
by
Axel Kingsley
Committed by
GitHub
Jul 17, 2024
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Don't enforce Challenge/Resolve Window Config for Generic Commitments (#11171)
parent
c55ade09
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
9 additions
and
6 deletions
+9
-6
config.go
op-chain-ops/genesis/config.go
+9
-6
No files found.
op-chain-ops/genesis/config.go
View file @
ddc37daa
...
...
@@ -437,15 +437,18 @@ func (d *DeployConfig) Check() error {
log
.
Warn
(
"DisputeGameFinalityDelaySeconds is 0"
)
}
if
d
.
UsePlasma
{
if
d
.
DAChallengeWindow
==
0
{
return
fmt
.
Errorf
(
"%w: DAChallengeWindow cannot be 0 when using alt-da mode"
,
ErrInvalidDeployConfig
)
}
if
d
.
DAResolveWindow
==
0
{
return
fmt
.
Errorf
(
"%w: DAResolveWindow cannot be 0 when using alt-da mode"
,
ErrInvalidDeployConfig
)
}
if
!
(
d
.
DACommitmentType
==
plasma
.
KeccakCommitmentString
||
d
.
DACommitmentType
==
plasma
.
GenericCommitmentString
)
{
return
fmt
.
Errorf
(
"%w: DACommitmentType must be either KeccakCommitment or GenericCommitment"
,
ErrInvalidDeployConfig
)
}
// only enforce challenge and resolve window if using alt-da mode with Keccak Commitments
if
d
.
DACommitmentType
!=
plasma
.
GenericCommitmentString
{
if
d
.
DAChallengeWindow
==
0
{
return
fmt
.
Errorf
(
"%w: DAChallengeWindow cannot be 0 when using alt-da mode with Keccak Commitments"
,
ErrInvalidDeployConfig
)
}
if
d
.
DAResolveWindow
==
0
{
return
fmt
.
Errorf
(
"%w: DAResolveWindow cannot be 0 when using alt-da mode with Keccak Commitments"
,
ErrInvalidDeployConfig
)
}
}
}
if
d
.
UseCustomGasToken
{
if
d
.
CustomGasTokenAddress
==
(
common
.
Address
{})
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment