Merge pull request #5126 from ethereum-optimism/inphi/fix-svc

fix(cmn): BaseServiceV2 throws on camelCase options

.changeset/long-frogs-study.md

+---
+'@eth-optimism/common-ts': patch
+---
+
+Fix BaseServiceV2 configuration for caseCase options

packages/common-ts/src/base-service/base-service-v2.ts

@@ -211,8 +211,15 @@ export abstract class BaseServiceV2<
     // Since BCFG turns everything into lower case, we're required to turn all of the input option
     // names into lower case for the validation step. We'll turn the names back into their original
     // names when we're done.
+    const lowerCaseOptions = Object.entries(params.options).reduce(
+      (acc, [key, val]) => {
+        acc[key.toLowerCase()] = val
+        return acc
+      },
+      {}
+    )
     const cleaned = cleanEnv<TOptions>(
-      { ...config.env, ...config.args, ...(params.options || {}) },
+      { ...config.env, ...config.args, ...(lowerCaseOptions || {}) },
       Object.entries(params.optionsSpec || {}).reduce((acc, [key, val]) => {
         acc[key.toLowerCase()] = val.validator({
           desc: val.desc,

packages/common-ts/test/service-spec.ts

+import { validators } from '../dist'
+import { BaseServiceV2 } from '../src'
+
+type ServiceOptions = {
+  camelCase: string
+}
+
+class Service extends BaseServiceV2<ServiceOptions, {}, {}> {
+  constructor(options?: Partial<ServiceOptions>) {
+    super({
+      name: 'test-service',
+      version: '0.0',
+      options,
+      optionsSpec: {
+        camelCase: { validator: validators.str, desc: 'test' },
+      },
+      metricsSpec: {},
+    })
+  }
+  protected async main() {
+    /* eslint-disable @typescript-eslint/no-empty-function */
+  }
+}
+
+describe('BaseServiceV2', () => {
+  it('base service ctor does not throw on camel case options', async () => {
+    new Service({ camelCase: 'test' })
+  })
+})