Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
e965769f
Commit
e965769f
authored
Aug 08, 2023
by
Mark Tyneway
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
contracts-bedrock: cleanup
parent
89ce9178
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
15 additions
and
14 deletions
+15
-14
SystemConfig.sol
packages/contracts-bedrock/src/L1/SystemConfig.sol
+4
-4
SystemConfig.t.sol
packages/contracts-bedrock/test/SystemConfig.t.sol
+3
-1
SystemConfig.t.sol
...ages/contracts-bedrock/test/invariants/SystemConfig.t.sol
+8
-9
No files found.
packages/contracts-bedrock/src/L1/SystemConfig.sol
View file @
e965769f
...
...
@@ -100,12 +100,12 @@ contract SystemConfig is OwnableUpgradeable, Semver {
_overhead: 0,
_scalar: 0,
_batcherHash: bytes32(0),
_gasLimit:
0
,
_gasLimit:
1
,
_unsafeBlockSigner: address(0),
_config: ResourceMetering.ResourceConfig({
maxResourceLimit:
0
,
elasticityMultiplier:
0
,
baseFeeMaxChangeDenominator:
0
,
maxResourceLimit:
1
,
elasticityMultiplier:
1
,
baseFeeMaxChangeDenominator:
2
,
minimumBaseFee: 0,
systemTxMaxGas: 0,
maximumBaseFee: 0
...
...
packages/contracts-bedrock/test/SystemConfig.t.sol
View file @
e965769f
...
...
@@ -111,8 +111,10 @@ contract SystemConfig_Initialize_TestFail is SystemConfig_Init {
});
vm.store(address(sysConf), bytes32(0), bytes32(0));
vm.expectRevert("SystemConfig: gas limit too low");
vm.prank(multisig);
// The call to initialize reverts due to: "SystemConfig: gas limit too low"
// but the proxy revert message bubbles up.
vm.expectRevert("Proxy: delegatecall to new implementation contract failed");
Proxy(payable(address(sysConf))).upgradeToAndCall(
address(systemConfigImpl),
abi.encodeCall(
...
...
packages/contracts-bedrock/test/invariants/SystemConfig.t.sol
View file @
e965769f
...
...
@@ -14,14 +14,7 @@ contract SystemConfig_GasLimitLowerBound_Invariant is Test {
Proxy proxy = new Proxy(msg.sender);
SystemConfig configImpl = new SystemConfig();
SystemConfig.Addresses memory addrs = SystemConfig.Addresses({
l1CrossDomainMessenger: address(0),
l1ERC721Bridge: address(0),
l1StandardBridge: address(0),
l2OutputOracle: address(0),
optimismPortal: address(0)
});
vm.prank(msg.sender);
proxy.upgradeToAndCall(
address(configImpl),
abi.encodeCall(
...
...
@@ -36,7 +29,13 @@ contract SystemConfig_GasLimitLowerBound_Invariant is Test {
Constants.DEFAULT_RESOURCE_CONFIG(), // resource config
0, //_startBlock
address(0), // _batchInbox
addrs // addresses
SystemConfig.Addresses({ // _addrs
l1CrossDomainMessenger: address(0),
l1ERC721Bridge: address(0),
l1StandardBridge: address(0),
l2OutputOracle: address(0),
optimismPortal: address(0)
})
)
)
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment