Commit fa19f9aa authored by Juan C's avatar Juan C Committed by GitHub

Update `expectRevert` reason in `OptimismPortalKontrol` & bump Kontrol version (#10159)

* versions.json: bump Kontrol from `0.1.196` to `0.1.247`

* OptimismPortal.k.sol: update `expectRevert` reasons
parent f0d68b09
...@@ -8,6 +8,7 @@ import { ...@@ -8,6 +8,7 @@ import {
IOptimismPortal as OptimismPortal, IOptimismPortal as OptimismPortal,
ISuperchainConfig as SuperchainConfig ISuperchainConfig as SuperchainConfig
} from "./interfaces/KontrolInterfaces.sol"; } from "./interfaces/KontrolInterfaces.sol";
import "src/libraries/PortalErrors.sol";
contract OptimismPortalKontrol is DeploymentSummary, KontrolUtils { contract OptimismPortalKontrol is DeploymentSummary, KontrolUtils {
OptimismPortal optimismPortal; OptimismPortal optimismPortal;
...@@ -27,7 +28,10 @@ contract OptimismPortalKontrol is DeploymentSummary, KontrolUtils { ...@@ -27,7 +28,10 @@ contract OptimismPortalKontrol is DeploymentSummary, KontrolUtils {
vm.prank(optimismPortal.guardian()); vm.prank(optimismPortal.guardian());
superchainConfig.pause("identifier"); superchainConfig.pause("identifier");
vm.expectRevert("OptimismPortal: paused"); // We need to encode the error selector as bytes instead of bytes4 because the bytes4 signature
// it's not currently supported
// Tracking issue: https://github.com/runtimeverification/kontrol/issues/466
vm.expectRevert(abi.encodeWithSelector(CallPaused.selector));
optimismPortal.finalizeWithdrawalTransaction(_tx); optimismPortal.finalizeWithdrawalTransaction(_tx);
} }
...@@ -48,7 +52,10 @@ contract OptimismPortalKontrol is DeploymentSummary, KontrolUtils { ...@@ -48,7 +52,10 @@ contract OptimismPortalKontrol is DeploymentSummary, KontrolUtils {
vm.prank(optimismPortal.guardian()); vm.prank(optimismPortal.guardian());
superchainConfig.pause("identifier"); superchainConfig.pause("identifier");
vm.expectRevert("OptimismPortal: paused"); // We need to encode the error selector as bytes instead of bytes4 because the bytes4 signature
// it's not currently supported
// Tracking issue: https://github.com/runtimeverification/kontrol/issues/466
vm.expectRevert(abi.encodeWithSelector(CallPaused.selector));
optimismPortal.proveWithdrawalTransaction(_tx, _l2OutputIndex, _outputRootProof, _withdrawalProof); optimismPortal.proveWithdrawalTransaction(_tx, _l2OutputIndex, _outputRootProof, _withdrawalProof);
} }
......
...@@ -4,5 +4,5 @@ ...@@ -4,5 +4,5 @@
"geth": "v1.13.14", "geth": "v1.13.14",
"nvm": "v20.9.0", "nvm": "v20.9.0",
"slither": "0.10.0", "slither": "0.10.0",
"kontrol": "0.1.196" "kontrol": "0.1.247"
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment