Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
faa6c5ed
Unverified
Commit
faa6c5ed
authored
Jul 05, 2022
by
Maurelian
Committed by
GitHub
Jul 05, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
test(ctb): unskip testCannot_AppendWithUnmatchedBlockhash (#2899)
parent
3b0afde6
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
9 deletions
+9
-9
.gas-snapshot
packages/contracts-bedrock/.gas-snapshot
+7
-6
L2OutputOracle.t.sol
...ges/contracts-bedrock/contracts/test/L2OutputOracle.t.sol
+2
-3
No files found.
packages/contracts-bedrock/.gas-snapshot
View file @
faa6c5ed
...
...
@@ -57,14 +57,15 @@ L2CrossDomainMessenger_Test:test_L2MessengerSendMessage() (gas: 119682)
L2CrossDomainMessenger_Test:test_L2MessengerTwiceSendMessage() (gas: 133142)
L2CrossDomainMessenger_Test:test_L2MessengerXDomainSenderReverts() (gas: 10599)
L2CrossDomainMessenger_Test:test_L2MessengerxDomainMessageSenderResets() (gas: 54881)
L2OutputOracleTest:testCannot_AppendWithUnmatchedBlockhash() (gas: 26799)
L2OutputOracleTest:testCannot_appendEmptyOutput() (gas: 24119)
L2OutputOracleTest:testCannot_appendFutureTimetamp() (gas: 260
86
)
L2OutputOracleTest:testCannot_appendOnWrongFork() (gas: 263
71
)
L2OutputOracleTest:testCannot_appendFutureTimetamp() (gas: 260
43
)
L2OutputOracleTest:testCannot_appendOnWrongFork() (gas: 263
48
)
L2OutputOracleTest:testCannot_appendOutputIfNotSequencer() (gas: 23510)
L2OutputOracleTest:testCannot_appendUnexpectedBlockNumber() (gas: 259
95
)
L2OutputOracleTest:testCannot_deleteL2Output_ifNotOwner() (gas: 247
77
)
L2OutputOracleTest:testCannot_appendUnexpectedBlockNumber() (gas: 259
51
)
L2OutputOracleTest:testCannot_deleteL2Output_ifNotOwner() (gas: 247
99
)
L2OutputOracleTest:testCannot_deleteL2Output_withWrongRoot() (gas: 91091)
L2OutputOracleTest:testCannot_deleteL2Output_withWrongTime() (gas: 870
84
)
L2OutputOracleTest:testCannot_deleteL2Output_withWrongTime() (gas: 870
40
)
L2OutputOracleTest:test_appendWithBlockhashAndHeight() (gas: 75017)
L2OutputOracleTest:test_appendingAnotherOutput() (gas: 76817)
L2OutputOracleTest:test_changeSequencer() (gas: 55776)
...
...
@@ -74,7 +75,7 @@ L2OutputOracleTest:test_deleteL2Output() (gas: 76516)
L2OutputOracleTest:test_getL2Output() (gas: 82924)
L2OutputOracleTest:test_latestBlockNumber() (gas: 76220)
L2OutputOracleTest:test_nextBlockNumber() (gas: 15144)
L2OutputOracleTest:test_updateOwner() (gas: 34
580
)
L2OutputOracleTest:test_updateOwner() (gas: 34
602
)
L2OutputOracleUpgradeable_Test:test_cannotInitImpl() (gas: 8476)
L2OutputOracleUpgradeable_Test:test_cannotInitProxy() (gas: 13453)
L2OutputOracleUpgradeable_Test:test_initValuesOnProxy() (gas: 38906)
...
...
packages/contracts-bedrock/contracts/test/L2OutputOracle.t.sol
View file @
faa6c5ed
...
...
@@ -233,9 +233,7 @@ contract L2OutputOracleTest is L2OutputOracle_Initializer {
// Test: appendL2Output fails when given valid input, but the block hash and number do not
// match.
// This tests is disabled (w/ skip_ prefix) because all blocks in Foundry currently have a
// blockhash of zero.
function skip_testCannot_AppendWithUnmatchedBlockhash() external {
function testCannot_AppendWithUnmatchedBlockhash() external {
// Move ahead to block 100 so that we can reference historical blocks
vm.roll(100);
...
...
@@ -248,6 +246,7 @@ contract L2OutputOracleTest is L2OutputOracle_Initializer {
vm.prank(sequencer);
// This will fail when foundry no longer returns zerod block hashes
vm.expectRevert("OutputOracle: Blockhash does not match the hash at the expected height.");
oracle.appendL2Output(nonZeroHash, nextBlockNumber, l1BlockHash, l1BlockNumber - 1);
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment