Commit fbc6aded authored by Maurelian's avatar Maurelian

docs(ctb): Some commenting fixes

parent 7ce3e4dc
...@@ -75,10 +75,9 @@ contract LivenessModule is ISemver { ...@@ -75,10 +75,9 @@ contract LivenessModule is ISemver {
// Calculate the new threshold // Calculate the new threshold
address[] memory owners = SAFE.getOwners(); address[] memory owners = SAFE.getOwners();
uint256 numOwnersAfter = owners.length - 1; uint256 numOwnersAfter = owners.length - 1;
uint256 thresholdAfter;
if (_isAboveMinOwners(numOwnersAfter)) { if (_isAboveMinOwners(numOwnersAfter)) {
// Call the Safe to remove the owner and update the threshold // Call the Safe to remove the owner and update the threshold
thresholdAfter = get75PercentThreshold(numOwnersAfter); uint256 thresholdAfter = get75PercentThreshold(numOwnersAfter);
address prevOwner = _getPrevOwner(owner, owners); address prevOwner = _getPrevOwner(owner, owners);
_removeOwner({ _prevOwner: prevOwner, _owner: owner, _threshold: thresholdAfter }); _removeOwner({ _prevOwner: prevOwner, _owner: owner, _threshold: thresholdAfter });
} else { } else {
......
...@@ -53,10 +53,10 @@ library SafeSigners { ...@@ -53,10 +53,10 @@ library SafeSigners {
{ {
_owners = new address[](requiredSignatures); _owners = new address[](requiredSignatures);
/// The following code is extracted from the Safe.checkNSignatures() method. It removes the signature // The following code is extracted from the Safe.checkNSignatures() method. It removes the signature
/// validation code, and keeps only the parsing code necessary to extract the owner addresses from the // validation code, and keeps only the parsing code necessary to extract the owner addresses from the
/// signatures. We do not double check if the owner derived from a signature is valid. As this is handled // signatures. We do not double check if the owner derived from a signature is valid. As this is handled
/// in the final require statement of Safe.checkNSignatures(). // in the final require statement of Safe.checkNSignatures().
address currentOwner; address currentOwner;
uint8 v; uint8 v;
bytes32 r; bytes32 r;
......
...@@ -8,7 +8,8 @@ import "safe-contracts/interfaces/IERC165.sol"; ...@@ -8,7 +8,8 @@ import "safe-contracts/interfaces/IERC165.sol";
import "safe-contracts/interfaces/ISignatureValidator.sol"; import "safe-contracts/interfaces/ISignatureValidator.sol";
import { Safe as GnosisSafe } from "safe-contracts/Safe.sol"; import { Safe as GnosisSafe } from "safe-contracts/Safe.sol";
/// @dev NOTE: removed VERSION and NAME due to inheritance conflicts /// @author: Colin Nielsen
/// https://github.com/colinnielsen/safe-tools/blob/ce6c654a76d91b619ab7778c77d1a76b3ced6666/src/CompatibilityFallbackHandler_1_3_0.sol
contract DefaultCallbackHandler is ERC1155TokenReceiver, ERC777TokensRecipient, ERC721TokenReceiver, IERC165 { contract DefaultCallbackHandler is ERC1155TokenReceiver, ERC777TokensRecipient, ERC721TokenReceiver, IERC165 {
function onERC1155Received( function onERC1155Received(
address, address,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment