Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
fbc6aded
Unverified
Commit
fbc6aded
authored
Oct 24, 2023
by
Maurelian
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
docs(ctb): Some commenting fixes
parent
7ce3e4dc
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
7 additions
and
7 deletions
+7
-7
LivenessModule.sol
packages/contracts-bedrock/src/Safe/LivenessModule.sol
+1
-2
SafeSigners.sol
packages/contracts-bedrock/src/Safe/SafeSigners.sol
+4
-4
CompatibilityFallbackHandler_1_3_0.sol
...ck/test/safe-tools/CompatibilityFallbackHandler_1_3_0.sol
+2
-1
No files found.
packages/contracts-bedrock/src/Safe/LivenessModule.sol
View file @
fbc6aded
...
...
@@ -75,10 +75,9 @@ contract LivenessModule is ISemver {
// Calculate the new threshold
address[] memory owners = SAFE.getOwners();
uint256 numOwnersAfter = owners.length - 1;
uint256 thresholdAfter;
if (_isAboveMinOwners(numOwnersAfter)) {
// Call the Safe to remove the owner and update the threshold
thresholdAfter = get75PercentThreshold(numOwnersAfter);
uint256
thresholdAfter = get75PercentThreshold(numOwnersAfter);
address prevOwner = _getPrevOwner(owner, owners);
_removeOwner({ _prevOwner: prevOwner, _owner: owner, _threshold: thresholdAfter });
} else {
...
...
packages/contracts-bedrock/src/Safe/SafeSigners.sol
View file @
fbc6aded
...
...
@@ -53,10 +53,10 @@ library SafeSigners {
{
_owners = new address[](requiredSignatures);
//
/
The following code is extracted from the Safe.checkNSignatures() method. It removes the signature
//
/
validation code, and keeps only the parsing code necessary to extract the owner addresses from the
//
/
signatures. We do not double check if the owner derived from a signature is valid. As this is handled
//
/
in the final require statement of Safe.checkNSignatures().
// The following code is extracted from the Safe.checkNSignatures() method. It removes the signature
// validation code, and keeps only the parsing code necessary to extract the owner addresses from the
// signatures. We do not double check if the owner derived from a signature is valid. As this is handled
// in the final require statement of Safe.checkNSignatures().
address currentOwner;
uint8 v;
bytes32 r;
...
...
packages/contracts-bedrock/test/safe-tools/CompatibilityFallbackHandler_1_3_0.sol
View file @
fbc6aded
...
...
@@ -8,7 +8,8 @@ import "safe-contracts/interfaces/IERC165.sol";
import "safe-contracts/interfaces/ISignatureValidator.sol";
import { Safe as GnosisSafe } from "safe-contracts/Safe.sol";
/// @dev NOTE: removed VERSION and NAME due to inheritance conflicts
/// @author: Colin Nielsen
/// https://github.com/colinnielsen/safe-tools/blob/ce6c654a76d91b619ab7778c77d1a76b3ced6666/src/CompatibilityFallbackHandler_1_3_0.sol
contract DefaultCallbackHandler is ERC1155TokenReceiver, ERC777TokensRecipient, ERC721TokenReceiver, IERC165 {
function onERC1155Received(
address,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment