Commit fe321618 authored by Conner Fromknecht's avatar Conner Fromknecht

feat: unify bss metric names

This commit:
 - Ensures each bss metric is prefixed by "batch_submitter_".
 - Ensures that Sequencer/Proposer name is made lowercase.
 - Ensures all units are present and positioned as a suffix.
parent f52fc61e
---
'@eth-optimism/batch-submitter-service': patch
---
Unify metric name format
package metrics package metrics
import ( import (
"strings"
"github.com/prometheus/client_golang/prometheus" "github.com/prometheus/client_golang/prometheus"
"github.com/prometheus/client_golang/prometheus/promauto" "github.com/prometheus/client_golang/prometheus/promauto"
) )
...@@ -44,9 +46,10 @@ type Metrics struct { ...@@ -44,9 +46,10 @@ type Metrics struct {
} }
func NewMetrics(subsystem string) *Metrics { func NewMetrics(subsystem string) *Metrics {
subsystem = "batch_submitter_ " + strings.ToLower(subsystem)
return &Metrics{ return &Metrics{
ETHBalance: promauto.NewGauge(prometheus.GaugeOpts{ ETHBalance: promauto.NewGauge(prometheus.GaugeOpts{
Name: "batch_submitter_eth_balance", Name: "balance_eth",
Help: "ETH balance of the batch submitter", Help: "ETH balance of the batch submitter",
Subsystem: subsystem, Subsystem: subsystem,
}), }),
...@@ -76,12 +79,12 @@ func NewMetrics(subsystem string) *Metrics { ...@@ -76,12 +79,12 @@ func NewMetrics(subsystem string) *Metrics {
Subsystem: subsystem, Subsystem: subsystem,
}), }),
SubmissionTimestamp: promauto.NewGauge(prometheus.GaugeOpts{ SubmissionTimestamp: promauto.NewGauge(prometheus.GaugeOpts{
Name: "submission_timestamp", Name: "submission_timestamp_ms",
Help: "Timestamp of last batch submitter submission", Help: "Timestamp of last batch submitter submission",
Subsystem: subsystem, Subsystem: subsystem,
}), }),
SubmissionGasUsed: promauto.NewGauge(prometheus.GaugeOpts{ SubmissionGasUsed: promauto.NewGauge(prometheus.GaugeOpts{
Name: "submission_gas_used", Name: "submission_gas_used_wei",
Help: "Gas used to submit each batch", Help: "Gas used to submit each batch",
Subsystem: subsystem, Subsystem: subsystem,
}), }),
...@@ -101,12 +104,12 @@ func NewMetrics(subsystem string) *Metrics { ...@@ -101,12 +104,12 @@ func NewMetrics(subsystem string) *Metrics {
Subsystem: subsystem, Subsystem: subsystem,
}), }),
BatchConfirmationTime: promauto.NewGauge(prometheus.GaugeOpts{ BatchConfirmationTime: promauto.NewGauge(prometheus.GaugeOpts{
Name: "batch_submitter_batch_confirmation_time_ms", Name: "batch_confirmation_time_ms",
Help: "Time to confirm batch transactions", Help: "Time to confirm batch transactions",
Subsystem: subsystem, Subsystem: subsystem,
}), }),
BatchPruneCount: promauto.NewGauge(prometheus.GaugeOpts{ BatchPruneCount: promauto.NewGauge(prometheus.GaugeOpts{
Name: "batch_submitter_batch_prune_count", Name: "batch_prune_count",
Help: "Number of times a batch is pruned", Help: "Number of times a batch is pruned",
Subsystem: subsystem, Subsystem: subsystem,
}), }),
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment