Commit fed6f354 authored by smartcontracts's avatar smartcontracts Committed by GitHub

fix(ci): temporarily make semgrep scan ok on err (#12227)

Temporarily makes semgrep-scan not fail on error. Currently this
is a problem for external contributions because semgrep-scan loads
rules from the online app which requires a login. External
contributors don't get access to this login.
parent c2dc0abf
...@@ -1167,7 +1167,7 @@ jobs: ...@@ -1167,7 +1167,7 @@ jobs:
# --timeout (in seconds) limits the time per rule and file. # --timeout (in seconds) limits the time per rule and file.
# SEMGREP_TIMEOUT is the same, but docs have conflicting defaults (5s in CLI flag, 1800 in some places) # SEMGREP_TIMEOUT is the same, but docs have conflicting defaults (5s in CLI flag, 1800 in some places)
# https://semgrep.dev/docs/troubleshooting/semgrep-app#if-the-job-is-aborted-due-to-taking-too-long # https://semgrep.dev/docs/troubleshooting/semgrep-app#if-the-job-is-aborted-due-to-taking-too-long
command: semgrep ci --timeout=100 --no-suppress-errors command: semgrep ci --timeout=100
# If semgrep hangs, stop the scan after 20m, to prevent a useless 5h job # If semgrep hangs, stop the scan after 20m, to prevent a useless 5h job
no_output_timeout: 20m no_output_timeout: 20m
- notify-failures-on-develop - notify-failures-on-develop
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment