* Another stab at a good hardhat-deploy

* Testing etherscan verifications

* Fix linting

* remove artifacts

* keep old deploy script

* remove old hardhat-typechain dependency

* remove unused import

* remove kovan config

* Tweak deployment a bit

* Clean up defaults

* rename hardhat => hh

* Use mock bond manager

* Make deploy a bit more robust

* I committed my private key again. There goes my goerli eth

* and my infura api key too

* Fix lint errors

* Use strict ordering

* refactor: use helper for easy AddressManager deployments (#350)

* Clean up georgios pr

* use dotenv to manage deployer keys

* Update src/hardhat-deploy-ethers.ts
Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>

* Stricter checking on address set

* add argument for sequencer address

* minor tweaks to console.log comments

* move predeploy addresses into their own file

* add small comment for clarity

* update deploy script

* fix incorrect env var in deploy script

* adding deploy.js shim to get ci to work

* simplify deployment environment vars

* temporary tweaks to get a ci run to pass

* print out deploy artifacts

* fix artifact log output format

* fix contract names in artifact log output

* add eth gateway to deploy

* add OVM_Proposer to address manager

* add some comments for clarity

* remove bytecode hash from compiler settings

* minor tweaks in response to review

* transfer address manager ownership after deploy

* explicitly attach deployer to address manager
Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>

* tests: Improve coverage for StateTransitionerFactory

* fix failing test because of missing contract
Co-authored-by: Maurelian <maurelian@protonmail.ch>

* bump MAX_ROLLUP_TX_SIZE

* fix test gasLimit

* lint

* prevent call spoofing on L2
* adds a test based on logs and successfulMessages mapping

* Deauthorize EM on SM

* dev: Minor cleanup to package.json and remove unused deps

* Have workflow run lint:check

* add OVM_L1ETHGateway Proxy

* fix contract build

* pass tests with new initialize test, lint

* make delegate proxy payable

* remove now-inaccurate comment
Co-authored-by: Ben Jones <ben@pseudonym.party>
Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>

* have eoa pass hardcoded max gas limit

* tweak for tests to pass

* use gasleft instead of hardcoded gas limit

* Add coverage config

* Add flags to skip gas tests when running coverage

* Check-in coverage output

* Revert "Check-in coverage output"


Too noisy to have coverage output stored here. I will look for an alternative solution.

This reverts commit fb631f2471903e9b8ab76c66e18f308d92930cae.

* Add test coverage artifacts to gitignore

* Add test coverage instructions to README

* Lint

* fix: Make ovmSETNONCE monotonic

* Use ovmINCREMENTNONCE instead

* Fix build errors

* fix remaining build errors

* last commit was a lie

* chore: use trimmed down smock/plugins

* fix: add storage layout for smock

* chore: lint

* fix: explicitly compile the OVM artifacts

* Use latest plugins and tweak package.json
Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com>

Co-authored-by: Maurelian <maurelian@protonmail.ch>

Co-authored-by: smartcontracts <kelvinfichter@gmail.com>
Co-authored-by: Maurelian <maurelian@protonmail.ch>

* Rename OVM precompiles to predeploys

* Appease linter
Co-authored-by: smartcontracts <kelvinfichter@gmail.com>
Co-authored-by: ben-chain <ben@pseudonym.party>

Co-authored-by: smartcontracts <kelvinfichter@gmail.com>

Co-authored-by: smartcontracts <kelvinfichter@gmail.com>

Co-authored-by: Janek Rahrt <janek.rahrt@joyn.de>

* build: remove duplicate npm dependency

* Fix naming error
Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com>

* new create codepath working

* get calls ported over to new function

* remove from interface

* clean up, add comments

* remove unused commented code

* fix nuisance gas

* add return type to ovmCREATE

* focus on final failing test

* finish up tests with new contract account revert type

* remove test focus

* linting

* cleanup

* add explicit unsafe bytecode test

* linting

* remove pointless ternary

* fix docstring

* fix eth_call for creates and fix contract account reversions

* use if statement instead

* nits

* Update contracts/optimistic-ethereum/OVM/execution/OVM_ExecutionManager.sol
Co-authored-by: smartcontracts <kelvinfichter@gmail.com>

* Update contracts/optimistic-ethereum/OVM/execution/OVM_ExecutionManager.sol
Co-authored-by: smartcontracts <kelvinfichter@gmail.com>

* Update contracts/optimistic-ethereum/OVM/execution/OVM_ExecutionManager.sol
Co-authored-by: smartcontracts <kelvinfichter@gmail.com>

* Update contracts/optimistic-ethereum/OVM/execution/OVM_ExecutionManager.sol
Co-authored-by: smartcontracts <kelvinfichter@gmail.com>

* Update contracts/optimistic-ethereum/OVM/execution/OVM_ExecutionManager.sol
Co-authored-by: smartcontracts <kelvinfichter@gmail.com>

* Fix nits on comments

* More small comment fixes

* fix capitalization, add ref URL

* PR feedback

* opcodes->bytecode

* doc: explain eth_call create return type

* Update contracts/optimistic-ethereum/OVM/execution/OVM_ExecutionManager.sol
Co-authored-by: smartcontracts <kelvinfichter@gmail.com>
Co-authored-by: Maurelian <maurelian@protonmail.ch>

Co-authored-by: rajivpo <rajivpatel-oconnor@Rajivs-MacBook-Pro-2.local>

* remove immutable

* add fallback function to deposit eth into l2

* Revert "remove immutable"

This reverts commit 6e8bf7b1871b56085ce96ee73b5acbd4bd04b96c.

* remove conflicting receive function
Co-authored-by: George Hotz <geohot@gmail.com>
Co-authored-by: smartcontracts <kelvinfichter@gmail.com>

* fix Warning: Unused function parameter. Remove or comment out the variable name to silence this warning.

* fix: shadows another variable error

* fix: Warning: Visibility for constructor is ignored.

* fix: unused local variable warning

* fix: Warning: Function state mutability can be restricted to pure

* Warning: Return value of low-level calls not used.

* fix: Warning: Unnamed return variable can remain unassigned.

* fix: final Warning: Visibility for constructor is ignored. If you want the contract to be non-deployable, making it abstract is sufficient

* implement comments

* fix: change return to address(0) to silence compiler

* perf: reset xDomainMessageSender to default value after external call

Fixes https://github.com/ethereum-optimism/contracts/issues/309

We also set `xDomainMessageSender in the `initialize` function in L1, and in the L2 constructor.

* test: ensure that xDomainMessageSender is always 0xdead before/after calls

* chore: use parent constructor for initializing the L2 xdomain sender

* fix: require that the xDomainSender is not the default value