1. 20 Feb, 2022 2 commits
  2. 18 Feb, 2022 3 commits
  3. 17 Feb, 2022 4 commits
  4. 16 Feb, 2022 6 commits
  5. 15 Feb, 2022 1 commit
    • kf's avatar
      fix: update PR labeler to include SDK · 027916aa
      kf authored
      Updates the PR labeler to correctly label the SDK. I noticed that the
      SDK was not being correctly labeled and realized that I had to add it to
      this file.
      027916aa
  6. 12 Feb, 2022 3 commits
  7. 11 Feb, 2022 13 commits
  8. 10 Feb, 2022 8 commits
    • Conner Fromknecht's avatar
      feat: stop publishing txs after receiving confirmation · 0b2ead8f
      Conner Fromknecht authored
      This change adds an additional IsWaitingForConfirmation method to the
      txmgr.SendState, which returns true if it is aware of at least one mined
      tx. This allows the txmgr to skip publishing new txs while we are
      waiting for additional confirmation on a mined tx, which in turn reduces
      the number of useless API calls we make to the backend provider. As an
      additional benefit, this also reduces the likelihood of a false positive
      sample from ShouldAbortImmediately since it will stop processing errors
      while we have a mined tx.
      0b2ead8f
    • Conner Fromknecht's avatar
      1bdd8e63
    • Conner Fromknecht's avatar
      fix: add SendState to determine when to abort Send · bcbde5f3
      Conner Fromknecht authored
      This commit adds a new SendState struct, which is used internally by the
      txmgr to determine if we should give up on a particular tx at the given
      nonce due to ErrNonceTooLow failures. To do so, we track the set of
      mined txns at any particular time, which are updated via asynchronous
      calls to TxMined and TxNotMined by each of the spawned goroutines. The
      presence of a mined txn supercedes any of the errors returned, and will
      cause the txmgr to wait for full confirmation. However, if we observe
      multiple ErrNonceTooLows, the SendState will wait for a configurable
      safe abort count to ensure that the reading wasn't due to being in a
      transient state, as we don't have exact guarantees on the execution
      ordering of various goroutines.
      
      With this change, the test added in the prior commit now succeeds.
      bcbde5f3
    • Conner Fromknecht's avatar
      feat: add failing Test for txmgr edge case · a27a68e6
      Conner Fromknecht authored
      This commit adds a test case for the following scenario:
       1. The first few publications succeed with err == nil.
       2. One of the txs is mined.
       3. Subsequent publications start failing because they are using the
          same nonce as the tx mined in (2).
      
      This edge case is currently overlooked in the txmgr, and will cause the
      shouldAbortImmediately method to return true and not wait for the
      appropriate confirmations.
      a27a68e6
    • Conner Fromknecht's avatar
      feat: split up SubmitBatchTx driver method · c741087a
      Conner Fromknecht authored
      Rather than having a combined update the gas price and publish the tx,
      we split this this into two methods: UpdateGasPrice and SendTransaction.
      This will allow the txmgr to obtain the txHash before publishing the
      tx.
      c741087a
    • Matthew Slipper's avatar
      4da19032
    • github-actions[bot]'s avatar
      Version Packages · c880d3db
      github-actions[bot] authored
      c880d3db
    • Matthew Slipper's avatar
      Merge pull request #2193 from ethereum-optimism/develop · 617efd58
      Matthew Slipper authored
      Develop -> Master
      617efd58