Skip to content

N
nebula
Switch branch/tag
  1. 19 Jan, 2024 12 commits
    • Luke's avatar
      fix(config): add preimageOracle MinProposalSize and ChallengePeriod for config.sh (#9074) · 51e29f36
      Luke authored 
      Co-authored-by: default avatarLuke <chenqun.l@kaitaitech.cn>
      51e29f36
    • protolambda's avatar
      specs,op-node: handle when Ecotone is active on L2 before L1 (#9073) · 6a3d1e74
      protolambda authored
      6a3d1e74
    • protolambda's avatar
      op-e2e: EIP-4844 DA test & beacon client query string fix (#9076) · 9603ab0c
      protolambda authored 
      * op-e2e: revive original 4844 DA test
Co-authored-by: default avatarRoberto Bayardo <bayardo@alum.mit.edu>

* op-service: fix beacon API HTTP client encoding of query string, avoid malformatting due to path joining

* op-batcher: data-availability-type enum and generic flag

* op-e2e: eip4844 test improvements

* op-batcher,op-service: review fixes on 4844 api fix

* eth: Add tests of Beacon API response structs

* eth,sources,fakebeacon: Update Beacon API BlobSidecar format

* eth: Remove field BlobSidecar.BlockRoot

* eth: Fix BeaconBlockHeader json tag, test APIGetBlobSidecarsResponse

* eth: Simplify Beacon API types and tests

* op-service: fix bytes96 terminal stringer in op-service/eth/types.go

* op-service: fix comment lint

---------
Co-authored-by: default avatarRoberto Bayardo <bayardo@alum.mit.edu>
Co-authored-by: default avatarSebastian Stammler <seb@oplabs.co>
      9603ab0c
    • Mark Tyneway's avatar
      ci: delete dead step (#9088) · b83650df
      Mark Tyneway authored 
      Generating the allocs no longer relies on `geth` so we do not need to
install `geth` as part of bringing up the devnet. We also generate the
allocs once and then persist them to the CI workspace. This will save
~1-1.5 minutes per CI run by no longer installing `geth` as part of
the devnet.
      b83650df
    • Inphi's avatar
      cannon: Allow stopping at first preimage read (#9080) · 6c700909
      Inphi authored 
      * cannon: Allow stopping at first preimage read

* cannon: support stopping on preimage key and type
      6c700909
    • david-roth-cb's avatar
      Create function to return l1 + l2 missing hashes (#9048) · 4cd3ca84
      david-roth-cb authored
      4cd3ca84
    • Axel Kingsley's avatar
      Async Gossiper (#8905) · 50a6a55c
      Axel Kingsley authored
      50a6a55c
    • Mark Tyneway's avatar
      contracts-bedrock: flake fix attempt (#9082) · 78a5c4f8
      Mark Tyneway authored 
      * contracts-bedrock: flake fix attempt

Progress towards fixing flakes in CI. Using `etch` to set contracts in
state instead of deploying will help to fix the nonce mismatches between
the L1 contract addresses and the L2 genesis that contains L1 contract
addresses.

Developers will need to run `forge clean` to remove artifacts for the
tests to pass after this commit is merged. It enforces a single version
of `FFIInterface` to be compiled instead of it being compiled with
multiple compiler versions. The `vm.getCode` family of cheats fail when
there are multiple compiled versions of the same contract because the
artfact has the compiler version appended to the name of the artifact.

This will also help to improve compiler time since the compiled
contracts do not need to include the compiled bytecode of the deploy and
ffiinterface contracts, the code is loaded dynamically instead of being
deployed with `CREATE`.

* contracts-bedrock: more cleanup

Deletes a dead file that is no longer needed and sets the deploy config
in state using `etch`. `DeployL2` is not used, we should be using the
`superchain-ops` repo for deploying new L2 contracts or deploy them
through L1. Since `DeployL2` used code using solc `0.8.19` (EAS) it
caused multiple versions of the `DeployConfig` to be compiled which
causes headaches when using `vm.getCode`.

* contracts-bedrock: update gas snapshot

* contracts-bedrock: more cleanup

* contracts-bedrock: gas-snapshot

* lint: fix
      78a5c4f8
    • Adrian Sutton's avatar
      op-challenger: Load proposed large preimages (#9069) · f6480169
      Adrian Sutton authored 
      Introduces the infrastructure for monitoring large pre-image proposals, up to loading the list of in-progress games from the contract.
Actual content of the preimages is not yet loaded or checked.
      f6480169
    • protolambda's avatar
      op-node: fix parent-beacon-block-root comparison check [Ecotone] (#9071) · d1d92907
      protolambda authored 
      * op-node: fix parent-beacon-block-root comparison check

* op-node: nit in op-node/rollup/derive/engine_consolidate.go
Co-authored-by: default avatarSebastian Stammler <seb@oplabs.co>

* op-node: two-side nil parent beacon block root test case

---------
Co-authored-by: default avatarSebastian Stammler <seb@oplabs.co>
      d1d92907
    • Mark Tyneway's avatar
      contracts-bedrock: hacky patch for CI failures (#9081) · 3ba1ff7c
      Mark Tyneway authored 
      * contracts-bedrock: hacky patch for CI failures

CI is consistently failing due to the L2 genesis generation happening
out of process using ffi. Ideally the genesis state could be ran a
single time once outside of the process ahead of time but the problem
with this approach is that the deployer nonce is not correct and the
L1 contract addresses in practice end up not matching the addresses
that are injected into the L2 genesis state. There are a few solutions
to this problem, one is deploying the proxies with create2 and another
is to ensure that the deployer does not deploy additional contracts
in the test case setup that are not deployed in the L1 genesis gen
setup so that we are guaranteed that the contracts have the same
addresses.

This is a hacky patch to attempt to fix the issue where it will wait
if the allocs file doesn't exist. Something with the process running in
parallel causes the file to not exist. The downside of this fix is that
CI may hang silently forever if the file is lost for some reason.

Another solution would be to return the JSON to solidity and then write
it to a temp file. This isn't ideal but could work in the short term.
We are working on a rewrite of the L2 genesis generation in solidity
that will fix this issue along with many other devex issues in the
monorepo.

* ctb: update gas snapshot
      3ba1ff7c
    • dependabot[bot]'s avatar
      build(deps): bump github.com/onsi/gomega from 1.30.0 to 1.31.0 (#9072) · 51425468
      dependabot[bot] authored 
      Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.30.0 to 1.31.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](https://github.com/onsi/gomega/compare/v1.30.0...v1.31.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...
Signed-off-by: default avatardependabot[bot] <support@github.com>
Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      51425468
  3. 18 Jan, 2024 18 commits
  5. 17 Jan, 2024 10 commits