- 19 Aug, 2024 3 commits
-
-
siddharth0a authored
* add gzipCloser struct * add Close method * fix OpenDecompressed func * fix CompressByFileType func * knit * Apply suggestions from code review close both even if one fails Co-authored-by:
Adrian Sutton <adrian@symphonious.net> * fix WriteCloser Close method * fix name for more general * fix writercloser name for more geneeral * add construction function for WrappedCloser * using construction func * seperate wrapped closer struct to wrapped_closer.go --------- Co-authored-by:
Adrian Sutton <adrian@symphonious.net>
-
Samuel Laferriere authored
-
protolambda authored
* op-node: cleanup driver, closer to removing stepping * op-node: add comment about event Drain error * op-node: fix lint * op-node: handle drain errors
-
- 17 Aug, 2024 5 commits
-
-
protolambda authored
-
Matthew Slipper authored
Fault Proof Fixes
-
Sebastian Stammler authored
* Update op-geth dependency to 1.14.8 base * go.mod: update op-geth to v1.101408.0-rc.1 --------- Co-authored-by:
protolambda <proto@protolambda.com>
-
Matthew Slipper authored
Add Base cantina/spearbit audits
-
Matthew Slipper authored
-
- 16 Aug, 2024 28 commits
-
-
George Knee authored
* op-proposer: ensure uniform proposal interval across restarts closes https://github.com/ethereum-optimism/optimism/issues/11193 * move DGF query logic into FetchDGFOutput * merge loopL2OO and loopDGF * tweak comments * Apply suggestions from code review Co-authored-by:
Sebastian Stammler <seb@oplabs.co> * return err instead of defaulting to sending a proposak flatten out control flow, remove shouldPropose var * defer l.Log.Info("loop returning") * improve error handling and logging * fix logging syntax error * make DGFContract interface harmonize how network contexts are constructed * modify test for new DGF behavior * fix bugs in test code * remove OutputRetryInterval flag * handle gameCount = 0 * finish removing OutputRetryInterval * driver waits one proposal interval for the first ever proposal * do not create mock unecessarily * do not create mockL2OOContract unecessarily * wrap and return errors instead of logging and returning * op-proposer: Switch to modern binding style for dispute game factory (#11472) --------- Co-authored-by:
Sebastian Stammler <seb@oplabs.co> Co-authored-by:
Adrian Sutton <adrian@oplabs.co>
-
protolambda authored
* op-chain-ops: Go forge scripts runner * fix lint * op-chain-ops: encapsulate forge script tests in testdata
-
smartcontracts authored
FPACOPS2 deployed a new AnchorStateRegistry proxy when the actual script needed to just deploy a new implementation.
-
smartcontracts authored
-
Inphi authored
Allow the `DeputyGuardian` to set the Anchor State for brick prevention. --------- Co-authored-by:
clabby <ben@clab.by> Co-authored-by:
refcell <abigger87@gmail.com>
-
smartcontracts authored
Creates a deploy script to deploy the implementations for the FaultDisputeGame and PermissionedDisputeGame contracts being updated as part of Granite. Based on the original FPACOPS script with modifications to remove actions that are not necessary for an upgrade.
-
Adrian Sutton authored
-
mbaxter authored
* cannon: Basic memory protections Add memory protections against high memory allocations to the VM. This prevents large allocations from causing the `heap` to overflow and wrap into low memory, which could overwrite code and cause arbitrary code execution. --------- Co-authored-by:
inphi <mlaw2501@gmail.com>
-
smartcontracts authored
This reverts commit 59e02fb3ece7fc249223054944a0b1ff437aa64f.
-
smartcontracts authored
This reverts commit 864e59a821e87f9dd00ae97f85add93fa3857597.
-
clabby authored
-
Adrian Sutton authored
-
smartcontracts authored
When the FDG is about to execute a step, we must add an additional clock extension equal to the PreimageOracle challenge period. This gives the PreimageOracle time to elapse.
-
clabby authored
-
smartcontracts authored
* fix: no squeezing unfinalized proposals Updates the PreimageOracle to correctly revert if a proposal has not actually been finalized. This fixes a bug because the timestamp is not set until after a proposal is finalized but all other conditions in the squeeze function are met even before addLeaves is called with the finalize boolean set. * fix: ci checks * fix: semver lock --------- Co-authored-by:
refcell <abigger87@gmail.com>
-
clabby authored
* Prevent reiniting preimage uploads. (#190) * fix(ctb): Perform correct clock validation in FDG constructor Fixes the clock extension / max clock duration check in the `FaultDisputeGame` constructor to account for the worst-case clock extension. * fix: add semver-lock * fix: add kontrol * gas snapshot * fix: gas snapshot and semver-lock --------- Co-authored-by:
Adrian Sutton <adrian@oplabs.co> Co-authored-by:
refcell <abigger87@gmail.com>
-
refcell authored
* Prevent reiniting preimage uploads. (#190) * fix(ctb): PreimageOracle `loadLocalData` length check * fixes * fix: bump preimage oracle semver * chore: snapshots * fix: gas snapshot * revert: gas snapshot changes --------- Co-authored-by:
Adrian Sutton <adrian@oplabs.co> Co-authored-by:
clabby <ben@clab.by>
-
smartcontracts authored
A lot of instructions in the MIPS spec require that certain fields be set to zero. Most of the time this isn't actually a problem but this can cause side-effects in a few cases. A buggy compiler could create an issue if it ever spit out non-compliant instructions. This PR implements those zero value enforcement checks for all instructions that we implement.
-
Inphi authored
* contracts: Add gas input to precompile pre-images (#186) Also update the cannon evm tests to use the new precompile preimage scheme. --------- Co-authored-by:
Adrian Sutton <adrian@oplabs.co> * op-challenger: Support uploading data in new format. (#188) * op-program: Add required gas to precompile oracle key (#176) * op-challenger: Support multiple versions of the preimage oracle contract --------- Co-authored-by:
Adrian Sutton <adrian@oplabs.co> --------- Co-authored-by:
inphi <mlaw2501@gmail.com> --------- Co-authored-by:
Adrian Sutton <adrian@oplabs.co>
-
smartcontracts authored
Existing step logic wrote the register offset into memory but the compiler should already be doing this when the struct is defined. Instead of writing directly into memory, this change verifies that the memory at that location has the expected value which will catch any cases where the compiler's memory allocation mechanism changes in the future.
-
smartcontracts authored
Modifies the MIPS contracts to enforce that state.exited is either exactly zero or one and cannot have any other value.
-
smartcontracts authored
Updates DelayedWETH to use call instead of transfer because transfer only sends along 2300 gas which will cause the transfer to fail if the owner contract uses lots of gas in the fallback function. Adds tests that demonstrate that the function now works appropriately under any reasonable amount of gas usage. In theory this means the recovery function can be reentered but this isn't an issue because the function is authenticated and is recovering all of the ETH in the contract anyway.
-
smartcontracts authored
Existing implementation of SRAV had a bug where it would perform a shift with all bytes of the rs register when the spec says it should only be using the lower 5 bits of the register. Updates the implementation to reflect this, updates the existing test to use the same test vector as provided in the open mips tests, and adds fuzz tests that shows srav works as expected with rs values that have more than the lower 5 bits set.
-
smartcontracts authored
Updates MIPSInstructions so that it correctly reverts on calls to add, addi, and sub that overflow/underflow. Additionally includes tests that demonstrates that the unchecked versions of the same opcodes allow for overflow/underflow.
-
Kelvin Fichter authored
Modifies the FDG constructor to correctly check that the splitDepth +1 is gte the max game depth. Means that the splitDepth is now limited to be 1 smaller than it was before. Fine in prod but avoids a bug in the trace ancestor lookup logic.
-
Kelvin Fichter authored
FDGs with a split depth below 2 can trigger bugs in clock extension. Since we don't expect to have a split depth anywhere near 0 or 1 this is a low impact bug and doesn't have an impact on production but should be prevented anyway.
-
Adrian Sutton authored
-
oisa godspower authored
-
- 15 Aug, 2024 4 commits
-
-
Sebastian Stammler authored
* op-e2e: Add forge clean to README.md troubleshooting section * Update op-e2e/README.md Co-authored-by:
Matt Solomon <matt@mattsolomon.dev> --------- Co-authored-by:
Matt Solomon <matt@mattsolomon.dev>
-
Mark Tyneway authored
Make the getting started script modern by adding recent hardfork config and also make the script runnable from any directory.
-
Kim authored
-
Adrian Sutton authored
op-challenger: Extract RegistrationTask to dedeuplicate registration code between different game types. (#11413)
-