Skip to content

N
nebula
Switch branch/tag
  1. 08 Oct, 2024 1 commit
  3. 07 Oct, 2024 5 commits
    • Mark Tyneway's avatar
      contracts-bedrock: fixes `OptimismMintableERC721Factory` test (#12306) · 35bbd80e
      Mark Tyneway authored 
      * contracts-bedrock: fixes `OptimismMintableERC721Factory` test

This contract is only used as a predeploy so it should be tested based
on the L2 genesis generation setup. Ensures that the address is stored
and labeled as part of in memory test setup, as well as updates the
tests to work based on the predeploy.

This is a small refactor to make future Standard L2 genesis work more
simple.

Also includes a small ABI fix to the `OptimismMintableERC721Factory`
since this contract has not been updated to decouple immutable naming
conventions from its ABI.

* snapshots: update

* checks: fix

* lint: fix

* typo: fix
      35bbd80e
    • Mark Tyneway's avatar
      contracts-bedrock: cleanup `FeeVault` (#12338) · b460aa27
      Mark Tyneway authored 
      * contracts-bedrock: cleanup `FeeVault`

Updates the `FeeVault` to follow modern conventions used in the repo
by moving to usage of interfaces rather than implementations. Also
moves the `FeeVault` into the `L2` package as its only really useful
on L2. This is meant to reduce the diff for the Stanard L2 Genesis
by breaking up the refactor into its own small PR.

* contracts: update semver-lock

* semver-lock: fixup

* cleanup: refactor

* lint: fix

* snapshots: regenerate

* interface check: ignore fee vaults

There is an issue with normalization of enums when they are return
values
      b460aa27
    • smartcontracts's avatar
      feat: add sol-style-malformed-require locally (#12340) · 981ee6ac
      smartcontracts authored 
      Adds sol-style-malformed-require to local semgrep and actually
fixes the rule so that it works. Fixes a couple of findings that
the rule found.
      981ee6ac
    • George Knee's avatar
      increase metric properly when blocks are requeued (#12326) · f33a0a9e
      George Knee authored
      f33a0a9e
    • Michael de Hoog's avatar
      Remove AddSingularBatch from ChannelOut interface (prefer AddBlock) (#12079) · d062c1c5
      Michael de Hoog authored
      d062c1c5
  5. 06 Oct, 2024 4 commits
    • smartcontracts's avatar
      feat(ci): use foundry profiles to set fuzz parameters (#12346) · 8917511b
      smartcontracts authored 
      Updates contracts-bedrock-tests to use foundry profiles to set the
fuzz/invariant run parameters instead of inlining it. Has the
added benefit of separating out into two profiles so that tests
can be selectively tuned down for the heavy fuzz pipeline without
also tuning them down for the standard CI pipeline.
      8917511b
    • smartcontracts's avatar
      maint(ci): clean up semgrep rules and ignores (#12347) · 5a155eef
      smartcontracts authored 
      Cleans up the existing semgrep rules and gets rid of the blanket
ignores that were being applied everywhere now that we can add
ignores for specific files in the rule config.
      5a155eef
    • Mark Tyneway's avatar
      contracts: clean up deploy script abstractions (#12336) · e165a7ea
      Mark Tyneway authored 
      * contracts: clean up deploy script abstractions

Move the implementation deployments into `deployImplementations`
and the initializations into the initizer function so that things
are grouped more logically. Even though we use OPSM for modern
deployments, the legacy code is still in the repo. This change
makes it easier to implement Standard L2 Genesis, where we depend
on the `OptimismPortal` being initialized before the `SystemConfig`,
since the `SystemConfig` makes calls to the portal during its
`initialize` call.

* op-e2e: remove dependency on contracts existing

Modularizes the functionality more

* lint: fix
      e165a7ea
    • smartcontracts's avatar
      feat: add sol-expectrevert-no-args locally (#12342) · e9b5eebe
      smartcontracts authored 
      Adds the sol-expectrevert-no-args semgrep rule locally.
      e9b5eebe
  7. 05 Oct, 2024 9 commits
  9. 04 Oct, 2024 7 commits
  11. 03 Oct, 2024 14 commits