It was possible to return from a function directly
into destructuring an array when the return value
was polymorphic in either being an array or undefined.
The undefined case is handled explicitly now and an
error is thrown with a useful error message instead of
something that would require looking at the source code
and knowing nodejs error types to find out what the
problem was.

Includes artifacts and updated deploy scripts that were
used to generate the initial state

Create a replaceWETH helper function that can be reused in the
tests. WETH is an immutable in the uniswap contracts so a find
and replace is used to replace the weth address with the L2 eth
address on optimism.

Reverts 341580e8f4e7c83d0382fc7d40281b5ac973e568 in favor of more simple
logic. A longer term solution needs to be implemented for the race
condition where the `gas-oracle` front runs a tx that has already passed
gas validation at the policy layer.

The `gas-oracle` tx can increase the L1 gas portion of the fee,
causing the tx that already passed the policy check to fail during
consensus execution. This should never happen.

The new gas price scheme no longer fetches the L1 gas price from
a remote L1 node. It now instead will use the L1 gas price
that lives in the L2 state. The `gas-oracle` is responsible for
updating the L1 gas price in the `OVM_GasPriceOracle` predeploy.

* feat: add surgery script base

* test: add test setup for surgery handlers

* feat: add handlers for uniswap contracts

* asdf

* feat: clean up main surgery script

* surgery: add constants and solc download script

* feat: download pool data for surgery script

* feat: add handlers for remaining predeploys

* feat: ingest configs

* fix: bugs in the handling of weth and eth

* fix: add handling for uni pools

* feat: handle 1inch surgery steps

* feat: correctly load and generate the genesis file

* regenesis-surgery: implement recompilation

Add recompilation that links libraries and includes
immutables

* workflows: update ci to use node v14

* surgery: bugfixes and logging

* surgery: update

* surgery: more fixes

* fmfix: surgery script cleanup

* surgery: dockerize

* more cleanup

* surgery: fix tests

* surgery: update .env.example

* fix: ingest based on state dump output

* fix merge conflicts

* minor cleanup to getSolc function

* feat: standardize dump output

* fix: tests

* minor bug fixes

* final cleanup and optimizations

* clean up compilation step

* highly optimize surgery process

* fix: remove unused deps

* remove unit tests for now

* final cleanup and tweaks

* fix final bugs

* more minor bugfixes

* remove unnecessary giant json file

* fix: handle multiple libraries

* wip: start testing shell

* wip: continue filling out shell

* wip: minor tweaks to uniswap spec

* wip: refactor data loading so it can be used in tests

* surgery: initialize test infra

* core-utils: add helpful functions

* state-surgery: more test infra

* core-utils: env var parsing

* add Hop ETH addresses

* linting and test cleanup

* finalize eoa tests

* clean up test process for eoas

* add uniswap tests

* feat: surgery prevent double withdraw

* fix: pass thru no wipe before returning

* fix: undo temp code removal

* Update handlers.ts

* fix: uniswap immutables bug

* fix: make sure multicall is in the dump

* fix: revert multicall address logic

* state-surgery: basic tests for verified contracts

* fix: add data and solc bin dirs to eslint ignore

* lint: fix

* various minor fixes

* Update packages/regenesis-surgery/scripts/constants.ts
Co-authored-by: ben-chain <ben@pseudonym.party>

* disable tests for CI

* fix: remove message passer handling

* fix: remove unused dependencies
Co-authored-by: Annie Ke <annieke8@gmail.com>
Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
Co-authored-by: ben-chain <ben@pseudonym.party>

Use the configured gas price when updating the L1 base fee.
In production, this should be set to 0 and the sequencer
will allow for transactions with 0 gas price when they are
from the owner of the gas price oracle. This prevents the
need to manage funds on L2 for the `gas-oracle`

Use a minimal version of EIP 2929 for state accessing
opcodes. This does not pull in the access list logic
but instead charges based on cold access assumptions
at all times

This commit adds solhint-plugin-prettier which allows us to use both solhint and prettier
on our solidity files, by ensure that solhint will throw an error when code is not formatted
according to prettier rules. It also makes some slight modifications to yarn scripts which
allows better separation between linting ts and solidity during CI runs

This reverts commit 1bb656c6e8ca6777bd245b49c1677b0db1503d4f.

Should fix broken CI

Co-authored-by: Maurelian <maurelian@protonmail.ch>

Co-authored-by: Maurelian <maurelian@protonmail.ch>

which is no longer build:integration but just build

from readme to contributing as that's where running the tests section sits