- 27 May, 2022 5 commits
-
-
dependabot[bot] authored
Bumps [github.com/ethereum/go-ethereum](https://github.com/ethereum/go-ethereum) from 1.10.16 to 1.10.17. - [Release notes](https://github.com/ethereum/go-ethereum/releases) - [Commits](https://github.com/ethereum/go-ethereum/compare/v1.10.16...v1.10.17) --- updated-dependencies: - dependency-name: github.com/ethereum/go-ethereum dependency-type: direct:production ... Signed-off-by:
dependabot[bot] <support@github.com> Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
dependabot[bot] authored
Bumps [github.com/ethereum/go-ethereum](https://github.com/ethereum/go-ethereum) from 1.10.16 to 1.10.17. - [Release notes](https://github.com/ethereum/go-ethereum/releases) - [Commits](https://github.com/ethereum/go-ethereum/compare/v1.10.16...v1.10.17) --- updated-dependencies: - dependency-name: github.com/ethereum/go-ethereum dependency-type: direct:production ... Signed-off-by:
-
Joshua Gutow authored
Repeatedly using time.After in a select loop leaks resources as resources are allocated for each timer, but not released until the timer fires. The timer may not fire due to other return paths. By using tickers, this resource leak is no longer able to happen. I verified that this problem no longer exists with the following semgrep command. semgrep --config="r/dgryski.semgrep-go.timeafter.leaky-time-after" Co-authored-by: -
smartcontracts authored
Updates legacy MetricsServer to bind to 0.0.0.0 instead of 127.0.0.1 by default which makes it possible to expose the metrics server from inside docker. Only the DTL is still using legacy metrics, so should be fine. Co-authored-by: -
Joshua Gutow authored
fmt.Sprintf is discouraged from being used to create network addresses.
-
- 26 May, 2022 2 commits
-
-
smartcontracts authored
fix: update ethers deps
-
Kelvin Fichter authored
Updates all ethers dependencies in response to the BN.js bug reported for versions below 5.8.6. Also removes various extra dependencies to reduce the total number of deps and simplify the process of updating in the future.
-
- 24 May, 2022 4 commits
-
-
Joshua Gutow authored
This command runs `go mod tidy` in every bedrock go module. This enables easier updating of self-dependent modules. Co-authored-by: -
Joshua Gutow authored
go.work.sum holds references to transitive dependencies. The size of the file can be reduced even more with `go work sync`, however that command modifies every subproject's go.mod and go.sum Co-authored-by: -
Joshua Gutow authored
The gitignore was non-existant or ignoring the old binary. This updates them to hide the `bin` directory (where builds are placed). Co-authored-by: -
Joshua Gutow authored
This specifically notifies users if abigen, forge, and gofmt are not found in the path. This is to provide an early warning that the commands are required instead of failing when attempting to invoke the commands.
-
- 23 May, 2022 3 commits
-
-
Mark Tyneway authored
bedrock-contracts: fix hardhat build
-
mergify[bot] authored
-
Daniele Salatti authored
* Fix: make build for Apple Silicon I had the same issue as #2429, adding `eudev-dev` and `build-base` fixes it. * Remove redundant eudev-dep from Dockerfile.packages Co-authored-by:
-
- 21 May, 2022 1 commit
-
-
Mark Tyneway authored
Adds in a compiler version for WETH9, since it requires an older compiler version
-
- 20 May, 2022 3 commits
-
-
Diederik Loerakker authored
Co-authored-by: -
Diederik Loerakker authored
* fix(exec-engine): typo * specs: fix TOC Co-authored-by:
Ori Pomerantz <qbzzt1@gmail.com> Co-authored-by:
-
Liam Horne authored
-
- 19 May, 2022 5 commits
-
-
Diederik Loerakker authored
Co-authored-by: -
Diederik Loerakker authored
Co-authored-by: -
Diederik Loerakker authored
* fix(op-node/flags): fix p2p advertise udp flag * fix(op-node/rollup): fix config validation Co-authored-by: -
Mark Tyneway authored
* contracts: update forge-std This adds 2 new cheatcodes to the `vm` interface, a `expectCall` that asserts on the call with a `msg.value` set to a specific amount as well as a `mockCall` that can send a specific amount of value as part of the mocked call. * contracts: deploy OVM_ETH as part of setup * contracts: deployer whitelist * contracts: OVM_ETH * contracts: sequencer fee vault * contracts: weth9 * contracts: ignore linting for weth9 * contracts: gas oracle * contracts: l1 standard bridge * contracts: new snapshot Co-authored-by: -
Joshua Gutow authored
* Add tools to regenerate bindings * Generate new bindings Renames the package type and updates some names. * op-*: Rename bedrock contracts and update import path
-
- 18 May, 2022 4 commits
-
-
Mark Tyneway authored
-
Murphy Law authored
* integration-tests: Override the default bridge adapters * Fix non-actor integration tests in CI Co-authored-by: -
Joshua Gutow authored
This adds a normal (non-fuzzing) test of setL1BlockValues with the goal of determining how much gas is used by the function.
-
Matthew Slipper authored
Co-authored-by:
-
- 17 May, 2022 5 commits
-
-
Diederik Loerakker authored
* opnode/p2p,specs/p2p: discover+connect background process * opnode/flags: simplify p2p useragent flag * opnode/p2p: peer discovery background process * p2p: review cleanup - define consts for numbers, fix imports Co-authored-by: -
Diederik Loerakker authored
-
Mark Tyneway authored
Keep the `L2CrossDomainMessenger` API backwards compatible. The `l1CrossDomainMessenger` getter was accidentally removed in the refactor. This commit adds that getter back to the API. Note that it is a legacy getter and only exists to ensure that existing applications can still work with the new contracts. Co-authored-by: -
smartcontracts authored
* feat: add new contracts-periphery package Introduces a new contracts-periphery package and initializes the package with the RetroReceiver contract (meant to receive RetroPGF funds on all available chains). Reason for introducing a new package is that the original contracts package should be reserved for in-protocol contracts while contracts-periphery can be used for any contracts that we want to write and test, regardless of if they're part of the protocol. * feat(ctp): add periphery contracts to ci Adds contracts-periphery package to CI in the various places it's required so we can successfully package and release it.
-
Matthew Slipper authored
* opnode: Reconcile epochs and handle reorgs (#309) * opnode: Switch to uint64 in FindL2Heads function * opnode: Properly initialize state loop This properly sets the L1 head, L2 Head, and L2 Unsafe Head during `state.Start()` in normal operation and when the current L1 head has not reached the L1 genesis. * opnode: Rename output functions The old names where not good. In addition, this standardizes the order of arguements and extends the returns. The returns are not fully used, but will be. * opnode: Add sanity check to L1 window in insertEpoch This make sure that the L1 window starts at the correct block. * opnode: Split out loop Now each action occurs in a seperate function. The state loop is still responsible for sequencing follow-up actions, but is not responsible for setting state. * opnode: Better name for batch prepare functions This name indicates that it provides missing batches. * opnode: Verify epochs as sequencer Sequencers now verify epochs and will reorg if they see that verified epochs do not match what they created. * opnode: Mute driver test * opnode: Set L2 Geth forkchoice on reorg This is required to handle L1 reorgs (rather than just missing batches). * opnode: Bump op-geth version Needed to fix a bug where the L2 geth node was missing the `mint` field in deposit transactions when returning them over the JSON RPC server. * opnode: Don't incorrectly advance safehead There is some L2 block that is possible to fully derive from L1; however, if it is ahead of the current state's safe head, do not advance the current state's safehead because the chain has not been verified up to that point. * opnode: Don't rebuild L1 Genesis Block ID Co-authored-by:
Diederik Loerakker <proto@protolambda.com> * opnode: More comments Co-authored-by:
Joshua Gutow <jgutow@optimism.io> * opnode/l1: wrap errors and fmt test imports * opnode: don't expose types.Block to derive or driver packages, prefer l2.ExecutionPayload * opnode: add comments, fix genesis base case to get l1 origin * init: integration tests (#344) Co-authored-by:
Javed Khan <tuxcanfly@gmail.com> * opnode: Fix possible panic in sequencer batch creation (#342) Previously we assumed that every deposit would be included in the L2 block. However, the L2 execution engine removes depoists that are not valid. As such the number of deposits submitted to the execution engine could be greater than the number of transactions returned causing a panic. This fixes the issue by counting the number of deposits returned and using that to slice the payload transactions for batch submission. (Deposits are not submitted in batches and instead read directly from L1). This also does more sanity checks on the transactions included in the L2 block and rejects blocks with invalid deposit tx configurations. This is done prior to marking the payload canonical with the FCU. * opnode: Test Utilities (#319) * opnode: Deduplicate fake chain source The fake chain source is an easy way to create and L1 and L2 chains from a simple string defition. There were previously two implementations and now they are in a shared testutils package. * opnode: Dedicated wait functions This deduplicates wait for transactions on L1 and L2. * opnode: New e2e test system This splits out the initialization from the actual tests to eanble multiple e2e tests. Some of the config is still not as dedpulicated as I would like, but it is more centralized than it previously was. Aims to move the setup from the tests and enable easier e2e tests. * opnode: Silence FindSyncStartTest * opnode: Add test for missing batches This ensures the the sequencer follows the chain that is derived from L1 rather than what it sequenced in the case that it misses batch submission. * opnode: Pull out system config to default cfg This reduces duplication and makes tests easier to understand. * opnode: Address PR comments * opnode: Reduce flakiness in missing batch test The proper way to do this is to wait for a safe block, but the API is not yet ready for that. * Fix sync-start bug + improve sync-start comments (#355) Fix bug (L1 origin head with non-canonical ancestors) This happened in the scenario where `l2ahead == true` (L1 origin of start is ahead of know L1 head) and `start` had an ancestor whose L1 origin was known not to be canonical. Example: L1 head is at block X. `start` has an L1 origin with number X + 1 but its parent L2 block has an L1 origin with number X whose blockhash is not canonical. In this case, the algorithm still returned `start` as the unsafe L1 head, which is incorrect. This also touches a bunch of comments to generally improve understanbility. * feat: deposit tx js helpers (#352) * feat: js deposit tx Hardhat task now lists the tx hash * rollup: new deposit hashing * nice api! * fix: dockerfile * devnet: Hardcode deposit feed bytecode (#359) * opnode,l2os: Better lifecycle management (#358) * opnode: Properly wait for limit client to shut down We removed closing the semaphore channel because it would cause a panic as we did not wait for in flight requests (and new requests) to stop before closing the L1 source. * l2os: Change shutdown procedure This is now blocking, but also reuces the amount of error logs. * opnode: Shutdown rollup nodes before clients/geth nodes Also actually shuts down the L2 clients in the rollup node. * opnode: Properly shut everything down * style: clean up and comments for state.go (#356) * opnode: Parameterize deposit contract address (#361) The contract can be deployed to any address. It is set in the rollup config file. * opnode/test: Add reverted deposit with mint test * fix(ci): use Foundry GHA (#367) Nightly Foundry releases are kept around for 3 days. This means we cannot be pinning the download link on CI to a specific commit. Instead, we use the Foundry Toolchain GHA which always uses the latest nightly version. * opnode/test: check nonce increment in deposit fail * integration-tests: End-to-end withdrawal test (#362) Includes several fixes to make this work: - Modifies the devnet to deploy the L1 contracts rather than include them in genesis. - Changes the deployment of L2OutputOracle to support a custom start timestamp. - Updates UserDeposits to properly filter out non-TransactionDeposited events. - Updates the L2 output submitter to post the current L1 block with each output rather than the L2 checkpoint block - Updates the opnode API to allow all vhosts and CORS domains. * go.mod: bump l2geth version * opnode: Update and deploy contracts (#360) This is rather than hardcoding the contract bytecode. It slows down the e2e tests (by having to wait 1 L1 block for contracts to be ready), but it is more accurate to what occurs (and is now required as we initialize actions). This also pins the L2OutputOracle to v0.8.10 of solidity. * specs: Update output root derivation (#357) * specs: Update output root derivation * specs: Separate version from payload * opnode: libp2p setup * p2p flags, config, and libp2p + discv5 setup * specs: initial rollup node p2p spec * specs: Fix definition of output root * solidity: fail if updated gas snapshot isn't included A new gas snapshot can be generated by running `forge snapshot` * p2p setup: implement review suggestions, fix toc, fix lint * opnode/p2p: test with require instead of assert * contracts: Fix reentrancy attack in WithdrawalsRelay (#378) * contracts: Output oracle improvements (#370) * contracts: Use correct uppercase for immutables * itest: shorten submission interval for faster devnet tests * contracts: Ensure submission interval is multiple of block time * itest: Simplify withdrawals spec * itest: Increase withdrawal finalization timeout * itest: Bump withdrawal timeout to +5 minutes * Bump timeout * Bump again * Add gas snap Co-authored-by:
Matthew Slipper <me@matthewslipper.com> * Clean up withdrawals itest (#372) * contracts: Use correct uppercase for immutables * itest: shorten submission interval for faster devnet tests * contracts: Ensure submission interval is multiple of block time * itest: Simplify withdrawals spec * itest: Increase withdrawal finalization timeout * itest: Bump withdrawal timeout to +5 minutes * itest: Extract logic into getTargetOutput * Update 000_withdrawals.spec.ts Co-authored-by:
Maurelian <maurelian@protonmail.ch> * contracts: fix abi encoding in proof verification (#395) Use `abi.encode` instead of `abi.encodePacked` to ensure a constant serialization. `abi.encode` will be sure to pad the value to its size while `abi.encodePacked` will not when operating on integers. There should not have been a bug here because it was being called with a `bytes32`, which should always be 32 bytes when returned from `abi.encodePacked`. * contracts: don't unalias on L2->L1 Co-authored-by:
smartcontracts <kelvin@optimism.io> * opnode: attach p2p host and discovery to rollup node, update e2e test (#388) * deps: update forge-std * contracts: fix build * build: fix bindings build * fix: builds * forge install: ds-test * build: fix for good * l2os: update bindings * opnode: add seq nr to l1-info to fix driver bug * feat: create opnode/predeploy package This resolves an import cycle when trying to use WithdrawalContractAddress in opnode/node. Otherwise the compiler complains that opnode imports opnode/node which imports opnode. * opnode: refactor RPC server / config, prototype batch serving * feat: enforce size contraints on batch bundles This algorithm is modeled mostly off the one used in the existing batch submitter. The additional complexity enables us to configure a min and max value such that max - min < max_l2_tx_size. Applied strictly, submitting a large L2 tx would cause the batch construct to halt, since the batch constructed without including batch `i` can be under the min, while including batch `i` resulting in exceeding the maximum. The additional complexity in the pruning algorithm is used to identify this case and submit an undersized batch when it cannot be avoided. In the general case, however, this strategy increases our expected profitibability since the average batch size is closer to the desired maximum. * feat: add BundleBuilder helper class * fix: typo in l2os config docs * feat: add GetBatchBundle method to rollupclient.RollupClient * feat: simplify l2os rollupclient init * feat: reduce BSS poll interval The current setup assumes the batches are submitted very soon after the block is created on L2. Increasing the poll interval ensures that we discover and publish new batches in response. Without modifying this value, the subsequent changes will still fail even though the code is correct. * feat: add sequencer history db * feat: add sequencer BSS driver to submit batches * feat: add bss configuration * feat: add LOG_TERMINAL flag to l2os, use non-global log instance Also modifies the shutdown logic of l2os.Service to abort if stuck publishing a transaction. * feat: enable standalone bss, disable simple bss * feat: remove simple bss * feat: add bss to devnet * fix: ci build bindings (#406) * ci: build bindings in ci * ci: install abigen * ci: fix geth install * bindings: regenerate * contracts: no metadata hash in contracts * bindings: regenerate * opnode: Avoid busy-waiting while L2 head is behind L1 In the state select loop, we immediately request for new L2 blocks whenever the latest L1 origin is behind L1. This can be an issue as we attempt to re-request the latest L2 block without any delay. This is a DoS hazard particularly when an L2 block cannot be retrieved because either the `L1Chain` or `L2Chain` backends have errors. Another problem with this is that other, more useful events in the state select loop, are less likely to be scheduled by the Go runtime due to the busy-wait. Adding a small delay, before calling `reql2BlockCreation` of about 10ms should be enough to prevent issues. * opnode: Fix Incorrect error handling when creating an L2 block (#391) * opnode: Fix Incorrect error handling when creating an L2 block This is an issue ToB identified (issue #8). What happens is that the ethereum.NotFound error would never be returned, but in general if there is an error in the lookup, the state loop should keep going. * opnode: Properly wrap errors in l1/source.go * opnode: Fuzz manual ABI parsing (#384) * opnode: Add OptimismPortal deployed bytecode This is important for fuzzing * opnode: Add differential fuzzing test for deposit events fixup: Proper tests * build: Add fuzz target * opnode: Fix ineffctual error assignment * opnode: More fuzzing cleanup The purpose of this is to make it more likely that the deposit succeeds and that we fuzz what we actually want to fuzz (the parsing). * fix: DepositFeed.sol link * opnode: gossip blocks topic validator and subscriber * opnode/l2: ExecutionPayload SSZ encoding/decoding * opnode/l2: check payload block hash consistency * opnode/p2p,specs: update p2p block gossip validation * opnode: refactor node initialization, change l1-head fan out, implement l2 payload driver receiver, setup block signing, update config / cli / e2e * opnode/l2,opnode/rollup/driver: process incoming unsafe L2 blocks * specs/rollup-node-p2p: fix toc * opnode/p2p: compress published messages * specs/rollup-node-p2p: clarify hardfork version start * opnode/node: fix l1 head notify timeout bug * opnode: fix receive p2p payload timeout bug, fix publishing buffer missing reset * opnode: fix/improve new loggers * opnode: fix p2p block distribution * opnode/test: connect peers only after starting p2p application-layer protocols * ops,opnode/p2p: fix opnode start up in devnet * opnode/l2: use common.Big0 instead of big.NewInt(0), thx mark * opnode: Add debug tracer to geth in e2e test (#418) * Update reference geth entrypoint with variable parameters * opnode: fix imports and code newlines style * opnode,specs: gossip blocks validation seen cache fixes * opnode/rollup/driver: no heuristics in driver, rely more on engine to handle reorgs * opnode: tracer to watch node events during testing * opnode,specs: clarify gossip params * opnode/l2/ssz: fix lousy copy range * opnode/rollup/driver/state: fix doc typo Co-authored-by:
Mark Tyneway <mark.tyneway@gmail.com> * opnode: p2p RPC, fix static-peers * StateViz: Visualize rollup state changes (#419) * StateViz: Visualize rollup state changes * remove DEBUGMEs * Add L1WindowBuf to viz * move stateviz to opnode/cmd * Add stateviz to docker-compose * html lint * Add SRI * Fix linter * Merge fixes * Fixes from code review * Imports * Fix space Co-authored-by:
Murphy Law <Inphi@users.noreply.github.com> Co-authored-by:
norswap <norswap@gmail.com> Co-authored-by:
Murphy Law <mlaw2501@gmail.com> Co-authored-by:
Georgios Konstantopoulos <me@gakonst.com> Co-authored-by:
Conner Fromknecht <conner@alum.mit.edu> Co-authored-by:
Luca Donno <30298476+lucadonnoh@users.noreply.github.com> Co-authored-by:
Ben Wilson <bwilson@optimism.io> Co-authored-by:
Ben Wilson <82120899+optimisticben@users.noreply.github.com>
-
- 16 May, 2022 1 commit
-
-
dependabot[bot] authored
Bumps [cross-fetch](https://github.com/lquixada/cross-fetch) from 2.2.5 to 2.2.6. - [Release notes](https://github.com/lquixada/cross-fetch/releases) - [Commits](https://github.com/lquixada/cross-fetch/compare/v2.2.5...v2.2.6) --- updated-dependencies: - dependency-name: cross-fetch dependency-type: indirect ... Signed-off-by:
-
- 13 May, 2022 1 commit
-
-
smartcontracts authored
Simplifies test helpers slightly by cutting out unnecessary code.
-
- 12 May, 2022 4 commits
-
-
Matthew Slipper authored
Version Packages
-
github-actions[bot] authored
-
Matthew Slipper authored
Develop -> Master
-
Conner Fromknecht authored
This allows the batch submitter to attempt to encode larger ranges of transactions before they are compressed and tested against the max tx size. Empirically this should give us ~3x throughput.
-
- 11 May, 2022 1 commit
-
-
smartcontracts authored
Fixes a bug in the SDK that would throw an error when the user did not provide a nonce along with the transaction (when estimating gas). If no nonce is provided, will try to find a reasonable nonce or use a default (large) nonce that will give a good upper bound for the L1 gas cost.
-
- 10 May, 2022 1 commit
-
-
Matthew Slipper authored
Develop -> Master
-
![dependabot[bot]'s avatar](https://secure.gravatar.com/avatar/48ea49be76d0c68403a7f3df87e3487d?s=80&d=identicon "dependabot[bot]")
![mergify[bot]'s avatar](https://secure.gravatar.com/avatar/e3df20cd7a67969c41a65f03bea54961?s=80&d=identicon "mergify[bot]")
![github-actions[bot]'s avatar](https://secure.gravatar.com/avatar/cb7b7994e594270ea25948a7bf186123?s=80&d=identicon "github-actions[bot]")
