- 26 Sep, 2022 7 commits
-
-
smartcontracts authored
Adds consistency checks for L1 syncing nodes in the DTL. One of my personal nodes seemed to halt with this error, so fixing it. Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Maurelian authored
-
smartcontracts authored
Adds versioning rules to the Bedrock contracts package. Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Mark Tyneway authored
The tests run as part of `bedrock-go-tests` so no need to have a task specific for `op-chain-ops`. Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
sam-goldman authored
Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
smartcontracts authored
Introduces a new task for validating the correctness of spacer variables. Prevents future developers from accidentally moving spacers. Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Mark Tyneway authored
* op-chain-ops: implement withdrawal hashing Implement both the new hashing scheme and the legacy hashing for withdrawals so that the withdrawals can be migrated. Also implement encoding and decoding of the withdrawals * more tests * op-chain-ops: code review fixes * op-chain-ops: fix message passer Now that the old message passer is being kept in the L2 state, be sure to the use legacy address. The new message passer is at a different address.
-
- 24 Sep, 2022 12 commits
-
-
Maurelian authored
-
Maurelian authored
* ci: Ignore l2geth coverage reports * ci: Upload coverage reports in js-lint-test Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Matthew Slipper authored
* op-node: Fix OPB-10 Fixes OPB-10: No Checks for Deposit Transaction Type When Calling `L1InfoDepositTxData()`. This PR adds a check in `blockToBatch` that checks the type of the first transaction in the block, and returns an error if it isn't a deposit transaction. * goimports Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Mark Tyneway authored
The ownable upgradable modifier was not used anywhere in the contract. The erc20 factory does not follow that pattern. This change simplifies things by moving values to immutables instead of being in storage. This is a cleanup PR before migrating these contracts to `contracts-bedrock`. Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Mark Tyneway authored
* contracts-bedrock: add semver to erc20 factory * op-bindings: regenerate Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Matthew Slipper authored
-
Matthew Slipper authored
-
Matthew Slipper authored
-
Matthew Slipper authored
-
Matthew Slipper authored
-
Matthew Slipper authored
* proxyd: Add batch size metric and configurable max The max batch size will be overwritten if it is over `MaxBatchRPCCallsHardLimit`. Builds on https://github.com/ethereum-optimism/optimism/pull/3544. * changeset * fix lint * fix test
-
Matthew Slipper authored
* proxyd: Add customizable whitelist error message Alchemy is asking for this so that we can include their affiliate link. * add missing test case * fix error message * goimports
-
- 23 Sep, 2022 7 commits
-
-
smartcontracts authored
* fix(ct): bug in L2OutputOracle constructor Fixes a small bug in the L2OutputOracle constructor where an assertion was being made about the wrong value. Unlikely that this would've caused any significant issues but worth fixing anyway. * Update l1genesis generation code Puts the genesis timestamp inside the simulator, and updates the simulator code to properly wait for blocks to be mined. See the comments in deployer.go and layer_one.go. * Update gas snapshot Co-authored-by:
Matthew Slipper <me@matthewslipper.com> Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Matthew Slipper authored
Version Packages
-
github-actions[bot] authored
-
Matthew Slipper authored
Trigger Releases
-
smartcontracts authored
Moves the L2ToL1MessagePasser to a new address and introduces the LegacyMessagePasser to live at the old address. Co-authored-by:
Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Michael de Hoog authored
Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by:
Matthew Slipper <me@matthewslipper.com>
-
Matthew Slipper authored
Update op-geth to the latest version on the `optimism-history` branch. This version exposes the customizable simulator backend that we need to merge https://github.com/ethereum-optimism/optimism/pull/3322. Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
- 22 Sep, 2022 6 commits
-
-
Matthew Slipper authored
* op-node: Fix OPB-04 The length of the ExtraData field was not being checked, which could lead to panics in the MarshalSSZ function. Fixes ENG-2614 * code review fixes * increase resource size Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Maurelian authored
Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Matthew Slipper authored
-
Mark Tyneway authored
* contracts-bedrock: fix `OptimismMintableERC20Created` The names of the event args were backwards from what they were supposed to be. I noticed this while writing integration tests for the sdk. The event is used like this: ```solidity emit OptimismMintableERC20Created(_remoteToken, address(localToken), msg.sender); ``` The event was updated to look like this: ```solidity event OptimismMintableERC20Created( address indexed remoteToken, address indexed localToken, address deployer ); ``` The `remoteToken` is first and the `localToken` is second. * ctb: Avoid extra casting from contract to address * chore: Regen bindings and snapshot * chore: Update bindings Co-authored-by:
Maurelian <maurelian@protonmail.ch> Co-authored-by:
Matthew Slipper <me@matthewslipper.com>
-
smartcontracts authored
Standardizes storage spacer names and makes sure that storage spacers are all using their original variable types. Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Maurelian authored
-
- 21 Sep, 2022 7 commits
-
-
smartcontracts authored
Improves and simplifies metrics by using better metric labels.
-
Maurelian authored
-
sam-goldman authored
* nft: L-13 Duplicated code * nft: M-08 Upgradeability inconsistencies * fix(ctp): change `CrossDomainEnabled` to `CrossDomainMessenger` * fix(ctp): make `otherBridge` and `messenger` in nft bridge contracts immutable * docs(ctp): update `ERC721Bridge` bridging function docs * re-order `OptimismMintableERC721Factory` event args * remove unnecessary `Initializable` import in nft bridges * changed legacy `CrossDomainEnabled` call to `CrossDomainMessenger Co-authored-by:
Mark Tyneway <mark.tyneway@gmail.com>
-
Maurelian authored
* ctb: Naming and comments to clarify interfaces usage The OptimismMintableERC20 token used two interfaces in its supportsInterface() function. These were confusingly named after the functions that they contain (ie. IL1Token, IRemoteToken), rather than the contracts these interfaces represent. The name has been tweaked slighly, and comments have been added to clarify the intent. fix(ctb): Clearer names for the mintable token iface * ctb: Add bridge() to mintable erc20 interface * chore: bindings
-
Mark Tyneway authored
* op-chain-ops: implement pending withdrawal fetching We need a list of pending withdrawals to be able to migrate the withdrawal hashes to the new withdrawal hash scheme. This commit implements the script for fetching pending withdrawals as well as a unit test for the function responsible for fetching pending withdrawals. From within `op-chain-ops`, the script can be ran as follows: ```golang $ go run cmd/withdrawals/main.go ``` lint * op-chain-ops: go mod tidy Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by:
Matthew Slipper <me@matthewslipper.com>
-
Matthew Slipper authored
-
Michael de Hoog authored
* Fix stateviz JSON deserialization * Spelling nit * Update the variable names too
-
- 20 Sep, 2022 1 commit
-
-
sam-goldman authored
* nft: M-01 Asymmetric failure behavior of ERC721 bridges * nft: N-05 Inconsistent approach to auto-refunding failed token transfers * nft: L-05 Auto withdrawal transactions can be misleading * nft: M-06 Lack of input validation * nft: L-08 ERC721 bridge contracts not using safeTransferFrom * refactor(ctp): fix `FakeOptimismMintableERC721` inherited contract * feat(ctp)!: update nft bridge post-audit * update `CrossDomainEnabled` import paths in nft bridges * bump `OptimismMintableERC721Factory` semver * Update packages/contracts-periphery/contracts/L2/L2ERC721Bridge.sol Co-authored-by:
Maurelian <maurelian@protonmail.ch> * added `localToken` check in the `completeOutBoundTransfer` function in NFT bridges * nit: fix error message in `L1ERC721Bridge` Co-authored-by:
Maurelian <maurelian@protonmail.ch> Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-