- 03 Oct, 2024 14 commits
-
-
Maurelian authored
This will clear the way to delete a lot of the deployX() functions in Deploy.s.sol
-
dependabot[bot] authored
Bumps [github.com/multiformats/go-multiaddr-dns](https://github.com/multiformats/go-multiaddr-dns) from 0.3.1 to 0.4.0. - [Release notes](https://github.com/multiformats/go-multiaddr-dns/releases) - [Commits](https://github.com/multiformats/go-multiaddr-dns/compare/v0.3.1...v0.4.0) --- updated-dependencies: - dependency-name: github.com/multiformats/go-multiaddr-dns dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by:
dependabot[bot] <support@github.com> Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
Maurelian authored
* feat: Add reasons to checkOptimismPortal2 * feat: log if impl of proxy add more functions * feat: More ChainAssertions reason strings * feat: checkDisputeGameFactory for isProxy * feat: Final checkAssertions error codes
-
smartcontracts authored
Contracts being hosted in this repository that are considered "third-party" are to be hosted in the vendor folder.
-
Matthew Slipper authored
* op-deployer: Update artifacts url * increase estimator multiples * log transactions
-
Matthew Slipper authored
* op-deployer: Test for existing OPCM Adds a test for deployments against an existing OPCM. The test works by spinning up an Anvil instance and forking Sepolia. To run this test, you'll need to specify two env vars: - `SEPOLIA_RPC_URL`: RPC URL for a Sepolia node. - `ENABLE_ANVIL`: Set to `true` to enable the test. In CI, the test uses our internal CI RPC nodes. * goimports * ensure streams close * lint * run anvil as part of unit not integration tests * simplify * remove foundry from kurtosis * use auto mine * mount artifacts * redeploy OPCM * comment
-
Francis Li authored
* Update op-geth depdency to 1.14.10 base * Update op-geth to v1.14.11 merge base * Update to ethereum-optimism/op-geth commit
-
smartcontracts authored
Adds Kontrol summary build back into CI just to verify that it functions correctly. In line with our recent CI changes this task still does not enforce that the build summary be checked in.
-
smartcontracts authored
Adds SOLIDITY_UPGRADES.md to contracts-bedrock. Please note that this document makes some references to a unified Solidity version. This will be true in a few days...
-
Maurelian authored
* feat: Add ChainAssertions for deploySuperchain contracts * Update Deploy.s.sol Co-authored-by:
Matt Solomon <matt@mattsolomon.dev> --------- Co-authored-by:
Matt Solomon <matt@mattsolomon.dev>
-
Minhyuk Kim authored
-
Adrian Sutton authored
Until recently we were running in-process and didn't have any timeout at all. Seems worth having but we're hitting the 1 hour timeout.
-
smartcontracts authored
Fixes an error in the deploy script that was recently introduced. SuperchainProxyAdmin was being set twice and ownership was being set incorrectly.
-
dependabot[bot] authored
Bumps ethereum/client-go from v1.14.8 to v1.14.11. --- updated-dependencies: - dependency-name: ethereum/client-go dependency-type: direct:production ... Signed-off-by:
dependabot[bot] <support@github.com> Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
- 02 Oct, 2024 20 commits
-
-
Maurelian authored
* feat: Add a test to simplify deploy script testing * fix: lint * feat: Add clarifying comments to DeployVariations_Test * feat: Extract deployment of pre-v1.6.0 code * feat: combine setupOPChain and DeployOpChain This will help to clarify where the DeployOpcChain script can be used. * fix: op-e2e issues with unfound contracts * fix: Undo conditional init of L2OutputOracle It needs to be in the state no matter what for op-e2e * fix: correct deploy ordering of legacy contracts * ugly but working * clean up legacy deployments * enable FP on system config custom gas token tests * op-e2e: allow no OptimismPortal impl if useFaultProofs * fix: lint
-
Inphi authored
* cannon: Define 64-bit syscalls Also add SYS_FSTAT to the list of no-op syscalls emulated by MT-Cannon * update semver-lock
-
George Knee authored
* op-service: add queue package * batcher: use Queue type for blocks * revert changes to errors.As/Is * implement and use Peek operation * queue: add unit tests * add godoc * add more test cases permute expected / got * ensure enqueue and prepend are noops when args is empty * use queue.PeekN and queue.DequeueN * typo * queue: simplify method implementations * revert to old dequeue impl
-
Matthew Slipper authored
* op-deployer: Custom gas price estimator Sepolia's fees are super high and extremely volatile right now. As a result, it became difficult for users to deploy new chains using op-deployer. The OPCM's deploy transaction buys most of the gas in the block, and the default gas price estimation logic in the transaction manager wasn't aggressive enough for the transactions to land on chain in a timely manner. This PR adds the ability to customize the transaction manager with a custom `GasPriceEstimator` function that returns the tip, base fee, and blob fee. I extracted the original logic in the transaction manager into a default estimator that will be used if one isn't specified. For op-deployer, I built a custom estimator that pads the head block's base fee by 20%, and multiplies the suggested tip by 10. After testing this, I was able to get transactions onto Sepolia reliably. The algorithm is pretty simple and overpays for transactions by a lot, but for op-deployer's use case it's more important that transactions land quickly than it is they be cheap. Deployments are a one-time thing. * code review updates * better default support * specific test for extension
-
Maurelian authored
* feat: Add a test to simplify deploy script testing * fix: lint * feat: Add clarifying comments to DeployVariations_Test
-
Blaine Malone authored
* Configurable Dispute Game Parameters * fix: more assertions for DeployOPChain.t.sol. * fix: running pre-pr command. * fix: changing dispute game types. * fix: semver lock file change. * fix: uint64 for maxGameDepth and splitDepth on go side. * fix: safe casting in solidity
-
Axel Kingsley authored
-
Maurelian authored
* feat: Use DeploySuperchain script in Deploy.s.sol Demonstrate that build breaks when using high level syntax * fix: Cannot set null protocol versions error * feat: Also save impls * fix: semver lock * fix: bump ProtocolVersions semver * feat: Add superchainProxyAdmin * feat: Undo removeing ProtocolVersion type from interface * fix: semver-lock * feat: remove setupOpChainAdmin * fix: transfer ProxyAdmin ownership after all setup is complete * feat: separate deployImplementations * feat: split up deployImplementations and deployImplementationsInterop * fix: lint
-
Adrian Sutton authored
* op-e2e: Retrieve AllocType from System instead of env * Remove more uses of env. * op-e2e: Run mt-cannon as an allocType without needing special env vars.
-
Maurelian authored
* feat: Use DeploySuperchain script in Deploy.s.sol Demonstrate that build breaks when using high level syntax * fix: Cannot set null protocol versions error * feat: Also save impls * fix: semver lock * fix: bump ProtocolVersions semver * feat: Add superchainProxyAdmin * feat: Undo removeing ProtocolVersion type from interface * fix: semver-lock
-
Chen Kai authored
* feat:add cannon load/store opcodes tests Signed-off-by:
Chen Kai <281165273grape@gmail.com> * fix:code review suggestion Signed-off-by:
Chen Kai <281165273grape@gmail.com> --------- Signed-off-by:
Chen Kai <281165273grape@gmail.com>
-
Brian Bland authored
* Sequencer: Origin Selector optimistically prefetches the next origin in background * L1OriginSelector erases cached state on reset * L1OriginSelector attempts to fetch on ForkchoiceUpdateEvent * Move to a fully event-driven model, no extra goroutines * Add missing test comment * Minor cleanup, more tests * Tune the context timeouts
-
Sebastian Stammler authored
-
Roberto Bayardo authored
This reverts commit 5bd72f69.
-
Michael Amadi authored
* use interfaces in opcm contracts * fix change * fix encodeConstructor omission * fix wrong interface usage * fix change * fix change * remove commented fn * fix semver conflict issue
-
Inphi authored
* cannon: Fix cli --stop-at-preimage value parsing * Setup alloc type in system config
-
Roberto Bayardo authored
-
Matthew Slipper authored
- The array was being appended to, but it was already a fixed length. This cause an empty chain to be added during `init`. - The outdir will now be created if it does not exist and is not a file - Hardcodes the contract artifacts to a good URL
-
Blaine Malone authored
* Configurable GasLimit for op-deployer * fix: OPContractsManager.t.sol fixed. * fix: OPContractsManagerInterop.sol * fix: make gas limit configurable.
-
Inphi authored
* cannon: 64-bit Refactor Refactor Cannon codebase to support both 32-bit and 64-bit MIPS emulation while reusing code as much as possible. * fix 64-bit test compilation errors * review comments * more review comments * fcntl syscall err for 64-bit * simplify pad check * cannon: sc must store lsb 32 on 64-bits * lint * fix sc 64-bit logic * add TODO state test
-
- 01 Oct, 2024 6 commits
-
-
smartcontracts authored
Temporarily makes semgrep-scan not fail on error. Currently this is a problem for external contributions because semgrep-scan loads rules from the online app which requires a login. External contributors don't get access to this login.
-
Matthew Slipper authored
* op-e2e: Support specifying allocs in tests Previously, the E2E test suite read a hardcoded set of allocs from the `.devnet` directory. There could only be one logical set of allocs per test suite run. To get around this limitation, we added matrix jobs to the CI pipeline that swapped in different versions of the allocs for alt-DA, MT Cannon, fault proofs, and the L2OO. This was very inefficient and complex: most tests don't need to run against multiple versions of the allocs, and were running 4 separate build jobs when only one was needed. This PR makes it possible for an individual test to request a specific allocs file. We can now run tests for multiple different configurations of the OP Stack - e.g. alt-DA, L2OO and fault proofs - in a single test run. To make this work, I updated the test suite's initialization method to read alloc files from multiple suffixed `.devnet-` directories. I made a a new `make devnet-allocs-tests` task to generate them. The allocs are then added to a map, and the rest of the tests use getter methods in the `config` package to locate the appropriate configuration structs. This PR seems large, but most of the modified files contain limited changes to comply with the new API for selecting test configuration based on alloc type. For example, an `allocType` configuration parameter was added to various system config structs and the `DefaultRollupTestParams` variable was made into a method so that it always returns a copy for easy extension. The important logic happens in the following files: - Makefile - .circleci/config.yml - op-e2e/config/init.go As part of this PR, I also cleaned up a few issues: - I removed the external OP Geth shim. It wasn't used anywhere, and was introducing a lot of complexity for little gain. - I refactored some tests to use top-level test methods rather than subtests so that they could be more easily parallelized. - I removed references to `UseFaultProofs`, `UseAltDA`, and other environment-based test flags from test utilities. We shouldn't be reading from the environment in test utils. Instead, we should pass in the behavior we want to the test utils themselves. * code review updates * fix gastoken test * fixes
-
Adrian Sutton authored
-
smartcontracts authored
FaultDisputeGame and PermissionedDisputeGame interface files are annoying because the semgrep ignore comment doesn't seem to work properly.
-
Roberto Bayardo authored
- clarify that 'just update-foundry' needs to be run from the root of the repo in check-foundry script. Usually the user will be in contracts-bedrock/src when seeing this message, and the justfile there doesn't handle it.
-
mbaxter authored
* cannon: Update cannon go test program versions * cannon: Allow more steps for multithreaded program
-