- 19 Nov, 2024 7 commits
-
-
BE Water authored
-
Adrian Sutton authored
* security-reviews: Add 3Doc report on Canon F_GETFD changes. * security-reviews: Update README.
-
Michael Amadi authored
* fix challenge struct natspec * semver bump * semver bump * semver bump
-
Michael Amadi authored
* improve tests * fixes * fixes * fixes * Apply suggestions from code review Co-authored-by:
smartcontracts <kelvin@optimism.io> * fixes --------- Co-authored-by:
smartcontracts <kelvin@optimism.io>
-
Michael Amadi authored
* improve tests * fixes * fixes... * Apply suggestions from code review Co-authored-by:
smartcontracts <kelvin@optimism.io> * fixes --------- Co-authored-by:
smartcontracts <kelvin@optimism.io>
-
Matthew Slipper authored
- Refactor the semver inspector so that it can be called from outside the CLI - Adds a a canonical L2 genesis file for v1.6.0, and a unit test to assert that new chains deployed using v1.6.0 have the right L2 genesis.
-
blaine authored
-
- 18 Nov, 2024 7 commits
-
-
Michael Amadi authored
* fix upgrade-semgrep * fix upgrade-semgrep
-
dependabot[bot] authored
Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.8.0 to 0.9.0. - [Commits](https://github.com/golang/sync/compare/v0.8.0...v0.9.0) --- updated-dependencies: - dependency-name: golang.org/x/sync dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by:
dependabot[bot] <support@github.com> Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
Chen Kai authored
* feat:Add more sync tests Signed-off-by:
Chen Kai <281165273grape@gmail.com> * feat:add more sync tests Signed-off-by:
Chen Kai <281165273grape@gmail.com> * fix:fix failed tests Signed-off-by:
Chen Kai <281165273grape@gmail.com> * fix:add copyright credit and remove unused code Signed-off-by:
Chen Kai <281165273grape@gmail.com> * fix:fix copyright format Signed-off-by:
Chen Kai <281165273grape@gmail.com> * fix code review suggestions Signed-off-by:
Chen Kai <281165273grape@gmail.com> --------- Signed-off-by:
Chen Kai <281165273grape@gmail.com>
-
soyboy authored
* removing duplicate default bootnode * adding conduit bootnodes * removing duplicate bootnode
-
George Knee authored
* use a queue.Queue for channelBuilder.frames * remove pop and push terminology * proliferate queue.Queue type * simplify requeue method * undo changes to submodule * sketch out new arch https://www.notion.so/oplabs/op-batcher-re-architecture-114f153ee162803d943ff4628ab6578f * add TODO * add channelManager.pruneSafeBlocks method and integrate into main loop * fix frameCursor semantics * fixup tests * avoid Rewind() in tests * only rewind cursor in rewind (never move it forward) * fix assertions * prune channels whose blocks are now safe * handle case when rewinding a channel with no blocks this is strange, I don't think we should expect channels with frames but no blocks... * add clarification * implement channelManager.pendinBlocks() method * fix pruning logic * simplify pruneChannels * simplify pruneSafeBlocks * add unit tests for pruneSafeBlocks * fix pruneSafeBlocks to avoid underflow * improve test * add unit tests for pruneChannels * introduce handleChannelTimeout and simplify channel.TxConfirmed API * factor out channelManager.rewindToBlockWithHash * change test expectation * do more pruning in test * Replace "clean shutdown" behaviour with waitNodeSync() Instead of optimizing for a clean shutdown (which we couldn't guarantee anyway), this change optimizes for code simplicity. This change also helps us restrict the amount of code which mutates the channelQueue (removePendingChannel was doing removal of channels at arbitrary positions in the queue). The downside is that we may end up needlessly resubmitting some data after the reset. Reorgs are rare, so it makes sense to optimize for correctness rather than DA costs here. * Add readme and architecture diagram * don't panic when there is a safe chain reorg * fix test * readability improvements * only clear state after waiting for node to sync * resize image * tweak readme * typo * rewindToBlockWithHash never moves cursor forward * use s.pendingBlocks() * add log line * check there are blocks when handling timeout * rename HasFrame() to HasPendingFrame() * fixup test * improve readme * link to open issues by tag * add log when main loop returns * pass blockID to rewindToBlock and panic if block does not exist * don't remove all channels when a channel times out keep older channels, it's possible that they also time out * use newSafeHead.L1Origin in Clear() when pruning blocks * clarify comment * use warn log level on safe chain reorg pruning, and unify handling for safe head above unsafe head * update panic message * extend test coverage and fix bug * rename test blocks * simplify HasPendingFrame() method * simplify implementation of RewindFrameCursor * activate dormant test * ensure pending_blocks_bytes_current metric is tracked properly * cover metrics behaviour in test using new TestMetrics struct * extend test coverage to channelManager.handleChannelTimeout * add comment to TxFailed * rename test fn * point to e2e tests in readme. * readme: performance -> throughput * improve channel_manager_test to assert old channels are not affected by requeue or timeout * fix handleChannelTimeout behaviour We were trimming older channels and keeping new ones. We need to trim newer channels and keep old ones. Fixes associated test (see previous commit). * tighten up requirements for invalidating a channel * replace requeue with handleChannelInvalidated
-
George Knee authored
* op-batcher: fix channel duration timeout management Previously, we would use L1 data to help track channel durations. For example, the batcher would be configured to post data every hour. We update a global state variable with the latest l1 origin of a channel when it closed, and compute the deadline for that channel using a duration delta starting at that l1 origin timestamp. Since we changed the way autoDA switching works, a channel can be _closed_ (due to a duration timeout or other reason) and this will cause the l1 origin state variable to move forward, extending the deadline ready for the next channel. Crucially, with autoDA switching nowadays, the closed channel will not always be submitted on chain (it can be discarded and the blocks requeued). If it is discarded, the channel duration timeout has already been extended. The fix for this is to update the global state variable at channel submission time, not channel closing time. * add regression test for channel duration timeouts during requeue
-
zhiqiangxu authored
* ensure bcast.From == mgr.From() * address comment * fix for create2
-
- 17 Nov, 2024 1 commit
-
-
Inphi authored
-
- 16 Nov, 2024 2 commits
-
-
Michael Amadi authored
* remove unnecessary check * fixes
-
blaine authored
* fix: semver locking. * fix: semver locking. * feat: opcm impl contracts now type safe. * feat: fixing test. * fix: removing unused imports. * fix: address didn't need to be payable. * fix: moving all smart contract changes to first pr. * fix: pr comments addressed. * fix: removed InputContracts struct. * fix: ran pre-pr * fix: deploy implementations renaming version. * fix: adding solidity changes to this pr. * fix: adding v160 initializer back in. * fix: removed branching logic from opcm. * fix: removed SystemConfigV160. * opcm-redesign: op-deployer changes * fix: linting fix. * fix: semver lock --------- Co-authored-by:
Matthew Slipper <me@matthewslipper.com>
-
- 15 Nov, 2024 9 commits
-
-
Michael Amadi authored
* improve tests * improve tests * fixes
-
Maurelian authored
-
mbaxter authored
* cannon: Add version 3 state and enable detect test * cannon: Get other DetectVersion tests running
-
Michael Amadi authored
-
Michael Amadi authored
-
Michael Amadi authored
-
Roberto Bayardo authored
-
clabby authored
* feat(ctb): Holocene upgrade package * lint * lint * add example env to sc-ops task * fix * reuse `SystemConfig` and `MIPS` impls optionally * optionally deploy a new `DelayedWETH` proxy + impl add check * env lint * add docker image to docker tag service * kelvin idiot-proofing ask * fetch standard config addresses for Holocene * lint * ajsutton review: Deploy separate DelayedWETH proxies for the FDG/PDG * ajsutton review: Conditional FDG usage * use contracts rc tag * mds review * split `SystemConfig` and proofs contracts upgrades * add option to completely disclude the fault proof contracts fix * Update README * verify * deploy config * fix contract tag * README update * semgrep
-
Matthew Slipper authored
-
- 14 Nov, 2024 4 commits
-
-
mbaxter authored
* cannon: Add differential tests for lui instruction * cannon: Add clo, clz differential tests
-
Raffaele authored
-
Adrian Sutton authored
-
Chen Kai authored
* feat:add bne test Signed-off-by:
Chen Kai <281165273grape@gmail.com> * feat:Add sll/srl/sra/sllv/srlv/srav/jr/jalr/beq/bne mips test Signed-off-by:
Chen Kai <281165273grape@gmail.com> * Apply suggestions from code review Co-authored-by:
mbaxter <meredith.a.baxter@gmail.com> * fix:add code review suggestion Signed-off-by:
Chen Kai <281165273grape@gmail.com> --------- Signed-off-by:
Chen Kai <281165273grape@gmail.com> Co-authored-by:
mbaxter <meredith.a.baxter@gmail.com>
-
- 13 Nov, 2024 4 commits
-
-
Sebastian Stammler authored
-
Michael Amadi authored
-
protolambda authored
* op-chain-ops: state forking, Go script forking, cheatcode access-control * add forking unit tests * goimports * linter * fix state dump * Add script test, hammer out bugs * semgrep ignore scripts * op-chain-ops: script state dump test * fix merge error * goimports --------- Co-authored-by:
Matthew Slipper <me@matthewslipper.com>
-
Michael Amadi authored
* improve L1 contracts code cov * improve L1 contracts code cov * improve L1 contracts code cov * improve L1 contracts code cov * improve L1 contracts code cov * improve L1 contracts code cov
-
- 12 Nov, 2024 4 commits
-
-
protolambda authored
-
Joshua Gutow authored
-
Inphi authored
* cannon: Add more 64-bit tests * address review comments
-
George Knee authored
* confirm holocene activation behavior TODO remove hack around setting holocene time TODO add log assertions * add holocene_activation_test.go * move holocene time hardcoding into test override * tidy * Update op-e2e/actions/proofs/holocene_activation_test.go Co-authored-by:
clabby <ben@clab.by> --------- Co-authored-by:
clabby <ben@clab.by>
-
- 11 Nov, 2024 2 commits
-
-
George Knee authored
* fix double error in inferring isHolocene * add capture logging to l2faultproofenv * fold log expectations into holoceneExpectations * improve test failure output * attach log expectations to invalid batch test case * add more log expectations * add more log expectations * add more test expectations for invalid payloads * add log assertion for deposits-only attributes * improve test names * improve subtest names * move holocene helpers to separate file * remove shadow * add log assertions for holocene_batches_test.go * remove assertion on logs in frame queue
-
George Knee authored
-