1. 16 Aug, 2023 21 commits
  2. 15 Aug, 2023 19 commits
    • mergify[bot]'s avatar
      08aedaa3
    • clabby's avatar
      Add link to devnet MD · 7ea6f166
      clabby authored
      7ea6f166
    • Joshua Gutow's avatar
      6e1a059a
    • clabby's avatar
      Update packages/contracts-bedrock/CONTRIBUTING.md · 6ee425d9
      clabby authored
      Co-authored-by: default avatarrefcell.eth <abigger87@gmail.com>
      6ee425d9
    • clabby's avatar
      Update packages/contracts-bedrock/CONTRIBUTING.md · 14eff736
      clabby authored
      Co-authored-by: default avatarrefcell.eth <abigger87@gmail.com>
      14eff736
    • clabby's avatar
      Update packages/contracts-bedrock/CONTRIBUTING.md · 87bc8f71
      clabby authored
      Co-authored-by: default avatarrefcell.eth <abigger87@gmail.com>
      87bc8f71
    • clabby's avatar
      Update packages/contracts-bedrock/CONTRIBUTING.md · e556059c
      clabby authored
      Co-authored-by: default avatarrefcell.eth <abigger87@gmail.com>
      e556059c
    • clabby's avatar
      Update packages/contracts-bedrock/CONTRIBUTING.md · fffa53e5
      clabby authored
      Co-authored-by: default avatarrefcell.eth <abigger87@gmail.com>
      fffa53e5
    • clabby's avatar
      Update packages/contracts-bedrock/CONTRIBUTING.md · 22ce55fc
      clabby authored
      Co-authored-by: default avatarrefcell.eth <abigger87@gmail.com>
      22ce55fc
    • Joshua Gutow's avatar
      op-service: Fix txmgr test · 0e52218c
      Joshua Gutow authored
      The context in txmgr.Send is now being checked for cancellations by the
      retry package which wraps craftTx. This caused an error in one of the
      txmgr queue tests. The flow of the test is that it would send a valid tx,
      send an invalid tx, and then send another tx. It'd expect that the last
      tx got cancelled because of the context cancellation propogation (i.e. if
      one tx in the queue fails, all will fail).
      
      Because the context is cancelled prior to the call to txmgr.Send & this
      check on the context, the transaction is no longer failing in the receipt
      loop, but at craftTx. This test checked that the transaction would make it
      to the receipt loop (via hooking into sendTx where it recorded the nonce).
      0e52218c
    • Joshua Gutow's avatar
      op-service: Harden Transaction Manager · 6b0b8a00
      Joshua Gutow authored
      This commit fixes a common source of errors in the transaction manager
      which then cause significant problems for the batcher. The transaction
      manager is designed to be resilient from errors when resubmitting txns or
      when polling for transaction receipts. It was not designed to be resilient
      on the initial transaction submission, and that was the root cause of
      several incidents.
      
      This commit fixes this issue by wrapping `craftTx` in a retry. If there is a
      sustained problem for longer than the amount of retries, issues could still
      happen, but this will significantly reduce the number of issues.
      
      A failure in craftTx is so harmful is because the transaction manager is
      wrapped in a txmgr.Queue which handles multiple in flight transactions.
      The queue uses an errgroup to manage concurrency and when any single
      txmgr.Send fails it will cancel the context & cancel the rest of the in flight
      sends. Because txmgr.Send could fail when creating a transaction, a transient
      failure would cancel multiple in flight transactions. Some of these in flight
      transactions would eventually land on L1 and the batcher would lose track of
      which frames it had submitted & thus could submit duplicate frames.
      
      Two examples of this flow are provided in the logs. First a timeout happens in
      the transaction creation, then multiple transactions are cancelled via the context.
      Then there is a log for "aborted transaction sending". This log occurs because a
      transaction that was cancelled landed on L1 and the nonce of the transaction is too
      low. That then cancels then pending transactions again.
      
      t=2023-07-13T16:22:28+0000 lvl=warn msg="unable to publish tx"                   err="context canceled"                    data_size=120,000
      t=2023-07-13T16:22:28+0000 lvl=warn msg="unable to publish tx"                   err="context canceled"                    data_size=120,000
      t=2023-07-13T16:22:28+0000 lvl=warn msg="unable to publish tx"                   err="context canceled"                    data_size=120,000
      t=2023-07-13T16:22:28+0000 lvl=warn msg="unable to publish tx"                   err="context canceled"                    data_size=120,000
      t=2023-07-13T16:22:28+0000 lvl=warn msg="unable to publish tx"                   err="context canceled"                    data_size=104,419
      t=2023-07-13T16:22:28+0000 lvl=warn msg="unable to publish tx"                   err="context canceled"                    data_size=120,000
      t=2023-07-13T16:22:28+0000 lvl=warn msg="unable to publish tx"                   err="aborted transaction sending"         data_size=120,000
      t=2023-07-13T16:20:24+0000 lvl=warn msg="unable to publish tx"                   err="context canceled"                    data_size=120,000
      t=2023-07-13T16:20:24+0000 lvl=warn msg="unable to publish tx"                   err="context canceled"                    data_size=120,000
      t=2023-07-13T16:20:24+0000 lvl=warn msg="unable to publish tx"                   err="context canceled"                    data_size=120,000
      t=2023-07-13T16:20:24+0000 lvl=warn msg="unable to publish tx"                   err="context canceled"                    data_size=860
      t=2023-07-13T16:20:24+0000 lvl=warn msg="unable to publish tx"                   err="context canceled"                    data_size=120,000
      t=2023-07-13T16:20:24+0000 lvl=warn msg="unable to publish tx"                   err="context canceled"                    data_size=120,000
      t=2023-07-13T16:20:24+0000 lvl=warn msg="unable to publish tx"                   err="failed to create the tx: eth_signTransaction failed: Post \"--snip--\": context deadline exceeded" data_size=120,000
      
      t=2023-07-13T16:07:37+0000 lvl=warn msg="unable to publish tx"                   err="context canceled"                    data_size=104,670
      t=2023-07-13T16:07:37+0000 lvl=warn msg="unable to publish tx"                   err="context canceled"                    data_size=120,000
      t=2023-07-13T16:07:37+0000 lvl=warn msg="unable to publish tx"                   err="context canceled"                    data_size=120,000
      t=2023-07-13T16:07:37+0000 lvl=warn msg="unable to publish tx"                   err="aborted transaction sending"         data_size=120,000
      t=2023-07-13T16:05:05+0000 lvl=warn msg="unable to publish tx"                  err="context canceled" data_size=120,000
      t=2023-07-13T16:05:05+0000 lvl=warn msg="unable to publish tx"                  err="context canceled" data_size=110,635
      t=2023-07-13T16:05:05+0000 lvl=warn msg="unable to publish tx"                  err="context canceled" data_size=120,000
      t=2023-07-13T16:05:05+0000 lvl=warn msg="unable to publish tx"                  err="context canceled" data_size=120,000
      t=2023-07-13T16:05:05+0000 lvl=warn msg="unable to publish tx"                  err="failed to create the tx: failed to get gas price info: failed to fetch the suggested gas tip cap: Post \"--snip--\": context deadline exceeded" data_size=120,000
      6b0b8a00
    • OptimismBot's avatar
      Merge pull request #6800 from ethereum-optimism/cleanup/old-upgrade-scripts · b9238afd
      OptimismBot authored
      contracts-bedrock: delete sherlock upgrade scripts
      b9238afd
    • mergify[bot]'s avatar
      bdb8b6c5
    • OptimismBot's avatar
      Merge pull request #6716 from ethereum-optimism/dependabot/npm_and_yarn/nx-16.6.0 · b7edde20
      OptimismBot authored
      build(deps-dev): bump nx from 15.6.0 to 16.6.0
      b7edde20
    • mergify[bot]'s avatar
    • OptimismBot's avatar
      Merge pull request #6772 from... · 65f409ef
      OptimismBot authored
      Merge pull request #6772 from ethereum-optimism/08-13-feat_indexer_Start_adding_ui_to_indexer_docker-compose
      
      feat(indexer): Start adding ui to indexer docker-compose
      65f409ef
    • mergify[bot]'s avatar
    • OptimismBot's avatar
      Merge pull request #6719 from ethereum-optimism/dependabot/npm_and_yarn/pino-sentry-0.14.0 · 9b65d023
      OptimismBot authored
      build(deps): bump pino-sentry from 0.7.0 to 0.14.0
      9b65d023
    • dependabot[bot]'s avatar
      build(deps-dev): bump nx from 15.6.0 to 16.6.0 · b13af041
      dependabot[bot] authored
      Bumps [nx](https://github.com/nrwl/nx/tree/HEAD/packages/nx) from 15.6.0 to 16.6.0.
      - [Release notes](https://github.com/nrwl/nx/releases)
      - [Commits](https://github.com/nrwl/nx/commits/16.6.0/packages/nx)
      
      ---
      updated-dependencies:
      - dependency-name: nx
        dependency-type: direct:development
        update-type: version-update:semver-major
      ...
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      b13af041