- 18 Feb, 2023 1 commit
-
-
Mark Tyneway authored
It was looking in the wrong directory for the `build-info` file directory.
-
- 17 Feb, 2023 30 commits
-
-
mergify[bot] authored
contracts-bedrock: prevent deposits with too small gaslimit
-
mergify[bot] authored
-
Matthew Slipper authored
op-node: handle when L1 time gap is larger than sequencer time drift
-
Mark Tyneway authored
contracts-bedrock: L2StandardBridge legacy `withdraw`
-
mergify[bot] authored
-
mergify[bot] authored
contracts-bedrock: clean up fee vault tests
-
mergify[bot] authored
-
Mark Tyneway authored
-
Mark Tyneway authored
-
Mark Tyneway authored
Adds a test for the legacy withdraw functionality on the L2StandardBridge. Previously there were no tests for withdrawing ether via `withdraw`. This adds coverage. Also natspec is added to describe that these functions are not useful for being able to withdraw native L2 tokens. The modern functions must be used to withdraw native L2 tokens, the legacy functions assume that the withdrawal is working on a OptimismMintableERC20 token. Also regenerate the bindings for the slight change to the bytecode where we save a call in the withdrawal path if we don't need to make the call.
-
Mark Tyneway authored
-
Mark Tyneway authored
-
Mark Tyneway authored
The deposits sent to L2 should have a gas limit that at least covers the intrinsic gas. If the deposits do not pay that much, then it is possible for cause resource usage on L2 without paying for it. This is not a critical bug because the user would still need to pay for L1 inclusion.
-
mergify[bot] authored
contracts-bedrock: add semver to mintable tokens
-
Mark Tyneway authored
-
Mark Tyneway authored
-
Mark Tyneway authored
-
Mark Tyneway authored
Even though the mintable tokens are not upgradable, this commit adds semver to them in case we change the implementations down the road and then update the factories to deploy the new versions. I do think it would be nice to know what version different mintable tokens are on, in case we decide to add functionality to the mintable tokens. This will make it very easy to know what version the mintable tokens are at, in case newer mintable tokens have different functionality in some way.
-
Mark Tyneway authored
-
Mark Tyneway authored
Removes broken / unused changeset workflow
-
mergify[bot] authored
maint(ctb): cleanup and comments for SystemConfig
-
Kelvin Fichter authored
Minor cleanup and comment updates for the SystemConfig contract. Some comments were missing and functions weren't entirely in the right order.
-
mergify[bot] authored
Add logs to devnet-up test
-
mergify[bot] authored
-
protolambda authored
-
mergify[bot] authored
ci: change Go lint timeout from 1m (default) to 2m
-
protolambda authored
-
mergify[bot] authored
op-node: Fix invalid advance in the batch queue
-
mergify[bot] authored
-
Joshua Gutow authored
-
- 16 Feb, 2023 9 commits
-
-
mergify[bot] authored
Merge pull request #4887 from ethereum-optimism/dependabot/go_modules/bss-core/github.com/prometheus/client_golang-1.11.1 chore(deps): bump github.com/prometheus/client_golang from 1.11.0 to 1.11.1 in /bss-core
-
Joshua Gutow authored
-
Joshua Gutow authored
This reproduces a bug found by mdehoog. This bug causes the system to halt under certain circustances. Specifically, when generating batches at the end of the sequence window the batch queue would attempt to generate empy batches from the next L2 timestamp to the timestamp of the next L1 origin. If the timestamp of the next L1 origin was less than the timestamp of the next L2 block time, no batches would be generated and the internal L1 blocks would be advanced. This would cause L1 origins to be skipped. This got caught by a consistency check we have in the batch queue, but loops in an unrecoverable error until this bug is fixed.
-
Joshua Gutow authored
-
mergify[bot] authored
Merge branch 'develop' into dependabot/go_modules/bss-core/github.com/prometheus/client_golang-1.11.1
-
Mark Tyneway authored
contracts-bedrock: be explicit with mintable erc721 token version
-
dependabot[bot] authored
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.11.0 to 1.11.1. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](https://github.com/prometheus/client_golang/compare/v1.11.0...v1.11.1) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production ... Signed-off-by:
dependabot[bot] <support@github.com>
-
Mark Tyneway authored
fix(ctb): add is IERC165 to IOptimismMintableERC20
-
Mark Tyneway authored
contracts-bedrock: relax semver solidity version
-