Skip to content

N
nebula
Switch branch/tag
  1. 16 Aug, 2024 10 commits
    • Inphi's avatar
      Add gas input to precompile pre-images (#186) (#252) · db61d2bb
      Inphi authored 
      * contracts: Add gas input to precompile pre-images (#186)

Also update the cannon evm tests to use the new precompile preimage scheme.

---------
Co-authored-by: default avatarAdrian Sutton <adrian@oplabs.co>

* op-challenger: Support uploading data in new format. (#188)

* op-program: Add required gas to precompile oracle key (#176)

* op-challenger: Support multiple versions of the preimage oracle contract

---------
Co-authored-by: default avatarAdrian Sutton <adrian@oplabs.co>

---------
Co-authored-by: default avatarinphi <mlaw2501@gmail.com>

---------
Co-authored-by: default avatarAdrian Sutton <adrian@oplabs.co>
      db61d2bb
    • smartcontracts's avatar
      fix: have mips step check register offset instead of overwrite (#238) · f54765ce
      smartcontracts authored 
      Existing step logic wrote the register offset into memory but the
compiler should already be doing this when the struct is defined.
Instead of writing directly into memory, this change verifies that
the memory at that location has the expected value which will
catch any cases where the compiler's memory allocation mechanism
changes in the future.
      f54765ce
    • smartcontracts's avatar
      fix: make state.exited be zero or one (#246) · 4348c663
      smartcontracts authored 
      Modifies the MIPS contracts to enforce that state.exited is either
exactly zero or one and cannot have any other value.
      4348c663
    • smartcontracts's avatar
      fix: have DelayedWETH use call instead of transfer (#228) · a03e4e34
      smartcontracts authored 
      Updates DelayedWETH to use call instead of transfer because
transfer only sends along 2300 gas which will cause the transfer
to fail if the owner contract uses lots of gas in the fallback
function. Adds tests that demonstrate that the function now works
appropriately under any reasonable amount of gas usage. In theory
this means the recovery function can be reentered but this isn't
an issue because the function is authenticated and is recovering
all of the ETH in the contract anyway.
      a03e4e34
    • smartcontracts's avatar
      fix: correct implementation of srav (#245) · c303b218
      smartcontracts authored 
      Existing implementation of SRAV had a bug where it would perform a
shift with all bytes of the rs register when the spec says it
should only be using the lower 5 bits of the register. Updates the
implementation to reflect this, updates the existing test to use
the same test vector as provided in the open mips tests, and adds
fuzz tests that shows srav works as expected with rs values that
have more than the lower 5 bits set.
      c303b218
    • smartcontracts's avatar
      fix: have MIPS revert on add/sub overflow/underflow (#230) · 5221af89
      smartcontracts authored 
      Updates MIPSInstructions so that it correctly reverts on calls to
add, addi, and sub that overflow/underflow. Additionally includes
tests that demonstrates that the unchecked versions of the same
opcodes allow for overflow/underflow.
      5221af89
    • Kelvin Fichter's avatar
      fix: correct check for max game depth · 5bd46ac5
      Kelvin Fichter authored 
      Modifies the FDG constructor to correctly check that the
splitDepth +1 is gte the max game depth. Means that the splitDepth
is now limited to be 1 smaller than it was before. Fine in prod
but avoids a bug in the trace ancestor lookup logic.
      5bd46ac5
    • Kelvin Fichter's avatar
      fix: require minimum split depth of 2 · cbbe2621
      Kelvin Fichter authored 
      FDGs with a split depth below 2 can trigger bugs in clock
extension. Since we don't expect to have a split depth anywhere
near 0 or 1 this is a low impact bug and doesn't have an impact
on production but should be prevented anyway.
      cbbe2621
    • Adrian Sutton's avatar
      Prevent reiniting preimage uploads. (#190) · 937acedf
      Adrian Sutton authored
      937acedf
    • oisa godspower's avatar
      fix run-kontrol.sh path (#11495) · 1e2b19cb
      oisa godspower authored
      1e2b19cb
  3. 15 Aug, 2024 10 commits
    • Sebastian Stammler's avatar
      op-e2e: Add forge clean to README.md troubleshooting section (#11471) · 77fb5726
      Sebastian Stammler authored 
      * op-e2e: Add forge clean to README.md troubleshooting section

* Update op-e2e/README.md
Co-authored-by: default avatarMatt Solomon <matt@mattsolomon.dev>

---------
Co-authored-by: default avatarMatt Solomon <matt@mattsolomon.dev>
      77fb5726
    • Mark Tyneway's avatar
      getting-started: modernize (#11436) · fabf7cba
      Mark Tyneway authored 
      Make the getting started script modern by adding recent hardfork config
and also make the script runnable from any directory.
      fabf7cba
    • Kim's avatar
      feat: add cgo_test tags to fuzz tests (#11489) · 9bfd2b86
      Kim authored
      9bfd2b86
    • Adrian Sutton's avatar
      op-challenger: Extract RegistrationTask to dedeuplicate registration code... · cfe3cdd5
      Adrian Sutton authored 
      op-challenger: Extract RegistrationTask to dedeuplicate registration code between different game types. (#11413)
      cfe3cdd5
    • protolambda's avatar
      op-chain-ops/script: ConsolePrecompile with console2 ABI (#11446) · 46930eab
      protolambda authored 
      v2
      46930eab
    • angel-ding-cb's avatar
      Added Stop API in the conductor (#11463) · 04757a06
      angel-ding-cb authored 
      * add stop api in the conductor

* add tests

* fix test cases

* fix conductor stop api test

* re-trigger ci tests
      04757a06
    • Matt Solomon's avatar
      ci: remove proof runner workflow (#11486) · 389d2511
      Matt Solomon authored 
      The 'on: status' trigger is too broad and causes this job to trigger
for all commits. Instead KaaS (Kontrol as a Service) will post the
resulting status to slack directly, instead of through github
      389d2511
    • Sam Stokes's avatar
      repo: rename plasma --> altDA (#11370) · 0bb2ff57
      Sam Stokes authored 
      * update superchain-registry import

* replace all plasma with altda

* replace plasma with altda in filenames

* contracts: update snapshots

* go: update superchain import

* go: update superchain import after rebase

* go: run mod tidy

* op-batcher: fix altda env vars passed in devnet docker-compose

* go: update superchain import

* go: use main commit for superchain import
      0bb2ff57
    • Freeman's avatar
      Feature/rv compute (#11015) · eaed52d1
      Freeman authored 
      * Add dummy tests for passing and failing

* Updating passing along return errors and a duplicate call to clean_docker

* Fixing logging

* Update to latest kontrol version supporting error codes

* Remove trap for testing

* Add install-kontrol and run local with enforced version requiresments

* Drop on failure trap and test

* The cleanup steps may be altering the return results. We're not running docker, not needed here

* Test with traps re-added after finding issue was with using find

* Formatting, now test with passing test

* Update run-kontrol.sh

Revert debug set to original header

* Increase CPU workers to 16 for kaas runners

* Update config.yml

* Remove dummy proofs

* run-kontrol.sh: set `max_workers` to 16

* run-kontrol.sh: execute all tests with `script` option

* run-kontrol.sh: match tests more precisely

* run-kontrol.sh: add back `break_every_step` variable

* versions.json: bump Kontrol from 0.1.247 to 0.1.258

* IGnore vscode configuration files

* Move on regardless of docker removal, container is started with automatic removal on stop, we just want to make sure it happens for redundancy

* Extract content of Results to upload to kaas

* Call into RV Workflow to run symbolic tests

* Updating circleCI to latest credentials setup/secret references. Set context to proper env. Remove unused inputs

* Reverting unecessary change

* Add RV context

* Removing comma from end of json block

* Set the specific branch name to run on, do not assume develop.

* Temporary when conditional to always run

* Revert test when conditional

* Supress extraction of outputs

* Accept Suggestion for comment line in packages/contracts-bedrock/test/kontrol/scripts/run-kontrol.sh
Co-authored-by: default avatarMatt Solomon <matt@mattsolomon.dev>

* Supress tar file creation output

* Dropping -verbose in tar command. Reduce output on exeutions

* run-kontrol.sh: Update Temporarily unexecuted tests list

* run-kontrol.sh: Update Temporarily unexecuted tests list v2

* Update documentation noting changes / usage / flow / secrets for utilizing kaas

* run-kontrol.sh: Fetch the xml file if it exists from the build env and make available for posting to summary

* Update packages/contracts-bedrock/test/kontrol/README.md
Co-authored-by: default avatarMatt Solomon <matt@mattsolomon.dev>

* Update packages/contracts-bedrock/test/kontrol/README.md
Co-authored-by: default avatarMatt Solomon <matt@mattsolomon.dev>

* Update packages/contracts-bedrock/test/kontrol/README.md
Co-authored-by: default avatarMatt Solomon <matt@mattsolomon.dev>

* Update packages/contracts-bedrock/test/kontrol/README.md
Co-authored-by: default avatarMatt Solomon <matt@mattsolomon.dev>

* Update packages/contracts-bedrock/test/kontrol/README.md
Co-authored-by: default avatarMatt Solomon <matt@mattsolomon.dev>

* kontrol/README.md: Update instructions for clarity and usage

* .github/workflows: Adding a new workflow to trigger on updates to depoloyment_status from third party

* Force push to test

* Remove if check for environment.

* status-test: This looks like the wrong trigger

* Update slack notification workflow with template

* proof-runner-notification.yml: Slack notifications on failure, and webhook URL

* Replace Link with provided target_url from commit status

* Update payload variables per slack workflow variable requirements.

---------
Co-authored-by: default avatarJuan C <juanconrod@protonmail.com>
Co-authored-by: default avatarMatt Solomon <matt@mattsolomon.dev>
      eaed52d1
    • Sam Stokes's avatar
      txmgr: add rpc api getters/setters (#10897) · 549b52e0
      Sam Stokes authored 
      * Add txmgr rpc api

* Update mock TxManager

* Use parameterized tests to remove redundant code

* Add txmgr.cfgLock to protect values configurable at runtime

* txmgr: use generic API() method on interface to allow custom rpc apis

* txmgr: re-generate mocks

* txmgr: use atomics for Config vals that can be modified via rpc

* txmgr: use pointer for SimpleTxManager.cfg

* txmgr: remove extraneous code

* txmgr: cleanup ctx input arg in rpc methods
      549b52e0
  5. 14 Aug, 2024 13 commits
  7. 13 Aug, 2024 7 commits