- 27 Sep, 2022 21 commits
-
-
Matthew Slipper authored
Need to include these artifacts for the contracts tests to work. Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Matthew Slipper authored
* ci: Fix Hive artifacts I'm still seeing sporadic errors with the l1ops tests. This PR fixes the artifacts upload so that I can debug further. * fix paths
-
Mark Tyneway authored
Will allow for e2e testing of the nft bridge scripts on `ops` Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Matthew Slipper authored
* ci: Use workspace rather than cache * remove test code Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Maurelian authored
Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Mark Tyneway authored
Allow `paths` to be unset in the hardhat config. The default path will be used if a top level `paths` object is not included in the hardhat config. Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Mark Tyneway authored
Slight improvement to the `MintManager`. Making the reference to the `governanceToken` an immutable is just better than placing it in storage. Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Mark Tyneway authored
* op-chain-ops: address aliasing helpers Implement address aliasing helpers in go. Fuzz them to make sure that roundtrip aliasing is reliable. Add foundry fuzz tests that are used to generate test vectors. Note that the JS implementation does not take into account the modular arithmetic, I do not believe that it is used anywhere important currently. See: https://github.com/ethereum-optimism/optimism/blob/develop/packages/core-utils/src/optimism/alias.ts Perhaps we should move our differential fuzzing to use go instead of typescript or along with the typescript because most utilities that we wrote in JS are now also written in go. * chore: make mod-tidy * op-bindings: regenerate * contracts-bedrock: gas snapshot * specs: update address-aliasing
-
smartcontracts authored
Moves the msg.value == amount check when bridging ETH deeper into the call stack. Has the effect of making the function less of a footgun for future developers. Co-authored-by:
Matthew Slipper <me@matthewslipper.com> Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Matthew Slipper authored
* ci: Docker login on push Increases the reliability of Docker publish jobs by logging in to Docker Hub first. The secret used is read-only, and scoped to public repositories only. Note that the `l1ops` Hive test will continue to fail until https://github.com/ethereum-optimism/hive/pull/43 is merged. * remove repo * specify nameservers * Update config.yml Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Joshua Gutow authored
This provides a new set of objects which provide the following API guarantees: - The opening of a data for a new L1 block will never. - If it failed to get transactions, it does so in the calls to `Next`. This greatly simplifies usage of this object when constructing new data. If the node did not keep track of the internal state, the external users of this API would have to keep track of this state in a more complex way. Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Matthew Slipper authored
-
Matthew Slipper authored
-
Matthew Slipper authored
-
Matthew Slipper authored
-
Matthew Slipper authored
-
protolambda authored
* op-chain-ops: use PoS consensus in simulated backend in deployer, and add PoS option to genesis * op-geth: update dependencies for new simulated backend option and ttd check fix Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Mark Tyneway authored
There was a leftover require from when the contract was `initializable`. This commit removes that because it is no longer needed. Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Matthew Slipper authored
This job isn't needed anymore since we're compiling the artifacts into the bindings. Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
smartcontracts authored
Minor modification that puts the raw body as a string on the request object. Useful for applications where the raw body is required rather than the parsed JSON body as given by bodyParser. For example, this is useful when verifying GitHub webhooks. Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Matthew Slipper authored
* op-node: Fix OPB-07 Fixes Sigma Prime audit issue OPB-07: Private Key Stored Without Encryption. This PR requires reading the sequencer private key from an environment variable rather than a file on disk. Fixes ENG-2616 * fix devnet * delete superfluous file Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
- 26 Sep, 2022 7 commits
-
-
smartcontracts authored
Adds consistency checks for L1 syncing nodes in the DTL. One of my personal nodes seemed to halt with this error, so fixing it. Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Maurelian authored
-
smartcontracts authored
Adds versioning rules to the Bedrock contracts package. Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Mark Tyneway authored
The tests run as part of `bedrock-go-tests` so no need to have a task specific for `op-chain-ops`. Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
sam-goldman authored
Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
smartcontracts authored
Introduces a new task for validating the correctness of spacer variables. Prevents future developers from accidentally moving spacers. Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Mark Tyneway authored
* op-chain-ops: implement withdrawal hashing Implement both the new hashing scheme and the legacy hashing for withdrawals so that the withdrawals can be migrated. Also implement encoding and decoding of the withdrawals * more tests * op-chain-ops: code review fixes * op-chain-ops: fix message passer Now that the old message passer is being kept in the L2 state, be sure to the use legacy address. The new message passer is at a different address.
-
- 24 Sep, 2022 12 commits
-
-
Maurelian authored
-
Maurelian authored
* ci: Ignore l2geth coverage reports * ci: Upload coverage reports in js-lint-test Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Matthew Slipper authored
* op-node: Fix OPB-10 Fixes OPB-10: No Checks for Deposit Transaction Type When Calling `L1InfoDepositTxData()`. This PR adds a check in `blockToBatch` that checks the type of the first transaction in the block, and returns an error if it isn't a deposit transaction. * goimports Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Mark Tyneway authored
The ownable upgradable modifier was not used anywhere in the contract. The erc20 factory does not follow that pattern. This change simplifies things by moving values to immutables instead of being in storage. This is a cleanup PR before migrating these contracts to `contracts-bedrock`. Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Mark Tyneway authored
* contracts-bedrock: add semver to erc20 factory * op-bindings: regenerate Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Matthew Slipper authored
-
Matthew Slipper authored
-
Matthew Slipper authored
-
Matthew Slipper authored
-
Matthew Slipper authored
-
Matthew Slipper authored
* proxyd: Add batch size metric and configurable max The max batch size will be overwritten if it is over `MaxBatchRPCCallsHardLimit`. Builds on https://github.com/ethereum-optimism/optimism/pull/3544. * changeset * fix lint * fix test
-
Matthew Slipper authored
* proxyd: Add customizable whitelist error message Alchemy is asking for this so that we can include their affiliate link. * add missing test case * fix error message * goimports
-