Skip to content

N
nebula
Switch branch/tag
  1. 04 Oct, 2022 6 commits
    • Mark Tyneway's avatar
      sdk: add hh task for finalizing withdrawal (#3638) · f39853ef
      Mark Tyneway authored 
      Now we no longer need to use one off scripts for testing this kind
of thing. The hh task will check to see the status of a transaction
hash and then finalize the withdrawal on L1 if the message status
is ready for relay. It does this by creating a `CrossChainMessenger`.
Co-authored-by: default avatarmergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
      f39853ef
    • protolambda's avatar
      op-node: split start of payload building and confirmation of payload (#3641) · b0b8b4cf
      protolambda authored 
      Co-authored-by: default avatarmergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
      b0b8b4cf
    • Joshua Gutow's avatar
      op-node: Remove BlockIDRange (#3640) · 0eaae3bf
      Joshua Gutow authored 
      This function was not being used and could be safely removed.
Co-authored-by: default avatarmergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
      0eaae3bf
    • Maurelian's avatar
      op-node: Return error on big chain id (#3620) · 1bcd11e9
      Maurelian authored 
      Co-authored-by: default avatarmergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
      1bcd11e9
    • Matthew Slipper's avatar
      op-node: Integrate PollingClient with op-node (#3630) · 3ae11e87
      Matthew Slipper authored 
      Integrates the HTTP PollingClient with the op-node. To do this, I needed to change the RPC interface to return an `ethereum.Subscription` object rather than a concrete *rpc.ClientSubscription instance. I also introduced a new method to return the correct `client.RPC` implementation based on the user's chosen RPC URL.

Lastly, I added an additional CircleCI job to run all end-to-end tests against an HTTP-based RPC endpoint to prevent issues from arising in the future.
      3ae11e87
    • Matthew Slipper's avatar
      op-node: Add wrapper to support EthSubscribe in HTTP clients (#3629) · 775d9ff9
      Matthew Slipper authored 
      The Geth RPC client does not support subscriptions for HTTP endpoints. As a result, users who set an HTTP endpoint for the op-node were unable to sync since the driver never got any L1 head updates. This PR adds a wrapper around `client.RPC` that makes `newHeads` subscriptions work over HTTP. It does this by layering a notifications system that mimicks what Geth does under the hood on top of an HTTP polling loop.

The interface is the same as the one exposed by the raw RPC client. I tried my best to match Geth's subscription semantics, including:

- Closing the client causes all subscribers to get a nil error on their error channels.
- Unsubscribing closes each subscriber's error channel.
- Calling `Unsubscribe` multiple times is safe.

The poll rate is configurable. It default to 250ms, which should be fine for both L1 and L2. I tried at first to use Geth's underlying libraries, but found that it was impossible to do so without making changes to Geth itself to export more fields. This system is also simpler, and gives us room to instrument the polling loop in the future.

The wrapper is not integrated with the rest of the system in this PR. I'll stack those changes on top of this one so we can review this in isolation.

Totally open to different solutions here - marking as draft to reflect the fact that if there's a better way to do this, I'm happy o close this + the dependent PRs and go a different route.

Meta:

- Fixes ENG-2490
      775d9ff9
  3. 03 Oct, 2022 2 commits
  5. 01 Oct, 2022 8 commits
  7. 30 Sep, 2022 4 commits
  9. 29 Sep, 2022 20 commits