-
Mark Tyneway authored
* contracts-bedrock: cleanup interop predeploys Small refactor to the interop predeploys to reuse existing code. It was determined safe to use the `SafeCall` library, so we opt to use that instead of duplicating code. No tests are added since existing test coverage ensures that these calls happen as expected. A manual mutation test where the value was not passed through was performed and failing tests were observed. The `SafeCall` library was previously pinned to `0.8.15` due to the "call with min gas" semantics, it may be possible that a new compiler version could emit code that doesn't act how `0.8.15` acts, but the whole gas introspection thing is an anti pattern and we have invariant tests that would catch this if we modified the solc version used by `OptimismPortal`. We know to never follow this pattern again, ie `hasMinGas` or `callWithMinGas` should never be used again in the codebase and should be deleted at some point once we get rid of the whole min gas limit semantics. * lint: fix * semver-lock: update
1bfd7e9b
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
chain-mon | ||
contracts-bedrock | ||
devnet-tasks |