• Mark Tyneway's avatar
    contracts-bedrock: cleanup interop predeploys (#10995) · 1bfd7e9b
    Mark Tyneway authored
    * contracts-bedrock: cleanup interop predeploys
    
    Small refactor to the interop predeploys to reuse existing code.
    It was determined safe to use the `SafeCall` library, so we opt
    to use that instead of duplicating code. No tests are added since
    existing test coverage ensures that these calls happen as expected.
    A manual mutation test where the value was not passed through was
    performed and failing tests were observed.
    
    The `SafeCall` library was previously pinned to `0.8.15` due to the
    "call with min gas" semantics, it may be possible that a new compiler
    version could emit code that doesn't act how `0.8.15` acts, but the
    whole gas introspection thing is an anti pattern and we have invariant
    tests that would catch this if we modified the solc version used
    by `OptimismPortal`. We know to never follow this pattern again,
    ie `hasMinGas` or `callWithMinGas` should never be used again
    in the codebase and should be deleted at some point once we get
    rid of the whole min gas limit semantics.
    
    * lint: fix
    
    * semver-lock: update
    1bfd7e9b
Name
Last commit
Last update
.changeset Loading commit data...
.circleci Loading commit data...
.github Loading commit data...
.vscode Loading commit data...
bedrock-devnet Loading commit data...
cannon Loading commit data...
docs Loading commit data...
op-batcher Loading commit data...
op-bootnode Loading commit data...
op-chain-ops Loading commit data...
op-challenger Loading commit data...
op-conductor Loading commit data...
op-dispute-mon Loading commit data...
op-e2e Loading commit data...
op-heartbeat Loading commit data...
op-node Loading commit data...
op-plasma Loading commit data...
op-preimage Loading commit data...
op-program Loading commit data...
op-proposer Loading commit data...
op-service Loading commit data...
op-supervisor Loading commit data...
op-ufm Loading commit data...
op-wheel Loading commit data...
ops Loading commit data...
ops-bedrock Loading commit data...
packages Loading commit data...
proxyd Loading commit data...
specs Loading commit data...
.coderabbit.yml Loading commit data...
.dockerignore Loading commit data...
.editorconfig Loading commit data...
.envrc.example Loading commit data...
.eslintrc.js Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gitmodules Loading commit data...
.npmrc Loading commit data...
.nvmrc Loading commit data...
.pnpmfile.cjs Loading commit data...
.prettierrc.js Loading commit data...
.semgrepignore Loading commit data...
.shellcheckrc Loading commit data...
.snyk Loading commit data...
CITATION.cff Loading commit data...
CONTRIBUTING.md Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
SECURITY.md Loading commit data...
cloudbuild.yaml Loading commit data...
codecov.yml Loading commit data...
docker-bake.hcl Loading commit data...
go.mod Loading commit data...
go.sum Loading commit data...
nx.json Loading commit data...
package.json Loading commit data...
pnpm-lock.yaml Loading commit data...
pnpm-workspace.yaml Loading commit data...
versions.json Loading commit data...