• Jason Yellick's avatar
    op-e2e: Fix bug in TestWithdrawals · 769fe00f
    Jason Yellick authored
    The existing TestWithdrawals test attempts to assert that the total fees
    of the prove and finalize transactions are accounted for in the L1
    balance.  But, it re-uses the `calcGasFees` function and passes in the
    `GasTipCap` and the `GasFeeCap` from the L2 transaction, not from the
    actual L1 transactions.  In the event that the gas fee differs on the L2
    from the L1, then the test will fail.
    
    To keep the diff small, this change simply multiplies the GasUsed and
    `EffectiveGasPrice` from the receipts.  This could be moved into a
    helper function like `calcGasFees`.  Using the `EffectiveGasPrice` seems
    just as good or better than relying on the parameters of the original
    transaction, and could be similarly utilized higher in the test for the
    L2 fees.  If we really want to get the parameters from the tx, then
    `ProveAndFinalizeWithdrawal` would need to be modified to return the
    txes.
    769fe00f
Name
Last commit
Last update
.changeset Loading commit data...
.circleci Loading commit data...
.github Loading commit data...
.husky Loading commit data...
.vscode Loading commit data...
.yarn/releases Loading commit data...
batch-submitter Loading commit data...
bedrock-devnet Loading commit data...
bss-core Loading commit data...
docs/op-stack Loading commit data...
endpoint-monitor Loading commit data...
gas-oracle Loading commit data...
indexer Loading commit data...
infra/op-replica Loading commit data...
l2geth Loading commit data...
l2geth-exporter Loading commit data...
op-batcher Loading commit data...
op-bindings Loading commit data...
op-bootnode Loading commit data...
op-chain-ops Loading commit data...
op-challenger Loading commit data...
op-e2e Loading commit data...
op-exporter Loading commit data...
op-heartbeat Loading commit data...
op-node Loading commit data...
op-program Loading commit data...
op-proposer Loading commit data...
op-service Loading commit data...
op-signer Loading commit data...
op-wheel Loading commit data...
ops Loading commit data...
ops-bedrock Loading commit data...
packages Loading commit data...
patches Loading commit data...
proxyd Loading commit data...
specs Loading commit data...
technical-documents Loading commit data...
.dockerignore Loading commit data...
.editorconfig Loading commit data...
.eslintrc.js Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gitmodules Loading commit data...
.markdownlint.json Loading commit data...
.nvmrc Loading commit data...
.prettierrc.js Loading commit data...
.semgrepignore Loading commit data...
.snyk Loading commit data...
.yarnrc Loading commit data...
CITATION.cff Loading commit data...
CONTRIBUTING.md Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
SECURITY.md Loading commit data...
cloudbuild.yaml Loading commit data...
codecov.yml Loading commit data...
go.mod Loading commit data...
go.sum Loading commit data...
lerna.json Loading commit data...
package.json Loading commit data...
tsconfig.json Loading commit data...
yarn.lock Loading commit data...