• Jason Yellick's avatar
    op-e2e: allow external processes to skip tests · 955efc18
    Jason Yellick authored
    Certain existing e2e tests are not adaptable to external binary testing.
    Although it's better for tests to be able to execute against both an
    in-process geth or an extra-process arbitrary ethereum client, the
    current state of the tests does not allow this in all cases.
    
    This change allows for external binaries to specify a set of test names
    to be skipped, including a skip message for why they are skipped.  The
    set is specified as a JSON map in a new optional file `test_parms.json`
    which can be created in the external adapter folder.
    
    Prior to this change, the external process was indicated only by a path
    to a `shim` binary.  This change now instead asks that the external test
    be specified by directory, wherein a `shim` binary must exist, and this
    new file `test_params.json` may exist.  Other approaches are of course
    possible, such as allowing the JSON file to be specified via a command
    flag, but it seemed better to simply establish a convention for expected
    paths for these external tests to satisfy.
    
    There actually is a single test which already has a `t.Skip()` based on
    the presence of the external L2 flag.  I'd though these were all
    removed in the last PR, but this one actually is required for an
    external op-geth.  So, this skip has been converted to the new method
    and acts as a nice test that it is working.
    955efc18
Name
Last commit
Last update
.changeset Loading commit data...
.circleci Loading commit data...
.github Loading commit data...
.husky Loading commit data...
.vscode Loading commit data...
bedrock-devnet Loading commit data...
cannon Loading commit data...
docs Loading commit data...
endpoint-monitor Loading commit data...
indexer Loading commit data...
op-batcher Loading commit data...
op-bindings Loading commit data...
op-bootnode Loading commit data...
op-chain-ops Loading commit data...
op-challenger Loading commit data...
op-e2e Loading commit data...
op-exporter Loading commit data...
op-heartbeat Loading commit data...
op-node Loading commit data...
op-preimage Loading commit data...
op-program Loading commit data...
op-proposer Loading commit data...
op-service Loading commit data...
op-signer Loading commit data...
op-ufm Loading commit data...
op-wheel Loading commit data...
ops Loading commit data...
ops-bedrock Loading commit data...
packages Loading commit data...
patches Loading commit data...
proxyd Loading commit data...
specs Loading commit data...
.abigenrc Loading commit data...
.dockerignore Loading commit data...
.editorconfig Loading commit data...
.eslintrc.js Loading commit data...
.foundryrc Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gitmodules Loading commit data...
.markdownlint.json Loading commit data...
.npmrc Loading commit data...
.nvmrc Loading commit data...
.pnpmfile.cjs Loading commit data...
.prettierrc.js Loading commit data...
.semgrepignore Loading commit data...
.snyk Loading commit data...
CITATION.cff Loading commit data...
CONTRIBUTING.md Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
SECURITY.md Loading commit data...
cloudbuild.yaml Loading commit data...
codecov.yml Loading commit data...
go.mod Loading commit data...
go.sum Loading commit data...
lerna.json Loading commit data...
nx.json Loading commit data...
package.json Loading commit data...
pnpm-lock.yaml Loading commit data...
pnpm-workspace.yaml Loading commit data...
tsconfig.json Loading commit data...