• Maurelian's avatar
    contracts-bedrock: Fix enforcement of delay on DelayedVetoable (#9050) · 9a59811f
    Maurelian authored
    * contracts-bedrock: Fix enforcement of delay on DelayedVetoable
    
    Prior to this change, a bug existed in the DelayedVetoable contract,
    which resulted in anyone being able to execute a transaction as soon as
    it had been initiated.
    
    A factor in this was an edge case behavior in foundry's vm.expectRevert
    which flips the success value of a low level call. This commit also
    introduces a new convention when expectRevert is used on low level calls
    to make this edge case behavior more evident.
    
    * contracts-bedrock: Add revertsAsExpected to Style Guide
    
    * contracts: Fix compiler warnings
    
    * bindings and semver
    9a59811f
Name
Last commit
Last update
..
deploy-config Loading commit data...
deployments/mainnet Loading commit data...
invariant-docs Loading commit data...
lib Loading commit data...
periphery-deploy-config Loading commit data...
scripts Loading commit data...
snapshots Loading commit data...
src Loading commit data...
test Loading commit data...
.eslintignore Loading commit data...
.eslintrc.js Loading commit data...
.gas-snapshot Loading commit data...
.gitignore Loading commit data...
.npmignore Loading commit data...
CHANGELOG.md Loading commit data...
CONTRIBUTING.md Loading commit data...
LICENSE Loading commit data...
README.md Loading commit data...
STYLE_GUIDE.md Loading commit data...
foundry.toml Loading commit data...
package.json Loading commit data...
semver-lock.json Loading commit data...
slither-report.json Loading commit data...
slither.config.json Loading commit data...
tsconfig.build.json Loading commit data...
tsconfig.json Loading commit data...