• Joshua Gutow's avatar
    op-service: Return ethereum.NotFound on 404 (#10210) · 3f297b65
    Joshua Gutow authored
    The beacon API returns HTTP Status Not Found (Code 404) when it is
    not able to find the resource. This should be disambiguated from
    transient errors. This commit has the HTTP client return the
    ethereum.NotFound error when the status code is 404. This is a
    commonly used sentinel error and the BlobDataSource was expecting
    this error.
    
    This will fix a bug that occurs when a block is reorged out after
    it is opened in derivation, but before blobs are fetched. The blob
    fetcher assumed that all errors where transient and would try to
    keep fetching the data even though the status code reported it as
    not found. This will return the right sentinel error to force a
    reset and exit this loop.
    
    I have added a unit test in op-e2e and confirmed that the test does
    not pass without this fix.
    3f297b65
Name
Last commit
Last update
..
cliapp Loading commit data...
client Loading commit data...
clock Loading commit data...
crypto Loading commit data...
dial Loading commit data...
enum Loading commit data...
eth Loading commit data...
flags Loading commit data...
httputil Loading commit data...
ioutil Loading commit data...
jsonutil Loading commit data...
log Loading commit data...
metrics Loading commit data...
opio Loading commit data...
oppprof Loading commit data...
rethdb-reader Loading commit data...
retry Loading commit data...
rpc Loading commit data...
signer Loading commit data...
solabi Loading commit data...
sources Loading commit data...
tasks Loading commit data...
testlog Loading commit data...
testutils Loading commit data...
tls Loading commit data...
txmgr Loading commit data...
Makefile Loading commit data...
pin.go Loading commit data...
util.go Loading commit data...
util_test.go Loading commit data...
version.go Loading commit data...
version_test.go Loading commit data...