• Mark Tyneway's avatar
    contracts-bedrock: cleanup tests · dc37fa23
    Mark Tyneway authored
    Use the `vm.expectEmit(address)` over the variant that uses all of the
    booleans when they are all true. This reduces code and makes it easier
    to read for reviewers. Each boolean means if the log topic/data should
    be compared. Generally, we want them to all be true which is why the
    short hand of just expecting it to come from an address exists, that
    assumes all of the values are true and asserts it emits from the
    address. We should always follow this style of `vm.expectEmit` unless
    there is a good reason not to, ie its not known that a particular topic
    will be or it is too complex to compute it. If this is the case then
    perhaps the smart contract is too complex and the architecture needs to
    be thought about more.
    dc37fa23
Name
Last commit
Last update
..
deploy-config Loading commit data...
deployments Loading commit data...
invariant-docs Loading commit data...
lib Loading commit data...
periphery-deploy-config Loading commit data...
scripts Loading commit data...
snapshots Loading commit data...
src Loading commit data...
test Loading commit data...
.eslintignore Loading commit data...
.eslintrc.js Loading commit data...
.gas-snapshot Loading commit data...
.gitignore Loading commit data...
.npmignore Loading commit data...
CHANGELOG.md Loading commit data...
CONTRIBUTING.md Loading commit data...
LICENSE Loading commit data...
README.md Loading commit data...
STYLE_GUIDE.md Loading commit data...
foundry.toml Loading commit data...
package.json Loading commit data...
semver-lock.json Loading commit data...
slither-report.json Loading commit data...
slither.config.json Loading commit data...
tsconfig.build.json Loading commit data...
tsconfig.json Loading commit data...