Commit 0d5bc753 authored by lynn's avatar lynn Committed by Connor McEwen

fix: Web 1561 logging event for clicking on explore banner toast + WEB-1543 ...

fix: Web 1561 logging event for clicking on explore banner toast +  WEB-1543  [Explore Banner] String should be sentence case (#4899)

* explore banner changes

* remove console log

* oops
parent 79507a4b
...@@ -8,6 +8,7 @@ export enum EventName { ...@@ -8,6 +8,7 @@ export enum EventName {
APP_LOADED = 'Application Loaded', APP_LOADED = 'Application Loaded',
APPROVE_TOKEN_TXN_SUBMITTED = 'Approve Token Transaction Submitted', APPROVE_TOKEN_TXN_SUBMITTED = 'Approve Token Transaction Submitted',
CONNECT_WALLET_BUTTON_CLICKED = 'Connect Wallet Button Clicked', CONNECT_WALLET_BUTTON_CLICKED = 'Connect Wallet Button Clicked',
EXPLORE_BANNER_CLICKED = 'Explore Banner Clicked',
EXPLORE_SEARCH_SELECTED = 'Explore Search Selected', EXPLORE_SEARCH_SELECTED = 'Explore Search Selected',
EXPLORE_TOKEN_ROW_CLICKED = 'Explore Token Row Clicked', EXPLORE_TOKEN_ROW_CLICKED = 'Explore Token Row Clicked',
PAGE_VIEWED = 'Page Viewed', PAGE_VIEWED = 'Page Viewed',
...@@ -107,6 +108,7 @@ export enum ElementName { ...@@ -107,6 +108,7 @@ export enum ElementName {
COMMON_BASES_CURRENCY_BUTTON = 'common-bases-currency-button', COMMON_BASES_CURRENCY_BUTTON = 'common-bases-currency-button',
CONFIRM_SWAP_BUTTON = 'confirm-swap-or-send', CONFIRM_SWAP_BUTTON = 'confirm-swap-or-send',
CONNECT_WALLET_BUTTON = 'connect-wallet-button', CONNECT_WALLET_BUTTON = 'connect-wallet-button',
EXPLORE_BANNER = 'explore-banner',
EXPLORE_SEARCH_INPUT = 'explore_search_input', EXPLORE_SEARCH_INPUT = 'explore_search_input',
IMPORT_TOKEN_BUTTON = 'import-token-button', IMPORT_TOKEN_BUTTON = 'import-token-button',
MAX_TOKEN_AMOUNT_BUTTON = 'max-token-amount-button', MAX_TOKEN_AMOUNT_BUTTON = 'max-token-amount-button',
......
...@@ -430,7 +430,7 @@ export function HeaderRow() { ...@@ -430,7 +430,7 @@ export function HeaderRow() {
header={true} header={true}
favorited={null} favorited={null}
listNumber="#" listNumber="#"
tokenInfo={<Trans>Token Name</Trans>} tokenInfo={<Trans>Token name</Trans>}
price={<HeaderCell category={TokenSortMethod.PRICE} sortable />} price={<HeaderCell category={TokenSortMethod.PRICE} sortable />}
percentChange={<HeaderCell category={TokenSortMethod.PERCENT_CHANGE} sortable />} percentChange={<HeaderCell category={TokenSortMethod.PERCENT_CHANGE} sortable />}
marketCap={<HeaderCell category={TokenSortMethod.TOTAL_VALUE_LOCKED} sortable />} marketCap={<HeaderCell category={TokenSortMethod.TOTAL_VALUE_LOCKED} sortable />}
......
import { Trans } from '@lingui/macro' import { Trans } from '@lingui/macro'
import { ElementName, Event, EventName } from 'analytics/constants'
import { TraceEvent } from 'analytics/TraceEvent'
import { X } from 'react-feather' import { X } from 'react-feather'
import { Link } from 'react-router-dom' import { Link } from 'react-router-dom'
import { useShowTokensPromoBanner } from 'state/user/hooks' import { useShowTokensPromoBanner } from 'state/user/hooks'
...@@ -64,26 +66,28 @@ export default function TokensBanner() { ...@@ -64,26 +66,28 @@ export default function TokensBanner() {
} }
return ( return (
<PopupContainer show={showTokensPromoBanner} to="/tokens" onClick={closeBanner}> <TraceEvent events={[Event.onClick]} name={EventName.EXPLORE_BANNER_CLICKED} element={ElementName.EXPLORE_BANNER}>
<Header> <PopupContainer show={showTokensPromoBanner} to="/tokens" onClick={closeBanner}>
<HeaderText> <Header>
<Trans>Explore Top Tokens on Uniswap</Trans> <HeaderText>
</HeaderText> <Trans>Explore top tokens on Uniswap</Trans>
<X </HeaderText>
size={20} <X
color={theme.textSecondary} size={20}
onClick={(e) => { color={theme.textSecondary}
e.preventDefault() onClick={(e) => {
e.stopPropagation() e.preventDefault()
closeBanner() e.stopPropagation()
}} closeBanner()
style={{ cursor: 'pointer' }} }}
/> style={{ cursor: 'pointer' }}
</Header> />
</Header>
<Description> <Description>
<Trans>Sort and filter assets across networks on the new Tokens page.</Trans> <Trans>Sort and filter assets across networks on the new Tokens page.</Trans>
</Description> </Description>
</PopupContainer> </PopupContainer>
</TraceEvent>
) )
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment