Commit 149b18f0 authored by eddie's avatar eddie Committed by GitHub

fix: about footer link weights (#5898)

parent 52a43f3d
import { TraceEvent } from '@uniswap/analytics' import { TraceEvent } from '@uniswap/analytics'
import { BrowserEvent, InterfaceElementName, SharedEventName } from '@uniswap/analytics-events' import { BrowserEvent, InterfaceElementName, SharedEventName } from '@uniswap/analytics-events'
import { Link } from 'react-router-dom'
import { useIsDarkMode } from 'state/user/hooks' import { useIsDarkMode } from 'state/user/hooks'
import styled from 'styled-components/macro' import styled from 'styled-components/macro'
import { BREAKPOINTS, ExternalLink } from 'theme' import { BREAKPOINTS, ExternalLink, StyledRouterLink } from 'theme'
import { DiscordIcon, GithubIcon, TwitterIcon } from './Icons' import { DiscordIcon, GithubIcon, TwitterIcon } from './Icons'
import darkUnicornImgSrc from './images/unicornEmbossDark.png' import darkUnicornImgSrc from './images/unicornEmbossDark.png'
...@@ -97,14 +96,10 @@ const ExternalTextLink = styled(ExternalLink)` ...@@ -97,14 +96,10 @@ const ExternalTextLink = styled(ExternalLink)`
color: ${({ theme }) => theme.textSecondary}; color: ${({ theme }) => theme.textSecondary};
` `
const TextLink = styled(Link)` const TextLink = styled(StyledRouterLink)`
font-size: 16px; font-size: 16px;
line-height: 20px; line-height: 20px;
color: ${({ theme }) => theme.textSecondary}; color: ${({ theme }) => theme.textSecondary};
text-decoration: none;
&:hover {
text-decoration: underline;
}
` `
const Copyright = styled.span` const Copyright = styled.span`
...@@ -158,15 +153,9 @@ export const AboutFooter = () => { ...@@ -158,15 +153,9 @@ export const AboutFooter = () => {
</LinkGroup> </LinkGroup>
<LinkGroup> <LinkGroup>
<LinkGroupTitle>Protocol</LinkGroupTitle> <LinkGroupTitle>Protocol</LinkGroupTitle>
<ExternalTextLink href="https://uniswap.org/community" target="_blank" rel="noopener noreferrer"> <ExternalTextLink href="https://uniswap.org/community">Community</ExternalTextLink>
Community <ExternalTextLink href="https://uniswap.org/governance">Governance</ExternalTextLink>
</ExternalTextLink> <ExternalTextLink href="https://uniswap.org/developers">Developers</ExternalTextLink>
<ExternalTextLink href="https://uniswap.org/governance" target="_blank" rel="noopener noreferrer">
Governance
</ExternalTextLink>
<ExternalTextLink href="https://uniswap.org/developers" target="_blank" rel="noopener noreferrer">
Developers
</ExternalTextLink>
</LinkGroup> </LinkGroup>
<LinkGroup> <LinkGroup>
<LinkGroupTitle>Company</LinkGroupTitle> <LinkGroupTitle>Company</LinkGroupTitle>
...@@ -175,18 +164,14 @@ export const AboutFooter = () => { ...@@ -175,18 +164,14 @@ export const AboutFooter = () => {
name={SharedEventName.ELEMENT_CLICKED} name={SharedEventName.ELEMENT_CLICKED}
element={InterfaceElementName.CAREERS_LINK} element={InterfaceElementName.CAREERS_LINK}
> >
<ExternalTextLink href="https://boards.greenhouse.io/uniswaplabs" target="_blank" rel="noopener noreferrer"> <ExternalTextLink href="https://boards.greenhouse.io/uniswaplabs">Careers</ExternalTextLink>
Careers
</ExternalTextLink>
</TraceEvent> </TraceEvent>
<TraceEvent <TraceEvent
events={[BrowserEvent.onClick]} events={[BrowserEvent.onClick]}
name={SharedEventName.ELEMENT_CLICKED} name={SharedEventName.ELEMENT_CLICKED}
element={InterfaceElementName.BLOG_LINK} element={InterfaceElementName.BLOG_LINK}
> >
<ExternalTextLink href="https://uniswap.org/blog" target="_blank" rel="noopener noreferrer"> <ExternalTextLink href="https://uniswap.org/blog">Blog</ExternalTextLink>
Blog
</ExternalTextLink>
</TraceEvent> </TraceEvent>
</LinkGroup> </LinkGroup>
<LinkGroup> <LinkGroup>
...@@ -209,9 +194,7 @@ export const AboutFooter = () => { ...@@ -209,9 +194,7 @@ export const AboutFooter = () => {
name={SharedEventName.ELEMENT_CLICKED} name={SharedEventName.ELEMENT_CLICKED}
element={InterfaceElementName.SUPPORT_LINK} element={InterfaceElementName.SUPPORT_LINK}
> >
<ExternalTextLink href="https://support.uniswap.org/hc/en-us" target="_blank" rel="noopener noreferrer"> <ExternalTextLink href="https://support.uniswap.org/hc/en-us">Help Center</ExternalTextLink>
Help Center
</ExternalTextLink>
</TraceEvent> </TraceEvent>
</LinkGroup> </LinkGroup>
</FooterLinks> </FooterLinks>
......
...@@ -182,6 +182,12 @@ const StyledLink = styled.a` ...@@ -182,6 +182,12 @@ const StyledLink = styled.a`
${ClickableStyle} ${ClickableStyle}
${LinkStyle} ${LinkStyle}
` `
export const StyledRouterLink = styled(Link)`
${ClickableStyle}
${LinkStyle}
`
/** /**
* Outbound link that handles firing google analytics events * Outbound link that handles firing google analytics events
*/ */
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment