refactor: keep constants insular (#6411)

src/constants/addresses.ts

 import { FACTORY_ADDRESS as V2_FACTORY_ADDRESS } from '@uniswap/v2-sdk'
 import { FACTORY_ADDRESS as V3_FACTORY_ADDRESS } from '@uniswap/v3-sdk'
-import { SupportedChainId } from 'constants/chains'
 
-import { constructSameAddressMap } from '../utils/constructSameAddressMap'
+import { SupportedChainId } from './chains'
 
 type AddressMap = { [chainId: number]: string }
 
+const DEFAULT_NETWORKS = [SupportedChainId.MAINNET, SupportedChainId.GOERLI]
+
+function constructSameAddressMap(address: string, additionalNetworks: SupportedChainId[] = []): AddressMap {
+  return DEFAULT_NETWORKS.concat(additionalNetworks).reduce<AddressMap>((memo, chainId) => {
+    memo[chainId] = address
+    return memo
+  }, {})
+}
+
 export const UNI_ADDRESS: AddressMap = constructSameAddressMap('0x1f9840a85d5aF5bf1D1762F925BDADdC4201F984')
 
 export const UNISWAP_NFT_AIRDROP_CLAIM_ADDRESS = '0x8B799381ac40b838BBA4131ffB26197C432AFe78'

src/constants/chainInfo.ts

@@ -11,11 +11,10 @@ import optimismSquareLogoUrl from 'assets/svg/optimism_square_logo.svg'
 import optimismLogoUrl from 'assets/svg/optimistic_ethereum.svg'
 import polygonSquareLogoUrl from 'assets/svg/polygon_square_logo.svg'
 import polygonMaticLogo from 'assets/svg/polygon-matic-logo.svg'
-import { SupportedChainId } from 'constants/chains'
 import ms from 'ms.macro'
 import { darkTheme } from 'theme/colors'
 
-import { SupportedL1ChainId, SupportedL2ChainId } from './chains'
+import { SupportedChainId, SupportedL1ChainId, SupportedL2ChainId } from './chains'
 import { ARBITRUM_LIST, CELO_LIST, OPTIMISM_LIST, PLASMA_BNB_LIST } from './lists'
 
 export const AVERAGE_L1_BLOCK_TIME = ms`12s`

src/constants/chains.test.ts

 import { SupportedChainId as SdkSupportedChainId } from '@uniswap/sdk-core'
-import { SupportedChainId } from 'constants/chains'
 
-import { ALL_SUPPORTED_CHAIN_IDS } from './chains'
+import { ALL_SUPPORTED_CHAIN_IDS, SupportedChainId } from './chains'
 
 describe('ChainIds', () => {
   describe('SupportedChainId', () => {

src/constants/governance.ts

-import { SupportedChainId } from 'constants/chains'
-
 import {
   GOVERNANCE_ALPHA_V0_ADDRESSES,
   GOVERNANCE_ALPHA_V1_ADDRESSES,
@@ -7,6 +5,7 @@ import {
   TIMELOCK_ADDRESS,
   UNI_ADDRESS,
 } from './addresses'
+import { SupportedChainId } from './chains'
 
 export const COMMON_CONTRACT_NAMES: Record<number, { [address: string]: string }> = {
   [SupportedChainId.MAINNET]: {

src/utils/constructSameAddressMap.ts

-import { SupportedChainId } from 'constants/chains'
-
-const DEFAULT_NETWORKS = [SupportedChainId.MAINNET, SupportedChainId.GOERLI]
-
-export function constructSameAddressMap<T extends string>(
-  address: T,
-  additionalNetworks: SupportedChainId[] = []
-): { [chainId: number]: T } {
-  return DEFAULT_NETWORKS.concat(additionalNetworks).reduce<{ [chainId: number]: T }>((memo, chainId) => {
-    memo[chainId] = address
-    return memo
-  }, {})
-}