Commit 21649967 authored by Charles Bachmeier's avatar Charles Bachmeier Committed by GitHub

refactor: rename phase1flag to nftflag (#4414)

* rename phase1flag to nftflag

* add new flag file
Co-authored-by: default avatarCharlie <charlie@uniswap.org>
parent 3f40f60c
import { FeatureFlag, featureFlagSettings, useUpdateFlag } from 'featureFlags' import { FeatureFlag, featureFlagSettings, useUpdateFlag } from 'featureFlags'
import { NavBarVariant, useNavBarFlag } from 'featureFlags/flags/navBar' import { NavBarVariant, useNavBarFlag } from 'featureFlags/flags/navBar'
import { Phase1Variant, usePhase1Flag } from 'featureFlags/flags/phase1' import { NftVariant, useNftFlag } from 'featureFlags/flags/nft'
import { RedesignVariant, useRedesignFlag } from 'featureFlags/flags/redesign' import { RedesignVariant, useRedesignFlag } from 'featureFlags/flags/redesign'
import { TokensVariant, useTokensFlag } from 'featureFlags/flags/tokens' import { TokensVariant, useTokensFlag } from 'featureFlags/flags/tokens'
import { TokenSafetyVariant, useTokenSafetyFlag } from 'featureFlags/flags/tokenSafety' import { TokenSafetyVariant, useTokenSafetyFlag } from 'featureFlags/flags/tokenSafety'
...@@ -166,10 +166,10 @@ export default function FeatureFlagModal() { ...@@ -166,10 +166,10 @@ export default function FeatureFlagModal() {
</Header> </Header>
<FlagGroupName>Phase 1</FlagGroupName> <FlagGroupName>Phase 1</FlagGroupName>
<FeatureFlagOption <FeatureFlagOption
variants={Object.values(Phase1Variant)} variants={Object.values(NftVariant)}
value={usePhase1Flag()} value={useNftFlag()}
featureFlag={FeatureFlag.phase1} featureFlag={FeatureFlag.nft}
label="All Phase 1 changes (nft features)." label="NFTs"
/> />
<FlagGroupName>Phase 0</FlagGroupName> <FlagGroupName>Phase 0</FlagGroupName>
<FeatureFlagOption <FeatureFlagOption
......
import FeatureFlagModal from 'components/FeatureFlagModal/FeatureFlagModal' import FeatureFlagModal from 'components/FeatureFlagModal/FeatureFlagModal'
import { PrivacyPolicyModal } from 'components/PrivacyPolicy' import { PrivacyPolicyModal } from 'components/PrivacyPolicy'
import { Phase1Variant, usePhase1Flag } from 'featureFlags/flags/phase1' import { NftVariant, useNftFlag } from 'featureFlags/flags/nft'
import { Box } from 'nft/components/Box' import { Box } from 'nft/components/Box'
import { Portal } from 'nft/components/common/Portal' import { Portal } from 'nft/components/common/Portal'
import { Column, Row } from 'nft/components/Flex' import { Column, Row } from 'nft/components/Flex'
...@@ -135,7 +135,7 @@ export const MobileSideBar = () => { ...@@ -135,7 +135,7 @@ export const MobileSideBar = () => {
const togglePrivacyPolicy = useTogglePrivacyPolicy() const togglePrivacyPolicy = useTogglePrivacyPolicy()
const openFeatureFlagsModal = useToggleModal(ApplicationModal.FEATURE_FLAGS) const openFeatureFlagsModal = useToggleModal(ApplicationModal.FEATURE_FLAGS)
const { pathname } = useLocation() const { pathname } = useLocation()
const phase1Flag = usePhase1Flag() const nftFlag = useNftFlag()
const isPoolActive = const isPoolActive =
pathname.startsWith('/pool') || pathname.startsWith('/pool') ||
pathname.startsWith('/add') || pathname.startsWith('/add') ||
...@@ -164,7 +164,7 @@ export const MobileSideBar = () => { ...@@ -164,7 +164,7 @@ export const MobileSideBar = () => {
<NavLinkRow href="/tokens" close={toggleOpen} isActive={pathname.startsWith('/tokens')}> <NavLinkRow href="/tokens" close={toggleOpen} isActive={pathname.startsWith('/tokens')}>
Tokens Tokens
</NavLinkRow> </NavLinkRow>
{phase1Flag === Phase1Variant.Enabled && ( {nftFlag === NftVariant.Enabled && (
<NavLinkRow href="/nfts" close={toggleOpen} isActive={pathname.startsWith('/nfts')}> <NavLinkRow href="/nfts" close={toggleOpen} isActive={pathname.startsWith('/nfts')}>
NFTs NFTs
</NavLinkRow> </NavLinkRow>
......
import Web3Status from 'components/Web3Status' import Web3Status from 'components/Web3Status'
import { Phase1Variant, usePhase1Flag } from 'featureFlags/flags/phase1' import { NftVariant, useNftFlag } from 'featureFlags/flags/nft'
import { useWindowSize } from 'hooks/useWindowSize' import { useWindowSize } from 'hooks/useWindowSize'
import { ReactNode } from 'react' import { ReactNode } from 'react'
import { NavLink, NavLinkProps, useLocation } from 'react-router-dom' import { NavLink, NavLinkProps, useLocation } from 'react-router-dom'
...@@ -63,7 +63,7 @@ const MobileNavbar = () => { ...@@ -63,7 +63,7 @@ const MobileNavbar = () => {
const Navbar = () => { const Navbar = () => {
const { width: windowWidth } = useWindowSize() const { width: windowWidth } = useWindowSize()
const { pathname } = useLocation() const { pathname } = useLocation()
const phase1Flag = usePhase1Flag() const nftFlag = useNftFlag()
if (windowWidth && windowWidth < breakpoints.desktopXl) { if (windowWidth && windowWidth < breakpoints.desktopXl) {
return <MobileNavbar /> return <MobileNavbar />
...@@ -90,7 +90,7 @@ const Navbar = () => { ...@@ -90,7 +90,7 @@ const Navbar = () => {
<MenuItem href="/tokens" isActive={pathname.startsWith('/explore')}> <MenuItem href="/tokens" isActive={pathname.startsWith('/explore')}>
Tokens Tokens
</MenuItem> </MenuItem>
{phase1Flag === Phase1Variant.Enabled && ( {nftFlag === NftVariant.Enabled && (
<MenuItem href="/nfts" isActive={pathname.startsWith('/nfts')}> <MenuItem href="/nfts" isActive={pathname.startsWith('/nfts')}>
NFTs NFTs
</MenuItem> </MenuItem>
......
import { BaseVariant, FeatureFlag, useBaseFlag } from '../index' import { BaseVariant, FeatureFlag, useBaseFlag } from '../index'
export function usePhase1Flag(): BaseVariant { export function useNftFlag(): BaseVariant {
return useBaseFlag(FeatureFlag.phase1) return useBaseFlag(FeatureFlag.nft)
} }
export { BaseVariant as Phase1Variant } export { BaseVariant as NftVariant }
...@@ -56,7 +56,7 @@ export enum BaseVariant { ...@@ -56,7 +56,7 @@ export enum BaseVariant {
export enum FeatureFlag { export enum FeatureFlag {
navBar = 'navBar', navBar = 'navBar',
wallet = 'wallet', wallet = 'wallet',
phase1 = 'phase1', nft = 'nfts',
redesign = 'redesign', redesign = 'redesign',
tokens = 'tokens', tokens = 'tokens',
tokenSafety = 'tokenSafety', tokenSafety = 'tokenSafety',
......
...@@ -5,7 +5,7 @@ import Loader from 'components/Loader' ...@@ -5,7 +5,7 @@ import Loader from 'components/Loader'
import TopLevelModals from 'components/TopLevelModals' import TopLevelModals from 'components/TopLevelModals'
import { useFeatureFlagsIsLoaded } from 'featureFlags' import { useFeatureFlagsIsLoaded } from 'featureFlags'
import { NavBarVariant, useNavBarFlag } from 'featureFlags/flags/navBar' import { NavBarVariant, useNavBarFlag } from 'featureFlags/flags/navBar'
import { Phase1Variant, usePhase1Flag } from 'featureFlags/flags/phase1' import { NftVariant, useNftFlag } from 'featureFlags/flags/nft'
import { TokensVariant, useTokensFlag } from 'featureFlags/flags/tokens' import { TokensVariant, useTokensFlag } from 'featureFlags/flags/tokens'
import ApeModeQueryParamReader from 'hooks/useApeModeQueryParamReader' import ApeModeQueryParamReader from 'hooks/useApeModeQueryParamReader'
import { lazy, Suspense, useEffect } from 'react' import { lazy, Suspense, useEffect } from 'react'
...@@ -109,7 +109,7 @@ export default function App() { ...@@ -109,7 +109,7 @@ export default function App() {
const isLoaded = useFeatureFlagsIsLoaded() const isLoaded = useFeatureFlagsIsLoaded()
const tokensFlag = useTokensFlag() const tokensFlag = useTokensFlag()
const navBarFlag = useNavBarFlag() const navBarFlag = useNavBarFlag()
const phase1Flag = usePhase1Flag() const nftFlag = useNftFlag()
const { pathname } = useLocation() const { pathname } = useLocation()
const currentPage = getCurrentPageFromLocation(pathname) const currentPage = getCurrentPageFromLocation(pathname)
...@@ -210,7 +210,7 @@ export default function App() { ...@@ -210,7 +210,7 @@ export default function App() {
<Route path="*" element={<RedirectPathToSwapOnly />} /> <Route path="*" element={<RedirectPathToSwapOnly />} />
{phase1Flag === Phase1Variant.Enabled && ( {nftFlag === NftVariant.Enabled && (
<Route path="/nfts/collection/:contractAddress" element={<Collection />} /> <Route path="/nfts/collection/:contractAddress" element={<Collection />} />
)} )}
</Routes> </Routes>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment