Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
I
interface
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
LuckySwap
interface
Commits
3690936a
Unverified
Commit
3690936a
authored
Dec 15, 2022
by
Vignesh Mohankumar
Committed by
GitHub
Dec 15, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
chore: remove landing page flag (#5673)
parent
e95e2321
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
5 additions
and
31 deletions
+5
-31
FeatureFlagModal.tsx
src/components/FeatureFlagModal/FeatureFlagModal.tsx
+0
-7
featureFlags.ts
src/featureFlags/flags/featureFlags.ts
+0
-1
landingPage.ts
src/featureFlags/flags/landingPage.ts
+0
-7
App.tsx
src/pages/App.tsx
+1
-4
index.tsx
src/pages/Landing/index.tsx
+4
-12
No files found.
src/components/FeatureFlagModal/FeatureFlagModal.tsx
View file @
3690936a
import
{
BaseVariant
,
FeatureFlag
,
featureFlagSettings
,
useUpdateFlag
}
from
'
featureFlags
'
import
{
LandingPageVariant
,
useLandingPageFlag
}
from
'
featureFlags/flags/landingPage
'
import
{
Permit2Variant
,
usePermit2Flag
}
from
'
featureFlags/flags/permit2
'
import
{
TraceJsonRpcVariant
,
useTraceJsonRpcFlag
}
from
'
featureFlags/flags/traceJsonRpc
'
import
{
useAtomValue
,
useUpdateAtom
}
from
'
jotai/utils
'
...
...
@@ -203,12 +202,6 @@ export default function FeatureFlagModal() {
<
X
size=
{
24
}
/>
</
CloseButton
>
</
Header
>
<
FeatureFlagOption
variant=
{
LandingPageVariant
}
value=
{
useLandingPageFlag
()
}
featureFlag=
{
FeatureFlag
.
landingPage
}
label=
"Landing page"
/>
<
FeatureFlagOption
variant=
{
Permit2Variant
}
value=
{
usePermit2Flag
()
}
...
...
src/featureFlags/flags/featureFlags.ts
View file @
3690936a
export
enum
FeatureFlag
{
traceJsonRpc
=
'
traceJsonRpc
'
,
landingPage
=
'
landingPage
'
,
permit2
=
'
permit2
'
,
}
src/featureFlags/flags/landingPage.ts
deleted
100644 → 0
View file @
e95e2321
import
{
BaseVariant
}
from
'
../index
'
export
function
useLandingPageFlag
():
BaseVariant
{
return
BaseVariant
.
Enabled
}
export
{
BaseVariant
as
LandingPageVariant
}
src/pages/App.tsx
View file @
3690936a
...
...
@@ -4,7 +4,6 @@ import Loader from 'components/Loader'
import
{
MenuDropdown
}
from
'
components/NavBar/MenuDropdown
'
import
TopLevelModals
from
'
components/TopLevelModals
'
import
{
useFeatureFlagsIsLoaded
}
from
'
featureFlags
'
import
{
LandingPageVariant
,
useLandingPageFlag
}
from
'
featureFlags/flags/landingPage
'
import
ApeModeQueryParamReader
from
'
hooks/useApeModeQueryParamReader
'
import
{
Box
}
from
'
nft/components/Box
'
import
{
CollectionPageSkeleton
}
from
'
nft/components/collection/CollectionPageSkeleton
'
...
...
@@ -202,8 +201,6 @@ export default function App() {
const
isHeaderTransparent
=
!
scrolledState
const
landingPageFlag
=
useLandingPageFlag
()
return
(
<
ErrorBoundary
>
<
DarkModeQueryParamReader
/>
...
...
@@ -220,7 +217,7 @@ export default function App() {
<
Suspense
fallback=
{
<
Loader
/>
}
>
{
isLoaded
?
(
<
Routes
>
{
landingPageFlag
===
LandingPageVariant
.
Enabled
&&
<
Route
path=
"/"
element=
{
<
Landing
/>
}
/>
}
<
Route
path=
"/"
element=
{
<
Landing
/>
}
/>
<
Route
path=
"tokens"
element=
{
<
Tokens
/>
}
>
<
Route
path=
":chainName"
/>
</
Route
>
...
...
src/pages/Landing/index.tsx
View file @
3690936a
import
{
Trace
,
TraceEvent
}
from
'
@uniswap/analytics
'
import
{
BrowserEvent
,
ElementName
,
EventName
,
PageName
}
from
'
@uniswap/analytics-events
'
import
{
BaseButton
}
from
'
components/Button
'
import
{
LandingPageVariant
,
useLandingPageFlag
}
from
'
featureFlags/flags/landingPage
'
import
Swap
from
'
pages/Swap
'
import
{
useEffect
}
from
'
react
'
import
{
useLocation
}
from
'
react-router-dom
'
...
...
@@ -170,21 +169,14 @@ export default function Landing() {
const
location
=
useLocation
()
const
isOpen
=
location
.
pathname
===
'
/
'
const
landingPageFlag
=
useLandingPageFlag
()
useEffect
(()
=>
{
if
(
landingPageFlag
)
{
document
.
body
.
style
.
overflow
=
'
hidden
'
return
()
=>
{
document
.
body
.
style
.
overflow
=
'
auto
'
}
}
document
.
body
.
style
.
overflow
=
'
hidden
'
return
()
=>
{
// need to have a return so the hook doesn't throw.
document
.
body
.
style
.
overflow
=
'
auto
'
}
},
[
landingPageFlag
])
},
[])
if
(
landingPageFlag
===
LandingPageVariant
.
Control
||
!
isOpen
)
return
null
if
(
!
isOpen
)
return
null
return
(
<
Trace
page=
{
PageName
.
LANDING_PAGE
}
shouldLogImpression
>
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment