Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
I
interface
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
LuckySwap
interface
Commits
47a2768d
Unverified
Commit
47a2768d
authored
May 02, 2023
by
eddie
Committed by
GitHub
May 02, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
chore: remove unused feature flags (#6484)
parent
ca60caf6
Changes
6
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
4 additions
and
49 deletions
+4
-49
FeatureFlagModal.tsx
src/components/FeatureFlagModal/FeatureFlagModal.tsx
+0
-7
MobileBalanceSummaryFooter.tsx
...onents/Tokens/TokenDetails/MobileBalanceSummaryFooter.tsx
+1
-3
dummyFeatureGate.ts
src/featureFlags/flags/dummyFeatureGate.ts
+0
-9
featureFlags.ts
src/featureFlags/flags/featureFlags.ts
+0
-2
swapWidget.ts
src/featureFlags/flags/swapWidget.ts
+0
-11
index.tsx
src/pages/Landing/index.tsx
+3
-17
No files found.
src/components/FeatureFlagModal/FeatureFlagModal.tsx
View file @
47a2768d
import
{
BaseVariant
,
FeatureFlag
,
featureFlagSettings
,
useUpdateFlag
}
from
'
featureFlags
'
import
{
DetailsV2Variant
,
useDetailsV2Flag
}
from
'
featureFlags/flags/nftDetails
'
import
{
useWidgetRemovalFlag
,
WidgetRemovalVariant
}
from
'
featureFlags/flags/removeWidgetTdp
'
import
{
SwapWidgetVariant
,
useSwapWidgetFlag
}
from
'
featureFlags/flags/swapWidget
'
import
{
TraceJsonRpcVariant
,
useTraceJsonRpcFlag
}
from
'
featureFlags/flags/traceJsonRpc
'
import
{
useUpdateAtom
}
from
'
jotai/utils
'
import
{
Children
,
PropsWithChildren
,
ReactElement
,
ReactNode
,
useCallback
,
useState
}
from
'
react
'
...
...
@@ -203,12 +202,6 @@ export default function FeatureFlagModal() {
<
X
size=
{
24
}
/>
</
CloseButton
>
</
Header
>
<
FeatureFlagOption
variant=
{
SwapWidgetVariant
}
value=
{
useSwapWidgetFlag
()
}
featureFlag=
{
FeatureFlag
.
swapWidget
}
label=
"Swap Widget"
/>
<
FeatureFlagOption
variant=
{
DetailsV2Variant
}
value=
{
useDetailsV2Flag
()
}
...
...
src/components/Tokens/TokenDetails/MobileBalanceSummaryFooter.tsx
View file @
47a2768d
...
...
@@ -3,7 +3,6 @@ import { formatCurrencyAmount, NumberType } from '@uniswap/conedison/format'
import
{
Currency
}
from
'
@uniswap/sdk-core
'
import
{
useWeb3React
}
from
'
@web3-react/core
'
import
{
NATIVE_CHAIN_ID
}
from
'
constants/tokens
'
import
{
useDummyGateEnabled
}
from
'
featureFlags/flags/dummyFeatureGate
'
import
{
CHAIN_ID_TO_BACKEND_NAME
}
from
'
graphql/data/util
'
import
{
useStablecoinValue
}
from
'
hooks/useStablecoinPrice
'
import
useCurrencyBalance
from
'
lib/hooks/useCurrencyBalance
'
...
...
@@ -88,7 +87,6 @@ export default function MobileBalanceSummaryFooter({ token }: { token: Currency
const
formattedBalance
=
formatCurrencyAmount
(
balance
,
NumberType
.
TokenNonTx
)
const
formattedUsdValue
=
formatCurrencyAmount
(
useStablecoinValue
(
balance
),
NumberType
.
FiatTokenStats
)
const
chain
=
CHAIN_ID_TO_BACKEND_NAME
[
token
.
chainId
].
toLowerCase
()
const
isDummyGateFlagEnabled
=
useDummyGateEnabled
()
return
(
<
Wrapper
>
...
...
@@ -104,7 +102,7 @@ export default function MobileBalanceSummaryFooter({ token }: { token: Currency
</
BalanceInfo
>
)
}
<
SwapButton
to=
{
`/swap?chainName=${chain}&outputCurrency=${token.isNative ? NATIVE_CHAIN_ID : token.address}`
}
>
<
Trans
>
{
isDummyGateFlagEnabled
?
'
Go to Swap
'
:
'
Swap
'
}
</
Trans
>
<
Trans
>
Swap
</
Trans
>
</
SwapButton
>
</
Wrapper
>
)
...
...
src/featureFlags/flags/dummyFeatureGate.ts
deleted
100644 → 0
View file @
ca60caf6
import
{
BaseVariant
,
FeatureFlag
,
useBaseFlag
}
from
'
../index
'
function
useDummyGateFlag
():
BaseVariant
{
return
useBaseFlag
(
FeatureFlag
.
statsigDummy
)
}
export
function
useDummyGateEnabled
():
boolean
{
return
useDummyGateFlag
()
===
BaseVariant
.
Enabled
}
src/featureFlags/flags/featureFlags.ts
View file @
47a2768d
...
...
@@ -5,8 +5,6 @@ export enum FeatureFlag {
traceJsonRpc
=
'
traceJsonRpc
'
,
permit2
=
'
permit2
'
,
fiatOnRampButtonOnSwap
=
'
fiat_on_ramp_button_on_swap_page
'
,
swapWidget
=
'
swap_widget_replacement_enabled
'
,
statsigDummy
=
'
web_dummy_gate_amplitude_id
'
,
detailsV2
=
'
details_v2
'
,
removeWidget
=
'
remove_widget_tdp
'
,
}
src/featureFlags/flags/swapWidget.ts
deleted
100644 → 0
View file @
ca60caf6
import
{
BaseVariant
,
FeatureFlag
,
useBaseFlag
}
from
'
../index
'
export
function
useSwapWidgetFlag
():
BaseVariant
{
return
useBaseFlag
(
FeatureFlag
.
swapWidget
,
BaseVariant
.
Control
)
}
export
function
useSwapWidgetEnabled
():
boolean
{
return
useSwapWidgetFlag
()
===
BaseVariant
.
Enabled
}
export
{
BaseVariant
as
SwapWidgetVariant
}
src/pages/Landing/index.tsx
View file @
47a2768d
...
...
@@ -6,7 +6,6 @@ import Card, { CardType } from 'components/About/Card'
import
{
MAIN_CARDS
,
MORE_CARDS
}
from
'
components/About/constants
'
import
ProtocolBanner
from
'
components/About/ProtocolBanner
'
import
{
BaseButton
}
from
'
components/Button
'
import
{
useSwapWidgetEnabled
}
from
'
featureFlags/flags/swapWidget
'
import
{
useAtomValue
}
from
'
jotai/utils
'
import
Swap
from
'
pages/Swap
'
import
{
parse
}
from
'
qs
'
...
...
@@ -289,11 +288,6 @@ const Link = styled(NativeLink)`
${
LinkCss
}
`
const
WidgetLandingLink
=
styled
(
NativeLink
)
`
${
LinkCss
}
${
SwapCss
}
`
export
default
function
Landing
()
{
const
isDarkMode
=
useIsDarkMode
()
...
...
@@ -307,8 +301,6 @@ export default function Landing() {
ignoreQueryPrefix
:
true
,
})
const
swapWidgetEnabled
=
useSwapWidgetEnabled
()
// This can be simplified significantly once the flag is removed! For now being explicit is clearer.
useEffect
(()
=>
{
if
(
queryParams
.
intro
||
!
selectedWallet
)
{
...
...
@@ -330,15 +322,9 @@ export default function Landing() {
name=
{
SharedEventName
.
ELEMENT_CLICKED
}
element=
{
InterfaceElementName
.
LANDING_PAGE_SWAP_ELEMENT
}
>
{
swapWidgetEnabled
?
(
<
WidgetLandingLink
to=
"/swap"
>
<
Swap
/>
</
WidgetLandingLink
>
)
:
(
<
Link
to=
"/swap"
>
<
LandingSwap
/>
</
Link
>
)
}
<
Link
to=
"/swap"
>
<
LandingSwap
/>
</
Link
>
</
TraceEvent
>
</
LandingSwapContainer
>
<
Gradient
isDarkMode=
{
isDarkMode
}
/>
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment