Commit 47a2768d authored by eddie's avatar eddie Committed by GitHub

chore: remove unused feature flags (#6484)

parent ca60caf6
import { BaseVariant, FeatureFlag, featureFlagSettings, useUpdateFlag } from 'featureFlags' import { BaseVariant, FeatureFlag, featureFlagSettings, useUpdateFlag } from 'featureFlags'
import { DetailsV2Variant, useDetailsV2Flag } from 'featureFlags/flags/nftDetails' import { DetailsV2Variant, useDetailsV2Flag } from 'featureFlags/flags/nftDetails'
import { useWidgetRemovalFlag, WidgetRemovalVariant } from 'featureFlags/flags/removeWidgetTdp' import { useWidgetRemovalFlag, WidgetRemovalVariant } from 'featureFlags/flags/removeWidgetTdp'
import { SwapWidgetVariant, useSwapWidgetFlag } from 'featureFlags/flags/swapWidget'
import { TraceJsonRpcVariant, useTraceJsonRpcFlag } from 'featureFlags/flags/traceJsonRpc' import { TraceJsonRpcVariant, useTraceJsonRpcFlag } from 'featureFlags/flags/traceJsonRpc'
import { useUpdateAtom } from 'jotai/utils' import { useUpdateAtom } from 'jotai/utils'
import { Children, PropsWithChildren, ReactElement, ReactNode, useCallback, useState } from 'react' import { Children, PropsWithChildren, ReactElement, ReactNode, useCallback, useState } from 'react'
...@@ -203,12 +202,6 @@ export default function FeatureFlagModal() { ...@@ -203,12 +202,6 @@ export default function FeatureFlagModal() {
<X size={24} /> <X size={24} />
</CloseButton> </CloseButton>
</Header> </Header>
<FeatureFlagOption
variant={SwapWidgetVariant}
value={useSwapWidgetFlag()}
featureFlag={FeatureFlag.swapWidget}
label="Swap Widget"
/>
<FeatureFlagOption <FeatureFlagOption
variant={DetailsV2Variant} variant={DetailsV2Variant}
value={useDetailsV2Flag()} value={useDetailsV2Flag()}
......
...@@ -3,7 +3,6 @@ import { formatCurrencyAmount, NumberType } from '@uniswap/conedison/format' ...@@ -3,7 +3,6 @@ import { formatCurrencyAmount, NumberType } from '@uniswap/conedison/format'
import { Currency } from '@uniswap/sdk-core' import { Currency } from '@uniswap/sdk-core'
import { useWeb3React } from '@web3-react/core' import { useWeb3React } from '@web3-react/core'
import { NATIVE_CHAIN_ID } from 'constants/tokens' import { NATIVE_CHAIN_ID } from 'constants/tokens'
import { useDummyGateEnabled } from 'featureFlags/flags/dummyFeatureGate'
import { CHAIN_ID_TO_BACKEND_NAME } from 'graphql/data/util' import { CHAIN_ID_TO_BACKEND_NAME } from 'graphql/data/util'
import { useStablecoinValue } from 'hooks/useStablecoinPrice' import { useStablecoinValue } from 'hooks/useStablecoinPrice'
import useCurrencyBalance from 'lib/hooks/useCurrencyBalance' import useCurrencyBalance from 'lib/hooks/useCurrencyBalance'
...@@ -88,7 +87,6 @@ export default function MobileBalanceSummaryFooter({ token }: { token: Currency ...@@ -88,7 +87,6 @@ export default function MobileBalanceSummaryFooter({ token }: { token: Currency
const formattedBalance = formatCurrencyAmount(balance, NumberType.TokenNonTx) const formattedBalance = formatCurrencyAmount(balance, NumberType.TokenNonTx)
const formattedUsdValue = formatCurrencyAmount(useStablecoinValue(balance), NumberType.FiatTokenStats) const formattedUsdValue = formatCurrencyAmount(useStablecoinValue(balance), NumberType.FiatTokenStats)
const chain = CHAIN_ID_TO_BACKEND_NAME[token.chainId].toLowerCase() const chain = CHAIN_ID_TO_BACKEND_NAME[token.chainId].toLowerCase()
const isDummyGateFlagEnabled = useDummyGateEnabled()
return ( return (
<Wrapper> <Wrapper>
...@@ -104,7 +102,7 @@ export default function MobileBalanceSummaryFooter({ token }: { token: Currency ...@@ -104,7 +102,7 @@ export default function MobileBalanceSummaryFooter({ token }: { token: Currency
</BalanceInfo> </BalanceInfo>
)} )}
<SwapButton to={`/swap?chainName=${chain}&outputCurrency=${token.isNative ? NATIVE_CHAIN_ID : token.address}`}> <SwapButton to={`/swap?chainName=${chain}&outputCurrency=${token.isNative ? NATIVE_CHAIN_ID : token.address}`}>
<Trans>{isDummyGateFlagEnabled ? 'Go to Swap' : 'Swap'}</Trans> <Trans>Swap</Trans>
</SwapButton> </SwapButton>
</Wrapper> </Wrapper>
) )
......
import { BaseVariant, FeatureFlag, useBaseFlag } from '../index'
function useDummyGateFlag(): BaseVariant {
return useBaseFlag(FeatureFlag.statsigDummy)
}
export function useDummyGateEnabled(): boolean {
return useDummyGateFlag() === BaseVariant.Enabled
}
...@@ -5,8 +5,6 @@ export enum FeatureFlag { ...@@ -5,8 +5,6 @@ export enum FeatureFlag {
traceJsonRpc = 'traceJsonRpc', traceJsonRpc = 'traceJsonRpc',
permit2 = 'permit2', permit2 = 'permit2',
fiatOnRampButtonOnSwap = 'fiat_on_ramp_button_on_swap_page', fiatOnRampButtonOnSwap = 'fiat_on_ramp_button_on_swap_page',
swapWidget = 'swap_widget_replacement_enabled',
statsigDummy = 'web_dummy_gate_amplitude_id',
detailsV2 = 'details_v2', detailsV2 = 'details_v2',
removeWidget = 'remove_widget_tdp', removeWidget = 'remove_widget_tdp',
} }
import { BaseVariant, FeatureFlag, useBaseFlag } from '../index'
export function useSwapWidgetFlag(): BaseVariant {
return useBaseFlag(FeatureFlag.swapWidget, BaseVariant.Control)
}
export function useSwapWidgetEnabled(): boolean {
return useSwapWidgetFlag() === BaseVariant.Enabled
}
export { BaseVariant as SwapWidgetVariant }
...@@ -6,7 +6,6 @@ import Card, { CardType } from 'components/About/Card' ...@@ -6,7 +6,6 @@ import Card, { CardType } from 'components/About/Card'
import { MAIN_CARDS, MORE_CARDS } from 'components/About/constants' import { MAIN_CARDS, MORE_CARDS } from 'components/About/constants'
import ProtocolBanner from 'components/About/ProtocolBanner' import ProtocolBanner from 'components/About/ProtocolBanner'
import { BaseButton } from 'components/Button' import { BaseButton } from 'components/Button'
import { useSwapWidgetEnabled } from 'featureFlags/flags/swapWidget'
import { useAtomValue } from 'jotai/utils' import { useAtomValue } from 'jotai/utils'
import Swap from 'pages/Swap' import Swap from 'pages/Swap'
import { parse } from 'qs' import { parse } from 'qs'
...@@ -289,11 +288,6 @@ const Link = styled(NativeLink)` ...@@ -289,11 +288,6 @@ const Link = styled(NativeLink)`
${LinkCss} ${LinkCss}
` `
const WidgetLandingLink = styled(NativeLink)`
${LinkCss}
${SwapCss}
`
export default function Landing() { export default function Landing() {
const isDarkMode = useIsDarkMode() const isDarkMode = useIsDarkMode()
...@@ -307,8 +301,6 @@ export default function Landing() { ...@@ -307,8 +301,6 @@ export default function Landing() {
ignoreQueryPrefix: true, ignoreQueryPrefix: true,
}) })
const swapWidgetEnabled = useSwapWidgetEnabled()
// This can be simplified significantly once the flag is removed! For now being explicit is clearer. // This can be simplified significantly once the flag is removed! For now being explicit is clearer.
useEffect(() => { useEffect(() => {
if (queryParams.intro || !selectedWallet) { if (queryParams.intro || !selectedWallet) {
...@@ -330,15 +322,9 @@ export default function Landing() { ...@@ -330,15 +322,9 @@ export default function Landing() {
name={SharedEventName.ELEMENT_CLICKED} name={SharedEventName.ELEMENT_CLICKED}
element={InterfaceElementName.LANDING_PAGE_SWAP_ELEMENT} element={InterfaceElementName.LANDING_PAGE_SWAP_ELEMENT}
> >
{swapWidgetEnabled ? (
<WidgetLandingLink to="/swap">
<Swap />
</WidgetLandingLink>
) : (
<Link to="/swap"> <Link to="/swap">
<LandingSwap /> <LandingSwap />
</Link> </Link>
)}
</TraceEvent> </TraceEvent>
</LandingSwapContainer> </LandingSwapContainer>
<Gradient isDarkMode={isDarkMode} /> <Gradient isDarkMode={isDarkMode} />
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment