Commit 84f5d8f9 authored by eddie's avatar eddie Committed by GitHub

fix: only log swap success for swap txs (#7284)

parent bb28235b
...@@ -12,7 +12,7 @@ import { L2_CHAIN_IDS } from '../../constants/chains' ...@@ -12,7 +12,7 @@ import { L2_CHAIN_IDS } from '../../constants/chains'
import { useAddPopup } from '../application/hooks' import { useAddPopup } from '../application/hooks'
import { isPendingTx } from './hooks' import { isPendingTx } from './hooks'
import { checkedTransaction, finalizeTransaction } from './reducer' import { checkedTransaction, finalizeTransaction } from './reducer'
import { SerializableTransactionReceipt, TransactionDetails } from './types' import { SerializableTransactionReceipt, TransactionDetails, TransactionType } from './types'
export function toSerializableReceipt(receipt: TransactionReceipt): SerializableTransactionReceipt { export function toSerializableReceipt(receipt: TransactionReceipt): SerializableTransactionReceipt {
return { return {
...@@ -58,7 +58,9 @@ export default function Updater() { ...@@ -58,7 +58,9 @@ export default function Updater() {
}) })
) )
logSwapSuccess(hash, chainId, analyticsContext) if (pendingTransactions[hash] && pendingTransactions[hash].info?.type === TransactionType.SWAP) {
logSwapSuccess(hash, chainId, analyticsContext)
}
addPopup( addPopup(
{ {
...@@ -69,7 +71,7 @@ export default function Updater() { ...@@ -69,7 +71,7 @@ export default function Updater() {
isL2 ? L2_TXN_DISMISS_MS : DEFAULT_TXN_DISMISS_MS isL2 ? L2_TXN_DISMISS_MS : DEFAULT_TXN_DISMISS_MS
) )
}, },
[addPopup, analyticsContext, dispatch, isL2] [addPopup, analyticsContext, dispatch, isL2, pendingTransactions]
) )
return <LibUpdater pendingTransactions={pendingTransactions} onCheck={onCheck} onReceipt={onReceipt} /> return <LibUpdater pendingTransactions={pendingTransactions} onCheck={onCheck} onReceipt={onReceipt} />
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment