Commit 9cb19dd0 authored by Zach Pomerantz's avatar Zach Pomerantz Committed by GitHub

fix: filter integrator fee (#3281)

parent 02a77254
...@@ -45,24 +45,22 @@ export default function Details({ trade, allowedSlippage }: DetailsProps) { ...@@ -45,24 +45,22 @@ export default function Details({ trade, allowedSlippage }: DetailsProps) {
const { inputAmount, outputAmount } = trade const { inputAmount, outputAmount } = trade
const inputCurrency = inputAmount.currency const inputCurrency = inputAmount.currency
const outputCurrency = outputAmount.currency const outputCurrency = outputAmount.currency
const priceImpact = useMemo(() => computeRealizedPriceImpact(trade), [trade])
const lpFeeAmount = useMemo(() => computeRealizedLPFeeAmount(trade), [trade])
const integrator = window.location.hostname const integrator = window.location.hostname
const feeOptions = useAtomValue(feeOptionsAtom) const feeOptions = useAtomValue(feeOptionsAtom)
const priceImpact = useMemo(() => computeRealizedPriceImpact(trade), [trade])
const lpFeeAmount = useMemo(() => computeRealizedLPFeeAmount(trade), [trade])
const { i18n } = useLingui() const { i18n } = useLingui()
const details = useMemo(() => { const details = useMemo(() => {
const rows = [] const rows = []
// @TODO(ianlapham): Check that provider fee is even a valid list item // @TODO(ianlapham): Check that provider fee is even a valid list item
if (feeOptions) { if (feeOptions) {
const parsedConvenienceFee = formatCurrencyAmount(outputAmount.multiply(feeOptions.fee), 6, i18n.locale) const fee = outputAmount.multiply(feeOptions.fee)
rows.push([ if (fee.greaterThan(0)) {
t`${integrator} fee`, const parsedFee = formatCurrencyAmount(fee, 6, i18n.locale)
`${parsedConvenienceFee} ${outputCurrency.symbol || currencyId(outputCurrency)}`, rows.push([t`${integrator} fee`, `${parsedFee} ${outputCurrency.symbol || currencyId(outputCurrency)}`])
]) }
} }
const priceImpactRow = [t`Price impact`, `${priceImpact.toFixed(2)}%`] const priceImpactRow = [t`Price impact`, `${priceImpact.toFixed(2)}%`]
...@@ -74,11 +72,8 @@ export default function Details({ trade, allowedSlippage }: DetailsProps) { ...@@ -74,11 +72,8 @@ export default function Details({ trade, allowedSlippage }: DetailsProps) {
rows.push(priceImpactRow) rows.push(priceImpactRow)
if (lpFeeAmount) { if (lpFeeAmount) {
const localizedFeeAmount = formatCurrencyAmount(lpFeeAmount, 6, i18n.locale) const parsedLpFee = formatCurrencyAmount(lpFeeAmount, 6, i18n.locale)
rows.push([ rows.push([t`Liquidity provider fee`, `${parsedLpFee} ${inputCurrency.symbol || currencyId(inputCurrency)}`])
t`Liquidity provider fee`,
`${localizedFeeAmount} ${inputCurrency.symbol || currencyId(inputCurrency)}`,
])
} }
if (trade.tradeType === TradeType.EXACT_OUTPUT) { if (trade.tradeType === TradeType.EXACT_OUTPUT) {
...@@ -110,6 +105,7 @@ export default function Details({ trade, allowedSlippage }: DetailsProps) { ...@@ -110,6 +105,7 @@ export default function Details({ trade, allowedSlippage }: DetailsProps) {
outputCurrency, outputCurrency,
inputCurrency, inputCurrency,
]) ])
return ( return (
<> <>
{details.map(([label, detail, color]) => ( {details.map(([label, detail, color]) => (
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment