fix: add null check to collection floor price (#4528)

* add null check to collection floor price

* don't show 0 if floor is null

* formatEthPrice accepts udnefined
Co-authored-by: Charlie <charlie@uniswap.org>

src/components/NavBar/SearchBar.tsx

@@ -141,7 +141,7 @@ export const SearchBarDropdown = ({ toggleOpen, tokens, collections, hasInput }:
         return {
           ...collection,
           collectionAddress: collection.address,
-          floorPrice: formatEthPrice(collection.floor.toString()),
+          floorPrice: formatEthPrice(collection.floor?.toString()),
           stats: {
             total_supply: collection.totalSupply,
             one_day_change: collection.floorChange,

src/components/NavBar/SuggestionRow.tsx

@@ -78,14 +78,14 @@ export const CollectionRow = ({ collection, isHovered, setHoveredIndex, toggleOp
           <Box className={styles.secondaryText}>{putCommas(collection.stats.total_supply)} items</Box>
         </Column>
       </Row>
-      {collection.floorPrice && (
+      {collection.floorPrice ? (
         <Column className={styles.suggestionSecondaryContainer}>
           <Row gap="4">
             <Box className={styles.primaryText}>{ethNumberStandardFormatter(collection.floorPrice)} ETH</Box>
           </Row>
           <Box className={styles.secondaryText}>Floor</Box>
         </Column>
-      )}
+      ) : null}
     </Link>
   )
 }

src/nft/utils/currency.ts

@@ -16,7 +16,7 @@ export const formatUSDPriceWithCommas = (price: number) => {
     .replace(/\B(?=(\d{3})+(?!\d))/g, ',')}`
 }
 
-export const formatEthPrice = (price: string) => {
+export const formatEthPrice = (price: string | undefined) => {
   if (!price) return 0
 
   const formattedPrice = parseFloat(formatEther(String(price)))