Commit c1297b2a authored by shortcircuit's avatar shortcircuit Committed by GitHub

fix: Use html for linking to tax services (#6124)

* Use html for linking to tax services

* Add target blank

* styling

* override default styling

---------
Co-authored-by: default avatarLynn Yu <lynn.yu@uniswap.org>
parent 6ab6f4da
...@@ -84,10 +84,6 @@ const TOKEN_TAX_DESCRIPTION = 'Save 10% on all plans' ...@@ -84,10 +84,6 @@ const TOKEN_TAX_DESCRIPTION = 'Save 10% on all plans'
const COINTRACKER_DESCRIPTION = 'New and existing users save up to 20%' const COINTRACKER_DESCRIPTION = 'New and existing users save up to 20%'
function TaxServiceOption({ description, logo, url }: TaxServiceOptionProps) { function TaxServiceOption({ description, logo, url }: TaxServiceOptionProps) {
const openTaxServiceLink = () => {
window.open(url, '_blank')
}
return ( return (
<TaxOption tabIndex={0}> <TaxOption tabIndex={0}>
<StyledImageContainer as="img" src={logo} draggable={false} /> <StyledImageContainer as="img" src={logo} draggable={false} />
...@@ -101,14 +97,11 @@ function TaxServiceOption({ description, logo, url }: TaxServiceOptionProps) { ...@@ -101,14 +97,11 @@ function TaxServiceOption({ description, logo, url }: TaxServiceOptionProps) {
: InterfaceElementName.TAX_SERVICE_COINTRACKER_BUTTON : InterfaceElementName.TAX_SERVICE_COINTRACKER_BUTTON
} }
> >
<Button <a href={url} target="_blank" rel="noreferrer" style={{ textDecoration: 'none' }}>
size={ButtonSize.medium} <Button size={ButtonSize.medium} emphasis={ButtonEmphasis.medium} data-testid="tax-service-option-button">
emphasis={ButtonEmphasis.medium} Get started
onClick={openTaxServiceLink} </Button>
data-testid="tax-service-option-button" </a>
>
Get started
</Button>
</TraceEvent> </TraceEvent>
</TaxOption> </TaxOption>
) )
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment