Commit ca02a6b5 authored by eddie's avatar eddie Committed by GitHub

fix: log opt in impression (#6959)

* fix: log opt in impression

* fix: move trace up to parent level
parent b722a20d
...@@ -30,6 +30,7 @@ import { ThemedText } from 'theme' ...@@ -30,6 +30,7 @@ import { ThemedText } from 'theme'
export const UniswapXOptIn = (props: { swapInfo: SwapInfo; isSmall: boolean }) => { export const UniswapXOptIn = (props: { swapInfo: SwapInfo; isSmall: boolean }) => {
const { const {
trade: { trade }, trade: { trade },
allowedSlippage,
} = props.swapInfo } = props.swapInfo
const userDisabledUniswapX = useUserDisabledUniswapX() const userDisabledUniswapX = useUserDisabledUniswapX()
const isOnClassic = Boolean(trade && isClassicTrade(trade) && trade.isUniswapXBetter && !userDisabledUniswapX) const isOnClassic = Boolean(trade && isClassicTrade(trade) && trade.isUniswapXBetter && !userDisabledUniswapX)
...@@ -44,7 +45,15 @@ export const UniswapXOptIn = (props: { swapInfo: SwapInfo; isSmall: boolean }) = ...@@ -44,7 +45,15 @@ export const UniswapXOptIn = (props: { swapInfo: SwapInfo; isSmall: boolean }) =
return null return null
} }
return <OptInContents isOnClassic={isOnClassic} {...props} /> return (
<Trace
shouldLogImpression
name="UniswapX Opt In Impression"
properties={trade ? formatCommonPropertiesForTrade(trade, allowedSlippage) : undefined}
>
<OptInContents isOnClassic={isOnClassic} {...props} />
</Trace>
)
} }
const OptInContents = ({ const OptInContents = ({
...@@ -111,20 +120,8 @@ const OptInContents = ({ ...@@ -111,20 +120,8 @@ const OptInContents = ({
const containerRef = useRef<HTMLDivElement>() const containerRef = useRef<HTMLDivElement>()
const wrapTrace = (children: JSX.Element) => {
return (
<Trace
shouldLogImpression={isVisible}
name="UniswapX Opt In Impression"
properties={trade ? formatCommonPropertiesForTrade(trade, allowedSlippage) : undefined}
>
{children}
</Trace>
)
}
if (isSmall) { if (isSmall) {
return wrapTrace( return (
<SwapOptInSmallContainer ref={containerRef as any} visible={isVisible} shouldAnimate={shouldAnimate}> <SwapOptInSmallContainer ref={containerRef as any} visible={isVisible} shouldAnimate={shouldAnimate}>
<SwapMustache> <SwapMustache>
<UniswapXShine /> <UniswapXShine />
...@@ -143,7 +140,7 @@ const OptInContents = ({ ...@@ -143,7 +140,7 @@ const OptInContents = ({
) )
} }
return wrapTrace( return (
<> <>
{/* first popover: intro */} {/* first popover: intro */}
<UniswapXOptInPopover shiny visible={isVisible && !showYoureIn}> <UniswapXOptInPopover shiny visible={isVisible && !showYoureIn}>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment