Commit d24c62ec authored by aballerr's avatar aballerr Committed by GitHub

fix: Minor polish fixes (#5407)

* Loading state fixes, make volume lowercase, remove loading circle
parent 2ea70d18
...@@ -185,7 +185,7 @@ export const CollectionNftsLoading = () => ( ...@@ -185,7 +185,7 @@ export const CollectionNftsLoading = () => (
export const CollectionNftsAndMenuLoading = () => ( export const CollectionNftsAndMenuLoading = () => (
<InfiniteScrollWrapper> <InfiniteScrollWrapper>
<Column alignItems="flex-start" position="relative" width="full"> <Column alignItems="flex-start" position="relative" width="full">
<Row marginY="12" gap="12"> <Row marginY="12" gap="12" marginBottom="40">
<Box className={loadingAsset} borderRadius="12" width={{ sm: '44', md: '100' }} height="44" /> <Box className={loadingAsset} borderRadius="12" width={{ sm: '44', md: '100' }} height="44" />
<Box <Box
className={loadingAsset} className={loadingAsset}
......
import Column from 'components/Column' import Column from 'components/Column'
import Row from 'components/Row' import Row from 'components/Row'
import { Box } from 'nft/components/Box'
import { useIsMobile } from 'nft/hooks' import { useIsMobile } from 'nft/hooks'
import { BannerWrapper, CollectionBannerLoading } from 'nft/pages/collection' import { BannerWrapper, CollectionBannerLoading } from 'nft/pages/collection'
import { ScreenBreakpointsPaddings } from 'nft/pages/collection/index.css' import { ScreenBreakpointsPaddings } from 'nft/pages/collection/index.css'
...@@ -14,10 +13,6 @@ const CollectionDescriptionSection = styled(Column)` ...@@ -14,10 +13,6 @@ const CollectionDescriptionSection = styled(Column)`
${ScreenBreakpointsPaddings} ${ScreenBreakpointsPaddings}
` `
const CollectionAssets = styled(Box)`
${ScreenBreakpointsPaddings}
`
const StyledColumn = styled(Column)` const StyledColumn = styled(Column)`
width: 100%; width: 100%;
` `
...@@ -38,9 +33,7 @@ export const CollectionPageSkeleton = () => { ...@@ -38,9 +33,7 @@ export const CollectionPageSkeleton = () => {
<CollectionStatsLoading isMobile={isMobile} /> <CollectionStatsLoading isMobile={isMobile} />
<StyledRow>{ActivitySwitcherLoading}</StyledRow> <StyledRow>{ActivitySwitcherLoading}</StyledRow>
</CollectionDescriptionSection> </CollectionDescriptionSection>
<CollectionAssets> <CollectionNftsAndMenuLoading />
<CollectionNftsAndMenuLoading />
</CollectionAssets>
</StyledColumn> </StyledColumn>
) )
} }
...@@ -306,7 +306,7 @@ const StatsRow = ({ stats, isMobile, ...props }: { stats: GenieCollection; isMob ...@@ -306,7 +306,7 @@ const StatsRow = ({ stats, isMobile, ...props }: { stats: GenieCollection; isMob
</StatsItem> </StatsItem>
) : null} ) : null}
{stats.stats?.total_volume ? ( {stats.stats?.total_volume ? (
<StatsItem label="Total Volume" shouldHide={false}> <StatsItem label="Total volume" shouldHide={false}>
{totalVolumeStr} ETH {totalVolumeStr} ETH
</StatsItem> </StatsItem>
) : null} ) : null}
......
...@@ -252,7 +252,15 @@ export default function App() { ...@@ -252,7 +252,15 @@ export default function App() {
{nftFlag === NftVariant.Enabled && ( {nftFlag === NftVariant.Enabled && (
<> <>
<Route path="/nfts" element={<NftExplore />} /> <Route
path="/nfts"
element={
// TODO: replace loading state during Apollo migration
<Suspense fallback={null}>
<NftExplore />
</Suspense>
}
/>
<Route <Route
path="/nfts/asset/:contractAddress/:tokenId" path="/nfts/asset/:contractAddress/:tokenId"
element={ element={
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment