Commit ddf88345 authored by Moody Salem's avatar Moody Salem Committed by GitHub

fix(token lists): stop showing notifications for lists that are not selected (#1174)

parent 32ac2555
...@@ -13,6 +13,9 @@ export default function Updater(): null { ...@@ -13,6 +13,9 @@ export default function Updater(): null {
const { library } = useActiveWeb3React() const { library } = useActiveWeb3React()
const dispatch = useDispatch<AppDispatch>() const dispatch = useDispatch<AppDispatch>()
const lists = useSelector<AppState, AppState['lists']['byUrl']>(state => state.lists.byUrl) const lists = useSelector<AppState, AppState['lists']['byUrl']>(state => state.lists.byUrl)
const selectedListUrl = useSelector<AppState, AppState['lists']['selectedListUrl']>(
state => state.lists.selectedListUrl
)
const isWindowVisible = useIsWindowVisible() const isWindowVisible = useIsWindowVisible()
...@@ -54,45 +57,49 @@ export default function Updater(): null { ...@@ -54,45 +57,49 @@ export default function Updater(): null {
// automatically update minor/patch as long as bump matches the min update // automatically update minor/patch as long as bump matches the min update
if (bump >= min) { if (bump >= min) {
dispatch(acceptListUpdate(listUrl)) dispatch(acceptListUpdate(listUrl))
if (listUrl === selectedListUrl) {
dispatch(
addPopup({
key: listUrl,
content: {
listUpdate: {
listUrl,
oldList: list.current,
newList: list.pendingUpdate,
auto: true
}
}
})
)
}
} else {
console.error(
`List at url ${listUrl} could not automatically update because the version bump was only PATCH/MINOR while the update had breaking changes and should have been MAJOR`
)
}
break
case VersionUpgrade.MAJOR:
if (listUrl === selectedListUrl) {
dispatch( dispatch(
addPopup({ addPopup({
key: listUrl, key: listUrl,
content: { content: {
listUpdate: { listUpdate: {
listUrl, listUrl,
auto: false,
oldList: list.current, oldList: list.current,
newList: list.pendingUpdate, newList: list.pendingUpdate
auto: true
} }
} },
removeAfterMs: null
}) })
) )
} else {
console.error(
`List at url ${listUrl} could not automatically update because the version bump was only PATCH/MINOR while the update had breaking changes and should have been MAJOR`
)
} }
break
case VersionUpgrade.MAJOR:
dispatch(
addPopup({
key: listUrl,
content: {
listUpdate: {
listUrl,
auto: false,
oldList: list.current,
newList: list.pendingUpdate
}
},
removeAfterMs: null
})
)
} }
} }
}) })
}, [dispatch, lists]) }, [dispatch, lists, selectedListUrl])
return null return null
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment